mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: openbmc@lists.ozlabs.org, Paul Menzel <pmenzel@molgen.mpg.de>,
	Joel Stanley <joel@jms.id.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: nuvoton: Fix Kconfig
Date: Sun, 12 Feb 2023 12:46:00 +0100	[thread overview]
Message-ID: <CAMuHMdU6=qTHEGM6U2o7JOuEGxRmRaOnUkVhepoYKLy71XDNJg@mail.gmail.com> (raw)
In-Reply-To: <20230212113111.1720685-1-j.neuschaefer@gmx.net>

Hi Jonathan,

On Sun, Feb 12, 2023 at 12:31 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Unfortunately, version 5 of the Nuvoton WPCM450 SoC driver was applied
> to bmc.git, which misses a few fixes that were in version 6.
>
> This patch adds the missing fixes:

Thanks for your patch!

>  - Add a menu "Nuvoton SoC drivers" to make it easier to add other
>    Nuvoton SoC drivers later on

... and to prevent asking about the Nuvoton WPCM450 SoC driver when
configuring a kernel without support for Nuvoton SoCs.

>  - select CONFIG_REGMAP from CONFIG_WPCM450_SOC

Please include why this is needed.

>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  drivers/soc/nuvoton/Kconfig | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
> index df46182088ec2..2167d3d739d84 100644
> --- a/drivers/soc/nuvoton/Kconfig
> +++ b/drivers/soc/nuvoton/Kconfig
> @@ -1,11 +1,17 @@
>  # SPDX-License-Identifier: GPL-2.0
> -menuconfig WPCM450_SOC
> +menu "Nuvoton SoC drivers"
> +       depends on ARCH_NPCM || COMPILE_TEST
> +
> +config WPCM450_SOC
>         tristate "Nuvoton WPCM450 SoC driver"
>         default y if ARCH_WPCM450
>         select SOC_BUS
> +       select REGMAP
>         help
>           Say Y here to compile the SoC information driver for Nuvoton
>           WPCM450 SoCs.
>
>           This driver provides information such as the SoC model and
>           revision.
> +

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2023-02-12 11:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 11:31 Jonathan Neuschäfer
2023-02-12 11:46 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdU6=qTHEGM6U2o7JOuEGxRmRaOnUkVhepoYKLy71XDNJg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®