From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2217221F1F for ; Wed, 13 May 2026 13:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778678124; cv=none; b=dO6UVFrGuqZm175i0urMJQx8mAiqC+KK95IguXm3+yomLTixaySfMqNzjEJ3BI5dDpeCfoZ3jTJH/Hy+Cx+w+vExNmTYApQ68vKU74Bgv1T9MKfm2xVx5yC3X5/Zp0RJiWA4WsHuiiEGD9Mpn39LJpbx/6TwHrCWD2LEF/2pfiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778678124; c=relaxed/simple; bh=oV7lWg4lz210rteMJfOa33sA9nixlf2kec/RbjFlF7A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=INhugRpUeDqKe1M4o/4p4SYBMYVtRRIUjOpYu08ehQC4fcFDgTUqPwKPkraTgIxIKTlYk82elhe+HtUgMeKow4vV5LMGrK3tk4wxFnTwk5lLJv1N7WDoqZd31FvVbUYOsiz2q9KH6HyJb/R4mAcOjD7gC4a/SXBp2ClDaDd+HdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-56a857578a8so2308599e0c.3 for ; Wed, 13 May 2026 06:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778678122; x=1779282922; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+8cNW33wiaXVwXT9Hgyi/JcE/ejaGgsPgY1Fa4o6ZiI=; b=b/cD7RynIw4XLWNFLXmF+qAtmzNGoxx1DRT0raFq9A5mNHLTrq/2KQv26TlpPbJC+V MOuQVNuzcqJOcx7GUQ2RxFJor/nDbiC+5UA3ghx0F0BbnUfkT2hEb6L9R6GMZp2bwHxw tJ0T7JSbE2fklxeOeuW399J1gNVRNpmPS8xGth6CiTG0+aV7UvurJlpYY/Qi6LF6vylG h2iwn58nI+0c86CgmacV2qdA5z3Dxinio7B3aFtmTR2+XkXl094LUShcnkjzfJBDlXu1 I7rA62x3giUYNwDFPXoE6WsjQobHJkgS9rx2wAmwmmZzcEkvKO2YwNbAqkwKfloJvSaw mN/g== X-Forwarded-Encrypted: i=1; AFNElJ+UuqblnDiCZZMMk3k5fJYq4AoTQ2hzx+tlbk48is+okQUXr1rTIBj1U7SeuFpaZpesaf+rCCATN0cMVSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yza8m1eQaXZlCGl1L6uOpKdBdQ+MwAztUIb+MREuAsYJ6KwoI+8 MR4X5DeFFIFV7vNEGrmdsvf6/goeVAs2LER1HDn+K0eYIsU3tq5QtXrjzDNU6BHP X-Gm-Gg: Acq92OFlNOJgQKNXUOL0dtyDF6s5fciy1oijlMTrt2L58KqgdeLRpgSWWS7NmtBgKhP eGgoRavyMxuiYCBEcDlIJdrK6QtTb85JhBwHSOnR6EMNJz1o0DIqqZ7y9Bz5+1fgn2q0XcRov5H jgavhx+xNlAPCDuy8a7GT/LuI0n2hlS8r1/lDoAHHqOtrx/HVLIvd/O/oYFPKcxgNOVbJph3aEX cpjt7wG7ZZavlp3aZfG0pSuEejuSbfNZ6WcYdfaWi1S4PoxLfDhWYhcHs9ZrS1ITxq6cP8St2Kp J09/uXcAUkHQ2fvxar3w6um+HsFR6KFuWkUFY6L9541x5r6EZJtdg6E5O+kkETrCbTaChmmcTxn lfdmjz0HBcDad7+xujRQTFL+sBTVyX+4zz14IFqiUMcZ/S+Hx1DXwSeDuW4bnnKIqmJsls+OP1q PBUNm1XW2irXbN64k378xi4QDnwZMyDgKGQLlRosUQUKwplzC+Ady34vcvxS/cyXCZUJszkPPZ2 xo= X-Received: by 2002:a05:6122:d25:b0:56c:ce0b:fecd with SMTP id 71dfb90a1353d-575e70a7075mr1239850e0c.12.1778678122573; Wed, 13 May 2026 06:15:22 -0700 (PDT) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com. [209.85.221.181]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95f217739e7sm9164755241.0.2026.05.13.06.15.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 06:15:21 -0700 (PDT) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-56a857578a8so2308577e0c.3 for ; Wed, 13 May 2026 06:15:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ/EhoB7Z+pvMDDVHhCFb3Z5l9HN1N595kB8zC80NIg7LqO6p2+KAdLJCXcFT2wD/Ah/IZMhe84TcHRpfY8=@vger.kernel.org X-Received: by 2002:a05:6122:d25:b0:56c:ce0b:fecd with SMTP id 71dfb90a1353d-575e70a7075mr1239716e0c.12.1778678120886; Wed, 13 May 2026 06:15:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260502185557.93061-1-marek.vasut+renesas@mailbox.org> <20260502185557.93061-3-marek.vasut+renesas@mailbox.org> In-Reply-To: <20260502185557.93061-3-marek.vasut+renesas@mailbox.org> From: Geert Uytterhoeven Date: Wed, 13 May 2026 15:15:09 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4JTrqWXHc77xf-iSrs-bkBREqw0nQKCK-qidhrABbBSLqD0EGxY-SoFw7w Message-ID: Subject: Re: [PATCH 2/4] clk: renesas: r8a73a4: Implement ZT/ZTR trace clock on R-Mobile APE6 To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Conor Dooley , Krzysztof Kozlowski , Magnus Damm , Michael Turquette , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Marek, On Sat, 2 May 2026 at 20:56, Marek Vasut wrote: > Implement ZT trace bus and ZTR trace clock on the R-Mobile APE6. > > Signed-off-by: Marek Vasut Thanks for your patch! /sys/kernel/debug/clk/clk_summary looks a bit off to me: zt 0 0 0 208000000 ztr 0 0 0 277333334 > --- a/drivers/clk/renesas/clk-r8a73a4.c > +++ b/drivers/clk/renesas/clk-r8a73a4.c > @@ -43,6 +43,8 @@ static struct div4_clk div4_clks[] = { > { "m1", CPG_FRQCRA, 4 }, > { "m2", CPG_FRQCRA, 0 }, > { "zx", CPG_FRQCRB, 12 }, > + { "ztr", CPG_FRQCRB, 16 }, 20? > + { "zt", CPG_FRQCRB, 12 }, 16? (12 is zx, cfr. above). I.e. the same shifts as on R-Mobile A1. > { "zs", CPG_FRQCRB, 8 }, > { "hp", CPG_FRQCRB, 4 }, > { NULL, 0, 0 }, After fixing the shifts, I get: zt 0 0 0 277333334 ztr 0 0 0 277333334 which looks much better. If you agree, I can fix this while applying. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds