From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbbIAKfs (ORCPT ); Tue, 1 Sep 2015 06:35:48 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36560 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334AbbIAKfr (ORCPT ); Tue, 1 Sep 2015 06:35:47 -0400 MIME-Version: 1.0 In-Reply-To: <1441102876-26978-1-git-send-email-colin.king@canonical.com> References: <1441102876-26978-1-git-send-email-colin.king@canonical.com> Date: Tue, 1 Sep 2015 12:35:46 +0200 X-Google-Sender-Auth: gwJxCbxFmqP853JBif-MUklt4jE Message-ID: Subject: Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg From: Geert Uytterhoeven To: Colin King Cc: Geoff Levand , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. What about just removing the BUG_ON()? The system will crash anyway, providing a backtrace. > Signed-off-by: Colin Ian King > --- > drivers/ps3/ps3-vuart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c > index d6db822..632701a 100644 > --- a/drivers/ps3/ps3-vuart.c > +++ b/drivers/ps3/ps3-vuart.c > @@ -1000,12 +1000,11 @@ static int ps3_vuart_probe(struct ps3_system_bus_device *dev) > dev_dbg(&dev->core, "%s:%d\n", __func__, __LINE__); > > drv = ps3_system_bus_dev_to_vuart_drv(dev); > + BUG_ON(!drv); > > dev_dbg(&dev->core, "%s:%d: (%s)\n", __func__, __LINE__, > drv->core.core.name); > > - BUG_ON(!drv); > - > if (dev->port_number >= PORT_COUNT) { > BUG(); > return -EINVAL; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds