From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3D53F888C for ; Tue, 4 Aug 2026 14:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785853891; cv=none; b=jjvrRpPYRqdVC5zTLGxHRV1XRTC4Hvsaqeuy7c12raNzFqFbwYDNJhEsosFDWyR/NFzGUIwBqy5AOsYVUXVDj1Mn0lIwoCloFJLTt7cwAw+FyZZkkyUbaTFrVYTqvybufrlsdbPQSJ/Z1ywp35E9Al9h0kI9opaEpcAwSSSbZw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785853891; c=relaxed/simple; bh=QiJCNRyg0hPZ2mI4Gjma0OFzO/BLvZ2oUgJygGTgQGU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=o0pKN3/RLWZIohg3wDceq/wN4w8dJImBcyzxb0Ak6dyUJVX5rzabJT6n4+MWpPpwDA28wAIerolGqyMVJYnhvpOmvYswultG6mYbIwxQJGvpbeuL8jtZuxzLJrIkgwjep69/tE+IfJ9NSa0VO3QEvng2+dSxXATYFjnZ7x3CVGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-5c2dbaf828eso1741543e0c.0 for ; Tue, 04 Aug 2026 07:31:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785853876; x=1786458676; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WfbQ4y5yUdy2TJAvCiAC8jxLj5JOJo3d5fP3Tj0QSMo=; b=eFdqxMcV6/NVF8rqLgqnv4RrkKUj5TAfa4w8NM7hBZUV+YK/XQSi7hCvWSDHJDATsB 766tmhRLZOishFlehnEXQHHYdGB8ReZLh+GqLdOZdLak2zWFsQna6LYZJ2b48/6zt1/b m9HtqV5/v84grlk/B3bg97d+LFeuPatoPRwd6E8HWe9dp/4wKYm0Ci0JTsKImXP3Dgpm 0MkvPdaSmz3OnehnTWRIo3LQV6n92MIn0NwOiuAZE0tpSweQE0PgiJ7YFBYYlb8AV2sk 5GuDveUMI4WJTAw0jbP+/+UDgPZSi19jnOOW8Nh5boBRxnH1DvgwX9DJgEV1h56N+4IQ KWTA== X-Forwarded-Encrypted: i=1; AHgh+Rp/SUZkQbvacVIo/jSyb4hCYpcAB41baRyQXZhFTVI3GyO9vVPgrHvc5a4Qkgac5tVkiyfdDhk1b7i6Yes=@vger.kernel.org X-Gm-Message-State: AOJu0YwQxqasJjuk5XNxW5thFj+yTkXg5mjRLnywCaiatnsOS1jz2NPI BmrsgvJfrqjffOU0f11JBOhvpo7pQQGbIsP3eQ7y7W84zImOzy35A/4B/8BDLYEU X-Gm-Gg: AR+sD10s/oLp0VDCTDkqcPDO53qIl2nzo6pPZ30MOcQm2xTYqfyGinIIH/uONITVB2j vT61t5hb/2N+/Wctj98dSbiq+Ots8VV6Uus9TxbQfv7oIQod4//r4bdBiakSjsj8NF4A2e8IcYu 2yf8iH0zsZMC/XFR6Es035/SuK3zEndrOtkMqWUJzVhzHyEpqSvygijoaNd2cPpiErSFA98L1gv v7PvoAMHBglO+9Tsj9Ll9eIosQ4C8Jz4ZyMj2WNPj5sSHJUoSlE4WouPc9nUEi3Op15fv/ebZk5 Lk1SUm8PjuX48sRL1cwDcpcbihr1fda3RpSLmKlU3VhptswYI+X7FOwAGicX2lxq+VBGWg6lgKp yWMf5gaKWC7QYJI9K5/lSUYIJmnPIzLryPKZfpyszfVeNw3w3cZzrhxSsH6LY7gOM1BQPRh8kBz 9BStg2mAQlGSAJgaygCc+ZyWHByayr74N8a796aJENMvxJzeezWkvegTg1JptaJy8tzMICRtmWr NnJDjO5ALhkyHAWvU04Uj3yfnARUQ== X-Received: by 2002:a05:6122:45a0:b0:5c2:c0de:f06a with SMTP id 71dfb90a1353d-5c38787a160mr3730991e0c.14.1785853874433; Tue, 04 Aug 2026 07:31:14 -0700 (PDT) Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com. [209.85.221.175]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9782c798337sm208890241.3.2026.08.04.07.31.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 07:31:14 -0700 (PDT) Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-5c2dbaf828eso1741497e0c.0 for ; Tue, 04 Aug 2026 07:31:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RpNUptwpBrxHSVX/wb7u55WdNRSkQdvGd4CNHkVWstfkWej3i5nONyeMLh1NqxMJqNZUkIKpSbEH3ikSEc=@vger.kernel.org X-Received: by 2002:a05:6122:4687:b0:5c2:ac92:eb18 with SMTP id 71dfb90a1353d-5c387704235mr3498906e0c.7.1785853873478; Tue, 04 Aug 2026 07:31:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260728005610.575268-1-rosenp@gmail.com> In-Reply-To: <20260728005610.575268-1-rosenp@gmail.com> From: Geert Uytterhoeven Date: Tue, 4 Aug 2026 16:31:02 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mzx-BRg1E-s4SG7HkbYeAMYP1kt95Rsysb98ELpkM0oLgUWl-DNPpZmMiA Message-ID: Subject: Re: [PATCH] rtc: msm6242: use devm_platform_ioremap_resource() To: Rosen Penev Cc: linux-rtc@vger.kernel.org, Alexandre Belloni , open list , linux-m68k Content-Type: text/plain; charset="UTF-8" CC linux-m68k On Tue, 28 Jul 2026 at 02:56, Rosen Penev wrote: > Replace the open-coded platform_get_resource() plus devm_ioremap() > sequence with a single devm_platform_ioremap_resource() call, which folds > the resource lookup and mapping into one step and returns an ERR_PTR on > failure, checked with IS_ERR() and propagated via PTR_ERR(). Thanks for your patch! > The rtc-msm6242 platform device (arch/m68k/amiga/platform.c) provides a > single IORESOURCE_MEM window (0x00dc0000-0x00dcffff). It shares that > resource definition with rtc-rp5c01, but the two are registered under the > mutually exclusive A2000_CLK and A3000_CLK hardware flags, so only one > RTC device exists on a given machine. The region reservation now > performed by devm_platform_ioremap_resource() therefore introduces no > conflict. Any patches adding seemingly safe region reservations need testing on actual hardware. > Assisted-by: opencode:hy3-free > Signed-off-by: Rosen Penev > --- a/drivers/rtc/rtc-msm6242.c > +++ b/drivers/rtc/rtc-msm6242.c > @@ -188,21 +188,20 @@ static const struct rtc_class_ops msm6242_rtc_ops = { > > static int __init msm6242_rtc_probe(struct platform_device *pdev) > { > - struct resource *res; > struct msm6242_priv *priv; > struct rtc_device *rtc; > + void __iomem *regs; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -ENODEV; > + regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(regs)) > + return PTR_ERR(regs); > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > - priv->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); > - if (!priv->regs) > - return -ENOMEM; > + priv->regs = regs; > + > platform_set_drvdata(pdev, priv); > > rtc = devm_rtc_device_register(&pdev->dev, "rtc-msm6242", Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds