From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755330AbbCEMC5 (ORCPT ); Thu, 5 Mar 2015 07:02:57 -0500 Received: from mail-oi0-f43.google.com ([209.85.218.43]:38726 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbCEMCz (ORCPT ); Thu, 5 Mar 2015 07:02:55 -0500 MIME-Version: 1.0 In-Reply-To: <1425489871-22415-8-git-send-email-peter@hurleysoftware.com> References: <1425489871-22415-1-git-send-email-peter@hurleysoftware.com> <1425489871-22415-8-git-send-email-peter@hurleysoftware.com> Date: Thu, 5 Mar 2015 13:02:54 +0100 X-Google-Sender-Auth: nuB-aGth96HMl33lU3a3Pb3cOWI Message-ID: Subject: Re: [PATCH -next 07/12] serial: earlycon: Common log banner for command line and DT From: Geert Uytterhoeven To: Peter Hurley Cc: Greg Kroah-Hartman , Grant Likely , Rob Herring , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Wed, Mar 4, 2015 at 6:24 PM, Peter Hurley wrote: > --- a/drivers/tty/serial/earlycon.c > +++ b/drivers/tty/serial/earlycon.c > @@ -69,6 +69,7 @@ static void __init earlycon_init(struct earlycon_device *device, > const char *name) > { > struct console *earlycon = device->con; > + struct uart_port *port = &device->port; > const char *s; > size_t len; > > @@ -82,6 +83,16 @@ static void __init earlycon_init(struct earlycon_device *device, > len = s - name; > strlcpy(earlycon->name, name, min(len + 1, sizeof(earlycon->name))); > earlycon->data = &early_console_dev; > + > + if (port->iotype == UPIO_MEM || port->iotype == UPIO_MEM32) > + pr_info("Early serial console at MMIO%s 0x%llx (options '%s')\n", > + (port->iotype == UPIO_MEM32) ? "32" : "", > + (unsigned long long)port->mapbase, I know you're just moving this piece of code around, but mapbase is a resource_size_t (it should actually be phys_addr_t, which probably didn't exist in 2007), so it should be printed using %pa and passing a reference, instead of %llx and using a cast. > + device->options); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds