From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDD23BD631 for ; Wed, 1 Apr 2026 08:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032828; cv=none; b=JwArOHAGzZvnsR3/9kf97SfiqmqhCTE0mHdigBtb262xsAH1qEAraQ8y31z5fK5iY1Khebg4ncdth++kTynvydgGC3bU4hmFgTcCbMWVq99Wh9cgePDnHTKhrkEaHOEHTNOgXaQoc3viPs5rUQjlhnqVi3XpWU2+GFXkobtmxwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775032828; c=relaxed/simple; bh=3s3LfhNqe/vU4X2yUsFGVqtyA8/HXi9SqILM/RQmCqU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Hdt30Bv3SA0FNN9ITEhkYYH0igUzfx6vAC0bE51KgRqg9D3fHtkT4XsV8dYzBPWkBwRJJRQdJFeNuLFjJVZuK3XpnLs/TMUBmEFadY52+5ipwSKpsa9IGLdtBMk3ldU80exMLOEMhFcVDNjp42OSjMGD9j5dcaJsinWxpl+zshs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-56d8d479149so170935e0c.2 for ; Wed, 01 Apr 2026 01:40:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775032821; x=1775637621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UjkBPhSq2KNJwwC5a6VjrIfS+wjdobuUB/quFKLmn9I=; b=NJI3tB1VsRZo95BqmSJydFIPnKXxwlNzyjZA+umgdZ7P79nt7aK72ZRcTNpHYw18VP GKSlGuXwN9Ky6LJ8IeIcUcKUHzTOubl8QHWHnOzcFW234qEhcHhovYhx2D5JcECUPOOF de+YSVaYCq6zawpGlCJTMCdTUOj7r4FG9Ny4LsFpWurTtXK/qgcXsgDHoUp3/iLV0K/B yO7iVoa5iTUxN8QFX0bwJV6svXZFhilXUZ6nlhed/q3oNj9LjUUMV4L9FsYMXbNjrhYq Upy/Z4s7vq2/i8mWWD3V70i+WSfZOC55n6TdjfNfOaXTNPKvvKo2JEgy+SiMKI9yhzXM pLFw== X-Forwarded-Encrypted: i=1; AJvYcCUJVSUF7ZILNDUZzTM/fz0zB/PKEHj0eAtqlyV7aEwWgeUiHk0clogqhnbtFrQUbLvUiZskfGf8n5cd+5c=@vger.kernel.org X-Gm-Message-State: AOJu0YxS5Fw1FvjZZjZkh2IrQiYGfm3CU0AWdd77JUImqyK13ve9wChF ybL6zNrBZ4jcyEUpiI0gM1ZZMLb47UIQs/8vmrd/53KB/gk5+NHvesKXoTJqvRLD X-Gm-Gg: ATEYQzw8B3Jo96s0X1nJWru27OrB5u7usxlIesOD3QGjb+39PkAMukeLFNNV0gZ+wXI /jSSHdPRZznfgqjKiyrKOx6rqOXSqXfysL503SrnoSeW94iiNsII6kEKDMFN3a9O3xMegJNp/Qw OJJjuxvQa7vMZRwcB528eMh5D8Tm38R7BMjZNJ8khf2F2Y54WUv5yr+zUDGXHkDiFdgJYeAq04Q 6kocJ+j6oR39g61I20Jhqlh8mGuHjIqiwiu8mkcxDYz4fkKFRLVgpDaUrYGIBnQjlJy/YHcJVL/ ZldbQ3Q1XTQNcIjFuy4eNCdyH2bcmi5S8xPDeOr3YhL3Mz+xe7cfM1Hpy3KjMjfkAxHyqDDBmSz MbBFJ6cDrXV+XRr7Gl54O1cXGQAlApsi9qB7PuE+1pA8Rbtlb7XURMqClCHLuU6oRT+9cqIkwk7 TWX0ntpitdY+WbFX8C5Uv3unO9duc0LhUajRbYXRfJ9cqf0oUynYKXCfGe6SMf X-Received: by 2002:a05:6122:7ca:b0:56c:da22:6921 with SMTP id 71dfb90a1353d-56d8a810f28mr1161220e0c.5.1775032821433; Wed, 01 Apr 2026 01:40:21 -0700 (PDT) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com. [209.85.217.54]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d885eac2fsm3479745e0c.1.2026.04.01.01.40.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 01:40:20 -0700 (PDT) Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-605048a9c94so1541415137.0 for ; Wed, 01 Apr 2026 01:40:20 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXMPc2CMfoJ6I1okc5aoP4guCIA1X0/mh5eNLSM0S33rgSmkFv1A8UTKzTlSOSvQiivM798npohCVCYAxM=@vger.kernel.org X-Received: by 2002:a05:6102:3749:b0:602:a9f3:74d8 with SMTP id ada2fe7eead31-60568183e55mr762941137.25.1775032820403; Wed, 01 Apr 2026 01:40:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260331-fix-atomic-poll-timeout-regression-v1-1-5b7bd96eaca0@bereza.email> <833bb42a-65b8-4c93-8109-d2959f8b807f@amd.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 1 Apr 2026 10:40:09 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzBtK2awVoYZlNLRH_TxbROG8uZpU4rpSXf9Z2mSy2RwErngCSoFK_0ago8 Message-ID: Subject: Re: [PATCH] dmaengine: xilinx_dma: Fix CPU stall in xilinx_dma_poll_timeout To: Alex Bereza Cc: "Gupta, Suraj" , Vinod Koul , Frank Li , Michal Simek , Ulf Hansson , Arnd Bergmann , Tony Lindgren , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Alex, On Wed, 1 Apr 2026 at 10:27, Alex Bereza wrote: > On Wed Apr 1, 2026 at 7:23 AM CEST, Suraj Gupta wrote: > >> Rename XILINX_DMA_LOOP_COUNT to XILINX_DMA_POLL_TIMEOUT_US because the > >> former is incorrect. It is a timeout value for polling various register > >> bits in microseconds. It is not a loop count. Add a constant > >> XILINX_DMA_POLL_DELAY_US for delay_us value. > > > > Please split this change in a new patch. > > Ok, will send a v2. > > >> Fixes: 7349a69cf312 ("iopoll: Do not use timekeeping in read_poll_timeout_atomic()") > > > > This patch doesn't fixes anything in iopoll, please use correct fixes tag. Fixes-tag are also used as guidelines, to indicate which patches are also needed when backporting something. I.e. if 7349a69cf312 is ever backported, any other commits that contain "Fixes: 7349a69cf312" should be backported, too. So having this Fixes-tag, in addition to another xilinx_dma-specific one, sounds fine to me. > Ok, but I'm not sure what would be the correct fixes tag then? I though I need to reference > 7349a69cf312 in fixes tag because this is the actual change that surfaced the CPU stall issue that I > want to fix in this driver. I'm fixing the call sites of xilinx_dma_poll_timeout but they were added > in different commits. Should I add all of them? That would be the following then: > > Fixes: 9495f2648287 ("dmaengine: xilinx_vdma: Use readl_poll_timeout instead of do while loop's") > Fixes: 676f9c26c330 ("dmaengine: xilinx: fix device_terminate_all() callback for AXI CDMA") Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds