From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BCDC356772 for ; Fri, 14 Aug 2026 14:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786716023; cv=none; b=ElSQSPYiSM8THjB989FLlikiUqGBWqwf3+qR6HnjiW8FgjGKRz1skmPnWGUTdGhMd13ys0QxQMPqymeJbpwS5KQ5aQ9onJ7u5P0ZWgYP+5KSOOVueeC3gslFDOUpEB3ZE1mvKFZHjNtXKmjh0pjhvzcEpL9s9abk1Z3jxIigt3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786716023; c=relaxed/simple; bh=jnE+zrjdRPIAG/V+osLYILlYKK1uGEGBACBgUDiHPsk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MMwKUvYUuGLC1qHbsdOQ86tce/MecSDLaIR2twVUCPO4JzFh4WASHv+oFbNXYAD0cXtnLuXPvQWvrNG5IyaoyuuHOgJcjGpHFse12DxQP9srd1qyjgYjm2tyUnnG3e1w9bO91e7aeMvm67pOv0t/6w7kApeyT/l3PXJ7PUxLiKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-977fca41f52so463885241.1 for ; Fri, 14 Aug 2026 07:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786716021; x=1787320821; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=KBeE4Jbhv9pyM12HVw9v14dd7K0sZrphzuP4RnOH+Ow=; b=eGGe9vMg12pn8JaD8U11MV1bNiCuu8r08HcVGB+PaXVlSBaCn+N65gM1doojZ5iwQW l4pTW+kvb44wb0nzAUOLYCdolJylNrLa/htOPfKBaBs6Fafb7E6WEttdfmEa9ZOULSv4 /t53R8JHV83Prm2X1ImohzTAsHe86adUZb5yIdfnc+0FbnRrFl4m4HBsh0MTIKaRv2Ik JymklWOQ9LoJdonu389DYE1iWM7WOHyMZ50Y1fenrUP0wYrak8QJ6MCsR/p8HOJmnAhF 0ixSnHQxqqCJLT/QU94R1N2862w+/d/nvwmZ40Qu4nXaEwfKnnIBWz7kO0lvX7mEDuSC TKTA== X-Forwarded-Encrypted: i=1; AHgh+RpTJN2xpdhUXIkSEoj59p/odwHfHmZyurntDwNBNa0JsOHx6O02c7aOeDi+pVGkRvKDzFpUBlgPt3eGZ5E=@vger.kernel.org X-Gm-Message-State: AOJu0Yykmn7Urgn0YqG+j/xo27CU1BwN3ZYe0W0olIuBEVMtBV324oyT LnJixYvS+pKA1Wr4723eLlxXpeV7GIx6f95U15mtAZJhbb8cKGpsTSKy2KoS13n6LfE= X-Gm-Gg: AR+sD12xAVjulJK7lYVUzoZI0cIEK5Xdc9JI2LL+vZi/qoh0hJiHlBmuj6ycRpJAoET cT5A86AeFfSyzIHIC2LwTiGUtfbRIGv35LPIOmbnvO0ZqwCvWLWWiur7Z0bKkKxpebX3tzMguKt MbZfYBITulEocGrrZnWqp8W7TY7K/yhopYKvIdF8jfmRKT3CYXerNY2s8O1Ce8H77tjU2jF23Gd rYPzCdmYCat8qL2URxL4IAGIofPFXZcKajf4CPzV2eJ7DwwE4jbNfey7NIo2yXjjAcmxC2Qnlty SBYnCeIFApyVJkYU8TDhrvBybdxge0FiG59PWXNP3z9PPqLjG9gxLv/RCAIxZKyp8qG5nErTC+K Zx+Eow9CB4SQCJ24F/xJPZRWxOypn61FqfFm73FlIo2YfHb9XOgbHsEU1lEvp7LJA2DyQDEuB6g g1nI7RJTdv84U2tx/Q2RSsLuOVfjayk5mH5bg7KsFRcS+SiSggP/DjffVqchs2gjP5ySKCdMd5Q sWVMd+Ppv40r5tzRuSnb9b5ke9loQ== X-Received: by 2002:a05:6102:5f0c:b0:745:6b08:c338 with SMTP id ada2fe7eead31-76f2c43997amr1215206137.10.1786716020574; Fri, 14 Aug 2026 07:00:20 -0700 (PDT) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com. [209.85.221.172]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-76efab1d7fesm1239202137.11.2026.08.14.07.00.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 07:00:20 -0700 (PDT) Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-5c2c46a428eso666172e0c.2 for ; Fri, 14 Aug 2026 07:00:19 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RqXmGH4RXGlCq4ezPfYx/2frWoFGZFKiKClAPZqxqvoeEB5pT8eXNo/S4e3klqHfzZMOJiAi8Er8qWRkJ8=@vger.kernel.org X-Received: by 2002:a05:6122:488f:b0:5c4:1a0a:b52e with SMTP id 71dfb90a1353d-5c591ec9771mr1475551e0c.9.1786716019318; Fri, 14 Aug 2026 07:00:19 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260814134931.2281085-2-manuelebnerli@mailbox.org> In-Reply-To: <20260814134931.2281085-2-manuelebnerli@mailbox.org> From: Geert Uytterhoeven Date: Fri, 14 Aug 2026 16:00:07 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AcwNN1Xs2dRzpNCH6XKGLdEjSAU8N4IlXfCduMH-dczukYBUWMKvueNqo7GJal4 Message-ID: Subject: Re: [PATCH] ver_linux: add comparison with required version and colour to output To: Manuel Ebner Cc: Jonathan Corbet , Shuah Khan , workflows@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Hi Manuel, On Fri, 14 Aug 2026 at 15:55, Manuel Ebner wrote: > Add the required version from changes.rst. > Add code for comparison and print in colour (blue, green, red) depending > on the result of the comparison. > > Signed-off-by: Manuel Ebner Thanks for your patch! > --- a/scripts/ver_linux > +++ b/scripts/ver_linux > @@ -89,9 +92,17 @@ function version(cmd, ver) { > return ver > } > > -function printversion(name, value, ofmt) { > - if (value != "") { > +function printversion(name, cur_version, req_version, ofmt) { > + if (req_version == "") { > ofmt = "%-20s\t%s\n" > - printf(ofmt, name, value) > + printf(ofmt, "\033[34m"name, cur_version) > + } > + else if (cur_version >= req_version) { > + ofmt = "%-20s\t%s\n" > + printf(ofmt, "\033[32m"name, cur_version) > + } > + else { > + ofmt = "%-20s\t%s\n" > + printf(ofmt, "\033[31m"name, cur_version) > } > } None of the above reset the color (using "\033[37m", or the shorter "\033[0m"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds