From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A5E2980A8 for ; Wed, 1 Oct 2025 13:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759324650; cv=none; b=lheUnl6cfHi1WzQbxP+KhhLZdTCwvgCQHJSbTPvGS1cH7rksb9Ie1WnzZFJANspWcQ+UbZ6GUtvplRRGdbL0RijOaiEcM9weQS9+VxWINUkEcdWdp+KR47DAYI9oidYqVPWnN1JNDKsFjBbIUhyspOtb47VP2J6jvl6BRs73w3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759324650; c=relaxed/simple; bh=I05mR9/50DLTEHHaHy45Q5YQgLDEg9VchuCah9dVd2k=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=j32dqjWvN5ZfXex5Fvgz9wVbimjEfNJfwe0k5/85zHj1GNPPcnSrb0BatGFQBZRQr1TvRTW3rI6MGgH2HyWQq/Veuu9ImQnaQcVo1MQnyGsatJyrbjI6If/DW9nWE1jFIVLMu8UQvlCdgokIkjnsnJTLUmTleHKYxIhOv0B1uzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-8e364003538so4848772241.3 for ; Wed, 01 Oct 2025 06:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759324647; x=1759929447; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fYdalTnEkJlTI6nAxkZ1pZoLmc57oQNk8+NRjQz1+SA=; b=rMoc5pLP15zuI17Zsh0r1WYXAblYyJhi/WLnj6P0t0kKlYlUWIytqQwPzMksL8gjdO K/H8TquAd8OYDLVGIcPlhZMSAlKCHLiD71Zk6si4RJlKTVhS4mUvDDrZ6eZHTq52TUWo DbncfPZ10lFBqPpoZW0QhoTUw1Fc8H9VWa+IzwvXkuzXOEMmNkpnjU6FyGz7cUU6XDQn N5ZKmx3r42x0fc246GbdMoIPO5bRCnsZJppMaNVLXT40eO/d0QdhtTz05DJbyD7/OVY1 P0wQrozo46R0b7SA4UDJ7IusMtTM8qdMAXD3qoyW7ei/cU8cDb9rL5diLiRMsYsY8ex7 0Zrw== X-Forwarded-Encrypted: i=1; AJvYcCU46gAZbgVDmPPwjMEV2xxmYXchSNH3yeI0nWIS0fDddlKh9qKA5pIUN8EbGL7K3j0xTdNB0kJM3n5JfEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxUDoPk7LB+YkC90USSPjgQ9jAllV2ULgss9eh2d9qChIWERDSm TKlBCPd6+vrrRhsSxvlkv3OPlOqHjCscz16ZB1QsuEHf1YNS4DMFj7RZwr/V9ya6 X-Gm-Gg: ASbGncvzPsPaGDZ7UoN6WJBTmAwJqg7B03f9YrwfwG6/FqHnEjPyCFSQxKcX+3EURNa bRQpM+g+SN/KK4Dpubr9OtrlseymQXDcS2ZqH01iXpXjPInreM6Q2mKiILt4Tupmf6++M0xAvpq eST3fFk8MJwObufG1C0hRjG1hPZBb5J7M1Jnoj6Xt88COQhuogjkaiE+XPhHR8kWtWC73U7q66p pa/8TgOPB2ejqUpQP7SNB7jPg9xewnRPG3EdGcqYY2MKTxcCTnw5IwIEkkNDsbegjgP7KGn/qSa ADbHQp9IC/epdIEQGVxu+SPNAtszPZ0XCqwN2dADa3dk4kqXQaKwOqRaKpd0xEsBBT/MTvgxiG2 GPjBnwFsEu5fFxx1iehrIteAPMOTvccPl/sPxlNzSsSSHAtSrgeAxPJJHjOnnQCE0DbLmWHopuC 60k/CWp3mi X-Google-Smtp-Source: AGHT+IHq1Z8myVqdDdGY0uKoGmB/tOcEHBqG9okwjWjmHNSc1U3DTPLw7DlzJvn5j79Nl4YgY1B0dg== X-Received: by 2002:a05:6122:3bd1:b0:54c:6e3:88 with SMTP id 71dfb90a1353d-5522d338beemr1494166e0c.4.1759324647048; Wed, 01 Oct 2025 06:17:27 -0700 (PDT) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com. [209.85.217.47]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-54bedc9f653sm3443194e0c.16.2025.10.01.06.17.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 06:17:26 -0700 (PDT) Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-5ce093debf6so2748513137.1 for ; Wed, 01 Oct 2025 06:17:25 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVnBRYRmNYhzXRWqT3EZcVAT5HdmJK8SpzF/eHcWO3xYJ7ntYJEzPRwMGXuOvk0C3UfD0sgoVSaxDN1Jms=@vger.kernel.org X-Received: by 2002:a05:6102:161e:b0:58f:31da:dbd3 with SMTP id ada2fe7eead31-5d3fe509ac2mr1393313137.13.1759324645740; Wed, 01 Oct 2025 06:17:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250903161718.180488-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250903161718.180488-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 1 Oct 2025 15:17:14 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWDiZs7Ynz61qNNAVC6cUY3oeLbFhcjv_kGBKaaXq5pMP7Ji5m5RgOlqVh8 Message-ID: Subject: Re: [PATCH v8 2/6] clk: renesas: rzv2h-cpg: Add support for DSI clocks To: "Lad, Prabhakar" Cc: Tomi Valkeinen , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, Fabrizio Castro , Tommaso Merciai , Lad Prabhakar , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Biju Das , Magnus Damm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Prabhakar, On Wed, 1 Oct 2025 at 14:23, Lad, Prabhakar wr= ote: > On Thu, Sep 11, 2025 at 3:26=E2=80=AFPM Tomi Valkeinen > wrote: > > I still don't see why all the code here has to be in a header file. > > Usually headers contain only a few lines of inline code. Is there a > > reason why it's not in a .c file? > > > Ok, I will move the functions to rzv2h-cpg.c and export the symbols > and have the declarations in include/linux/clk/renesas.h. > > Geert are you OK with the above? Sure. The DRM driver would already have a hard dependency on the clock header file anyway. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds