From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA543F7A97 for ; Fri, 15 May 2026 07:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778831780; cv=none; b=Ad1P3oNM09gjfBVtqIYtqBR0VFpAs+el6C51S2BKnigpaVM4vBo7xvm9lCXo23xrE3KFGOKQLmgYTulcOuGOA208r02UHU+UfBBUmJvqz8ulNy+u5hB5haEBIsGKvCYuAQDPjtfcYWfBzR9sQqL/VnKkW21n/J42J+yo+jDjIzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778831780; c=relaxed/simple; bh=IF78aL4qhYcYFoQ/xoUYLUDn+1jiumlt7gMiBumVb88=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NoNY9Jt9kFVTQ1+CTlO/sF7+LHIgAMz3qERI3lAhaPW30Ys+4Qv9ruoU9BkEQSH5yI7IErAr/IMVn+wDyqx7/kbXBkP5DLoKeiYgP79Ugfwwv2G1rx4Ynwx7nxfCc43LsuFGPoVfqYrRV6P09t2YAHaBjJfutEP37W9qSP1Wu+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-83538fbd0b2so3565217b3a.0 for ; Fri, 15 May 2026 00:56:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778831779; x=1779436579; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eAZHu6XpvwN5l5f2FSQxtIsJfHFz80+bclBZd6bS4os=; b=CEzV+r2glPJJ/0CYtzyDL4YmFG7lvwwsvJ8aO+H2250hGOiRlzJHPF6o74UOpJWxhm UnfBrJ03cV7X6E2yT3iMKpDV/c/BnAen80Zls7wrTYeO+v7HIo9Nqx6JeRBZXIAEfCuW s3nat2sNwv97ZqKdS+tz4Nhn0wMy0O6wkxfmjf3hKt0CguwsBxRdoXba/jLorFlGAh99 SWg9m+p1dlWx5+waFsnDSZDs8Uj+juv55lvv2AmSUF3kQC045pe+x8zwG91W+9ZqeOed 0Eeb5gyU6DdJeVOfrZlI3mLlqLRSqKtnBsXaY33lUVM7CO2Gb2bHcQhMrO7CyAC5z4e+ bdfA== X-Forwarded-Encrypted: i=1; AFNElJ+XE5FU3zKGGEvemOM8fVUt2BLuiObLGRBxmN+RDzWjwxRq1PK256Jzt8BMyXcjEkpiF3eMU9IPGgxP9n4=@vger.kernel.org X-Gm-Message-State: AOJu0YzROj5D7pPSdzOZzg8LxbGDMaas5yeGLLBr4HE5v9Wo7xY7AeYc zKwZUiRvBURB74T+MrhNMtufdqSx3cZicCDXpH/jOMv8B2zcmuil/3oXAUu/27JR X-Gm-Gg: Acq92OH/NiMsADzOdVHl0wVl46gJLy+robLWrInX02+eCgi6DX6hLCG/aqeylA1YTf2 pjOOEjAhbsUTUT3FTkeejdzUdo82mlIUvZGzbiicFQgbaYVv4I1Fipt7B1VE4OlagonERRarVCL qkaE0vScT6MWWrQg9UeVKTjlTzoKSp/nkz/1s+nDSlLlElmknpElDO4ITHbdZXNdMNPIqos+hLB /CScGivwdOOhtSWiBpq/lMR9q5uOeHX5+9vMCo1ktVZB315ErGeI3QZpW3S4M0ADNizu5ooPB+7 Dd6timELc48o+a0SBth1y3jJT0K2pHlCd7XQZa89CmPjzOFZekp8mbA0+x+/VCoj19+L9tfU4Xo +4kO/i1fqhYEa11seZSzCKbAZCKdRNs9gUzhH4Ykdkast5D/f61OIQxsi1OHa8yTj6HqRJe4lnc w8G+DzE6CFmSGNYdqzKAjH2C8i4hsGrXPTxfTwrdXK2eomtiXJNxGDGy+Vj1A= X-Received: by 2002:a05:6a00:3d08:b0:81e:b2ba:5b3a with SMTP id d2e1a72fcca58-83f33bc7c26mr3379012b3a.8.1778831778756; Fri, 15 May 2026 00:56:18 -0700 (PDT) Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com. [74.125.82.52]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f196660easm5043353b3a.11.2026.05.15.00.56.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 00:56:18 -0700 (PDT) Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-133466cf955so5100859c88.0 for ; Fri, 15 May 2026 00:56:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ8z9/n5xjjPn7KcyxYKCE7XE1dXS2CY00CwIZQcf14v03bp3lGNKbpuoNHclByCfhB2aQgDGCy/qEs4PV4=@vger.kernel.org X-Received: by 2002:a05:6102:3f05:b0:62e:63e8:427b with SMTP id ada2fe7eead31-63a39a5f9e4mr1494077137.0.1778831365156; Fri, 15 May 2026 00:49:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260514-rcar-du-dsc-v1-0-d65f7a9e9841@ideasonboard.com> <20260514-rcar-du-dsc-v1-3-d65f7a9e9841@ideasonboard.com> In-Reply-To: <20260514-rcar-du-dsc-v1-3-d65f7a9e9841@ideasonboard.com> From: Geert Uytterhoeven Date: Fri, 15 May 2026 09:49:14 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4KQ6u1JetcDt3qGv1sa7SAF13W-c5qtL3drtJoKYhKLpQQVXnl4eLgch0w Message-ID: Subject: Re: [PATCH 3/5] drm/rcar-du: dsc: Add rudimentary Renesas R-Car V4H DSC driver To: Tomi Valkeinen Cc: Michael Turquette , Stephen Boyd , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Marek Vasut , Laurent Pinchart , Kieran Bingham , Philipp Zabel , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Tomi, On Thu, 14 May 2026 at 14:25, Tomi Valkeinen wrote: > From: Marek Vasut > > The Renesas DSC Display Stream Compression is a bridge embedded in the > Renesas R-Car V4H SoC. The bridge performs VESA DSC encoding of up to > 8k or 400 Mpixel/s . Add rudimentary driver, which currently acts as a > pass-through bridge and allows DSI1 to be operational on R-Car V4H. > > Signed-off-by: Marek Vasut > [tomi.valkeinen: use bridge->next_bridge, minor changes] > Signed-off-by: Tomi Valkeinen Thanks for your patch! > --- /dev/null > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_dsc.c > + > +static void rcar_dsc_atomic_enable(struct drm_bridge *bridge, > + struct drm_atomic_state *state) > +{ > + struct rcar_dsc *dsc = bridge_to_rcar_dsc(bridge); > + > + WARN_ON(clk_prepare_enable(dsc->clk)); Who don't you use pm_runtime_resume_and_get() instead, like rcar_cmm.c? Then you don't need to get the clock at all, and the driver will keep on working if the DSC ever ends up in a power domain. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds