From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 491C6C432BE for ; Tue, 24 Aug 2021 15:46:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 356BD6125F for ; Tue, 24 Aug 2021 15:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238476AbhHXPrC (ORCPT ); Tue, 24 Aug 2021 11:47:02 -0400 Received: from mail-ua1-f47.google.com ([209.85.222.47]:39705 "EHLO mail-ua1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238457AbhHXPq7 (ORCPT ); Tue, 24 Aug 2021 11:46:59 -0400 Received: by mail-ua1-f47.google.com with SMTP id a4so11862305uae.6 for ; Tue, 24 Aug 2021 08:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=msURh4HPk6Cq1BimDbNhMMucXYT7U0Vcy0Sq2atJrx0=; b=YsGe+8tOqq4BXMRPgUsvJYXfkS0T8oZHZPNYzsniDc7GPvdhPNwO9HhWoimy2PwMn1 HSf/sJfU6IhOIEAL4BKfKDD9FuFvl1jd3AIHewEm7mS7oLwlTWc3fCdLE72+y2f/Vn77 pRdqisZkK5qf33K2TIilrIsPveqWNo/wtb/QoPr4IhH5YL80ZBqhzmoNWjv/8cIpjzwp kxMuyR3BHQnSytdnu2yfE/3GmJby1RsNsFTDtEJ8JGkoLEzI0hrStPwnEScaFEDpj8bb BDS/O5ZXo/2bq9Bp+b4FICjCzJ4tKIShvwbyLeugvMrXR/dkwshRG3tQdF9wgVhzUM0T E+6Q== X-Gm-Message-State: AOAM533OCvBm0FMKc4f1PeMEzcIDOR9SkDgxYUu1uNCv+zl3eW8s+tcQ OkhYDQsK42MSserQvuahEjx+MRKpyyosM2CRxtP2hbWOI9M= X-Google-Smtp-Source: ABdhPJwAUNvTcQx5kvQLdZtlnNgIdtvcUkBPTndf14lOrIcWLAHO225weCyrNKkIAJ0DtWEtZ71qlOnUdevBBlpY9MY= X-Received: by 2002:ab0:545:: with SMTP id 63mr26240042uax.122.1629819974316; Tue, 24 Aug 2021 08:46:14 -0700 (PDT) MIME-Version: 1.0 References: <20210804123015.807929-1-bmeng.cn@gmail.com> <20210804123015.807929-2-bmeng.cn@gmail.com> In-Reply-To: <20210804123015.807929-2-bmeng.cn@gmail.com> From: Geert Uytterhoeven Date: Tue, 24 Aug 2021 17:46:03 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node To: Bin Meng Cc: Palmer Dabbelt , Conor Dooley , Atish Patra , Linux Kernel Mailing List , linux-riscv , Bin Meng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, On Wed, Aug 4, 2021 at 2:30 PM Bin Meng wrote: > From: Bin Meng > > U-Boot expects this alias to be in place in order to fix up the mac > address of the ethernet node. > > Note on the Icicle Kit board, currently only emac1 is enabled so it > becomes the 'ethernet0'. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - move the aliases node to board dts Thanks for the update! > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > @@ -14,6 +14,10 @@ / { > model = "Microchip PolarFire-SoC Icicle Kit"; > compatible = "microchip,mpfs-icicle-kit"; > > + aliases { > + ethernet0 = &emac1; > + }; > + > chosen { > stdout-path = &serial0; > }; Reviewed-by: Geert Uytterhoeven BTW, is Ethernet working in Linux for you? IP-Config is always timing out for me. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds