From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, magnus.damm@gmail.com,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 2/7] clk: renesas: rzg2l-cpg: Move pointers at the beginning of struct
Date: Mon, 5 May 2025 17:53:11 +0200 [thread overview]
Message-ID: <CAMuHMdW0eKTfh6QsznWvCEeK5w9W-Zw4ORQ8yaevbYgh6+Ub3A@mail.gmail.com> (raw)
In-Reply-To: <20250410140628.4124896-3-claudiu.beznea.uj@bp.renesas.com>
Hi Claudiu,
On Thu, 10 Apr 2025 at 16:06, Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Move pointers at the beginning of structure definition to avoid padding,
> if any.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/clk/renesas/rzg2l-cpg.c
> +++ b/drivers/clk/renesas/rzg2l-cpg.c
> @@ -1183,20 +1183,20 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
> /**
> * struct mstp_clock - MSTP gating clock
> *
> + * @priv: CPG/MSTP private data
> + * @sibling: pointer to the other coupled clock
> * @hw: handle between common and hardware-specific interfaces
> * @off: register offset
> * @bit: ON/MON bit
> * @enabled: soft state of the clock, if it is coupled with another clock
> - * @priv: CPG/MSTP private data
> - * @sibling: pointer to the other coupled clock
> */
> struct mstp_clock {
> + struct rzg2l_cpg_priv *priv;
> + struct mstp_clock *sibling;
I would move them below hw (which contains only pointers), so
to_mod_clock() needs no calculations.
> struct clk_hw hw;
> u16 off;
> u8 bit;
> bool enabled;
> - struct rzg2l_cpg_priv *priv;
> - struct mstp_clock *sibling;
> };
>
> #define to_mod_clock(_hw) container_of(_hw, struct mstp_clock, hw)
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2025-05-05 15:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 14:06 [PATCH 0/7] clk: renesas: rzg2l-cpg: Drop PM domain abstraction for MSTOP Claudiu
2025-04-10 14:06 ` [PATCH 1/7] clk: renesas: rzg2l-cpg: Skip lookup of clock when searching for a sibling Claudiu
2025-05-05 15:52 ` Geert Uytterhoeven
2025-05-07 12:12 ` Claudiu Beznea
2025-05-08 13:55 ` Geert Uytterhoeven
2025-04-10 14:06 ` [PATCH 2/7] clk: renesas: rzg2l-cpg: Move pointers at the beginning of struct Claudiu
2025-05-05 15:53 ` Geert Uytterhoeven [this message]
2025-05-07 12:13 ` Claudiu Beznea
2025-04-10 14:06 ` [PATCH 3/7] clk: renesas: rzg2l-cpg: Add support for MSTOP in clock enable/disable API Claudiu
2025-05-07 15:42 ` Geert Uytterhoeven
2025-05-09 10:54 ` Claudiu Beznea
2025-05-09 12:34 ` Geert Uytterhoeven
2025-05-13 12:34 ` Claudiu Beznea
2025-05-13 14:07 ` Geert Uytterhoeven
2025-05-13 15:36 ` Claudiu Beznea
2025-05-07 15:47 ` Geert Uytterhoeven
2025-05-09 10:58 ` Claudiu Beznea
2025-05-09 12:12 ` Geert Uytterhoeven
2025-05-09 12:44 ` Claudiu Beznea
2025-04-10 14:06 ` [PATCH 4/7] clk: renesas: r9a08g045: Drop power domain instantiation Claudiu
2025-05-07 17:10 ` Geert Uytterhoeven
2025-05-09 11:03 ` Claudiu Beznea
2025-04-10 14:06 ` [PATCH 5/7] clk: renesas: rzg2l-cpg: Drop MSTOP based power domain support Claudiu
2025-05-07 17:15 ` Geert Uytterhoeven
2025-04-10 14:06 ` [PATCH 6/7] dt-bindings: clock: rzg2l-cpg: Drop power domain IDs Claudiu
2025-04-15 19:16 ` Rob Herring (Arm)
2025-05-07 17:17 ` Geert Uytterhoeven
2025-04-10 14:06 ` [PATCH 7/7] Revert "dt-bindings: clock: renesas,rzg2l-cpg: Update #power-domain-cells = <1> for RZ/G3S" Claudiu
2025-04-15 19:16 ` Rob Herring (Arm)
2025-05-07 17:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW0eKTfh6QsznWvCEeK5w9W-Zw4ORQ8yaevbYgh6+Ub3A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®