From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbdFZQRe (ORCPT ); Mon, 26 Jun 2017 12:17:34 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:32984 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdFZQRZ (ORCPT ); Mon, 26 Jun 2017 12:17:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1498489947-17272-1-git-send-email-madalin.bucur@nxp.com> From: Geert Uytterhoeven Date: Mon, 26 Jun 2017 18:17:22 +0200 X-Google-Sender-Auth: 69VTuemcoOEv5ECmkZaCfMA6asM Message-ID: Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA To: Fabio Estevam Cc: madalin.bucur@nxp.com, "netdev@vger.kernel.org" , "David S. Miller" , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam wrote: > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote: >> A previous commit inserted a dependency on DMA API that requires >> HAS_DMA to be added in Kconfig. > > It would be nice to specify the commit that caused this. That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops"). However, none of the fman code uses any DMA API calls, so IMHO the set_dma_ops() should be done somewhere else. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds