From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965535AbdKQIlN (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 03:41:13 -0500
Received: from mail-qt0-f180.google.com ([209.85.216.180]:41578 "EHLO
        mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965444AbdKQIlG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 03:41:06 -0500
X-Google-Smtp-Source: AGs4zMbg8yBOjMhlwBHlD4bT9DyDWc7F4cwqByaH61SmXiciobZrKtnvgfEdfKEB6P6ZLyT5+vZ7k1KEj/bnqCTlclU=
MIME-Version: 1.0
In-Reply-To: <87mv3lrcxg.wl%kuninori.morimoto.gx@renesas.com>
References: <87po8ig8eg.wl%kuninori.morimoto.gx@renesas.com>
 <87o9o2g8ab.wl%kuninori.morimoto.gx@renesas.com> <CAMuHMdX67os-V3Gi4kh+p02j+zXK4DsrJVticA==pp_dYdm1qA@mail.gmail.com>
 <87mv3lrcxg.wl%kuninori.morimoto.gx@renesas.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 17 Nov 2017 09:41:05 +0100
X-Google-Sender-Auth: 4XxsbQiSfodAZfEIBrspqpo3POo
Message-ID: <CAMuHMdWAJOOR4Gc-HP8OEr-PZ2DBhOAALHnkAeinGs39OwPP8Q@mail.gmail.com>
Subject: Re: [PATCH 1/2 v2] dmaengine: rcar-dmac: ensure CHCR DE bit is
 actually 0 after clear
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vinod.koul@intel.com>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        dmaengine@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Morimoto-san,

On Fri, Nov 17, 2017 at 1:10 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > +static void rcar_dmac_chcr_de_barrier(struct rcar_dmac_chan *chan)
>> > +{
>> > +       u32 chcr;
>> > +       int i;
>>
>> unsigned int
>>
>> > +
>> > +       /*
>> > +        * Ensure that the setting of the DE bit is actually 0 after
>> > +        * clearing it.
>> > +        */
>> > +       for (i = 0; i < 1024; i++) {
>> > +               chcr = rcar_dmac_chan_read(chan, RCAR_DMACHCR);
>> > +               if (!(chcr & RCAR_DMACHCR_DE))
>> > +                       return;
>> > +               udelay(1);
>> > +       }
>>
>> What's a typical number of loops needed before DE is really cleared?
>
> It case by case, but I don't want to use while(1) loop

I understand that, and I agree wholeheartedly with limiting the number
of cycles.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds