From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 257CD37B3F5 for ; Thu, 29 Jan 2026 08:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769673901; cv=none; b=M1FuJcJuM5gWlvYwMMQwbjHoKm40lbhrlKqgGQaS/9eSzVhDqJUGcXGyOyakYkATkfC0SmsX1eN/po7+OKTw5Kt2xOthHjFhvyGX41oywe7ayx0rKtyHsunZYLHay7UcC6dAJT396NLErJeBq5uIQXIF/X9qFAMinHuqKHjV6Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769673901; c=relaxed/simple; bh=91tVL5mKuNj73Dz7moYY7OGxZC1gqClrSFgk0jV0cNc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=gZpb9l6dgrSCXLeUOj70KFLXLU31kIUNHpwkDF55AJEc0BdxZMaiuUSEsjXO1eIcwT/pwaAMexRghMtw40cUO2qkhXvlpx/rWTZ78SpRnX0x533jeCtxcVEGsO0X24cAGnIuI8vYqlgzCFl85eJJSKz2yw2qp8Wt+T1jH2OZhLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-566360cab02so476033e0c.2 for ; Thu, 29 Jan 2026 00:04:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769673898; x=1770278698; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v0gR7dZCHphDKOV6AbU9UOkdND+zeoXCfVO1M2NTZUU=; b=KoWQ+CS3N8n2S4xcq3SBbEkuKK78kR3nd1T+0DsjfO2saa0RkSk/J93+ZLdWz/f3Tj jbpL5mB23HXCIA27NnoOi3CXQTdqXn9hnGjoI53q3TK20h9RYLpqIdp95LrRYfuUAb/B lXSBqhZ9oQ/uSdZdYFSHKd3jtqHi9OxwUZJ27ZBUtHGQaLIcdSpa7Tdre4UBb/RBWcHW MANRkSzbYKaWnBWHhczt25FLw+cIRJxiVVuE31CqSslh227SPzePK1cr2NtZxkLE/Rm5 lklOUFiSYM9I2OuKdAsV4Iv0ZfwIz0R/ikOFcnQOBqQum07JGDPd3EkqNBwj84H/l3K9 4Rhw== X-Forwarded-Encrypted: i=1; AJvYcCXk7DqXmPFtLC1srVUFAm8Li/uuB/21oUh3hFbaOmdGA9pikb1l7uOvSwNVJdBc8iwxg0c3lKY6eO5BK0w=@vger.kernel.org X-Gm-Message-State: AOJu0YwYxPaghFM5UxEarzZbIm1F3O+egJAKWQ0JyE5+Cqor5wT2QEWd xACkiXahMFLe+M8DBoFnOG94hhST/Ui9WGwJt7NRBEq1ITrP0WeJWqwfiwx90pQL X-Gm-Gg: AZuq6aJclrJ0Uw7KW81Yw6NByzDwLIrdFXC+k39jkWJXoedDPo/XQye6GjTOuz7zcuO k3bpApGrlNooKlV/Sm9fGYjju5G5Xk6XE3aWPWGbOVJVDR7o3qwUePkw7Rsuvtz+qwsQ5w4QC0r xFMBPEuFSjLzdZrxTL4YY5YG0HYJbRKJa0VTUObTreFD28m832mpeuqFqDpZ2j4H0mhUXs31iMI lVKvUCFbqR+8tTXM7OzLAd4yqSQOw9S9e3g6gv2dlMJSHDhcO0p8Qsq2mp5WKM7PXsiiIDweWUP 0WQRn0QpJuwedKSbA82gdH0x1YOnlhyLWWUJoXiIUut4nyoPPFz9Y7Dl7l7Em79M5GxOKVIYSFX mATWvkDwXhUXVPKTB8zHo3gqQxejxT+FE2qr/RjSEC6VVW8a1VxdQV8WnQqC92XinLudiJ4DwMN AeRKA/2fQD40UB31wsKHDd+OazMrn8zyq2L0fd2uAfrqGBjuACyiIDsW712qU= X-Received: by 2002:a05:6122:341c:b0:563:7a35:1d9f with SMTP id 71dfb90a1353d-566795aa4a9mr2476777e0c.15.1769673897751; Thu, 29 Jan 2026 00:04:57 -0800 (PST) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com. [209.85.217.51]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56685b42da2sm1065180e0c.8.2026.01.29.00.04.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 00:04:57 -0800 (PST) Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-5f53505f012so523493137.3 for ; Thu, 29 Jan 2026 00:04:57 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVIBMkODnJo1oL7QcJX6ganXHHSRiMcftUQ3rZW0sBn7UXRoYfZlvbXTgkrsxxXpzNsRomuhXJivz0yl18=@vger.kernel.org X-Received: by 2002:a05:6102:54a6:b0:5df:b7f3:5875 with SMTP id ada2fe7eead31-5f7236eb1d3mr2932320137.3.1769673897247; Thu, 29 Jan 2026 00:04:57 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260127201706.616374-1-cosmin-gabriel.tanislav.xa@renesas.com> <20260127201706.616374-2-cosmin-gabriel.tanislav.xa@renesas.com> <20260128-sequence-platypus-59ae3318318a@spud> <20260128-debatable-scribe-4e55c208b31a@spud> In-Reply-To: <20260128-debatable-scribe-4e55c208b31a@spud> From: Geert Uytterhoeven Date: Thu, 29 Jan 2026 09:04:45 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QjTTisPi414sjhCr82V_-8ygcgoSAfE-Ll893eiMx8FQNA9_dDyqKpLyMg Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: spi: renesas,rzv2h-rspi: allow multiple DMAs To: Conor Dooley Cc: Cosmin-Gabriel Tanislav , Fabrizio Castro , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , "magnus.damm" , "linux-spi@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Hi Conor, On Wed, 28 Jan 2026 at 21:09, Conor Dooley wrote: > On Wed, Jan 28, 2026 at 06:51:48PM +0000, Cosmin-Gabriel Tanislav wrote: > > > From: Conor Dooley > > > On Tue, Jan 27, 2026 at 10:17:04PM +0200, Cosmin Tanislav wrote: > > > > The Renesas RZ/T2H and RZ/N2H SoCs have multiple DMA controllers that > > > > can be used with the RSPI peripheral. The current bindings only allow a > > > > single pair of RX and TX DMAs. > > > > > > > > Allow multiple DMAs by only restricting the possible names of the DMA > > > > channels. > > > > > > > All '.*-names$' properties must conform to the string-array.yaml > > > > meta-schema, which requires both minItems and maxItems properties to be > > > > present before the items can be a schema. Otherwise, the items need to > > > > be an array. > > > > > > Why is this in the commit message? > > > > To provide a context for the maxItems that are needed below, even if > > there's not really a maximum. Which is why having a maxItems does not > > really make sense but it is expected by the meta-schema so we can > > constrain the names of the DMA channels. > > > > dtschema/meta-schemas/string-array.yaml: > > > > if: > > not: > > required: > > - minItems > > - maxItems > > then: > > properties: > > items: > > type: array > > Right. You can probably remove all that since I'm asking you to add > actual constraints to the property. > > > > > Declare a generous maxItems of 32, which should be enough for 16 DMA > > > > controllers, so that we don't have to update this value ever again, even > > > > if currently the maximum number of DMA controllers on a Renesas SoC is > > > > 5. > > > > > > Huh, No. The binding should constrain this to fit what the actual > > > devices do. The device is the SPI controller, or the SoC where the SPI controller is integrated? > > > > Should the binding for SPI be updated if a device ever comes up with > > 6 DMA controllers? It seems a bit unrelated to me. In this case, should > > we constrain the number of dmas and dma-names per SoC? Some may have 2 > > DMA controllers, while others may have 5. Please let me know your > > thoughts, taking into account that I only added maxItems to satisfy the > > meta-schema. > > Yes, I think you should constrain it to the correct number of providers > for each device. > Whether that's done or not, there's not all that much reason to set it > above whatever the current maximum is, since the binding will have to be > updated to add the compatible for whatever device exceeds the current max > and the limit can be increased then. The actual maximum number of dmas pairs does not depend on the SPI controller, but on the SoC integration. I think the (single) DMA request signal from the SPI controller is just wired to all DMACs present (on this SoC, IIRC there were some Renesas SoCs where some DMA clients are wired to only a single DMAC). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds