From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D82FF3BBFC8 for ; Mon, 17 Aug 2026 08:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786953924; cv=none; b=bt3yjHZEt1xdIyou17Sd53ZGYTbHeW02VT3v4FUpwqTFODwGat3E6XVSInSNi7seMRLNFw9zuNtTr1i3p18z7qIjrpaPIWV8cv4wMEhMG9QR/nokLJXjLW7wRChqCT89HPadS2PPz1ghDdiwfdxt5A5oT03hjs91nlOkr7bAZP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786953924; c=relaxed/simple; bh=v/k2TtSB3HokyL9NePM4/kz5x/n3VyE/d2D+6bkizss=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EoJ24KsGjPCMu04Ky9FmZS9hdXVnu14Ugpdx2HTkZd6f0OcM58MvRgyAv6j7a8UCCs4IfzSy8gqr2jsFnHMeNIypMUr1E8JvMTjQH8t1Fmt3YwnscTaCsvTU9eFlQMWjZmv2SNbw3oaJrEs2DOpfzQmHtE6S3FE+/Nz27+l9HeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-5c30d9adfa7so1017234e0c.3 for ; Mon, 17 Aug 2026 01:05:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786953921; x=1787558721; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=cfb6+conlmTSAk788D8dXigOPUOrnG+6BswdAqf7bj0=; b=iCR92RlYz7sTZoBYf7nZrorsC5O7h5gZIfMJ7gi6b+5xrwZn+BZfkArYny4TtCPMbn IAKwZ/PclPaNvDuMO/bG9jqh6F+Gi4bZLCFeXPBF7ya4su4E9FbLZGW2KWgEbk8hROMa aXoZpPi7VcUWNvNVlm8NDe/HwemRLcZexFgX6ImfSsfgfM6xNgkGbzEwM1YGwkCTGxnp AYom5jjJZ0FqtBn7kGA/DyZ9aWGhASfFzEPHghRbub/7hk00k8WHHLfrDWUtypiJvkwq Lrdx8C+ibf5ugODJLb0BoPLyLQG85Y6YoeiJxwm/frVVu6h0vPz96FzM+hwXHmf35TTI +3pw== X-Forwarded-Encrypted: i=1; AHgh+Rol7I2yRfRFoVJX7iCO0wykjRp7KzacIVr3O9ZiOOvjB8RMVNabHqrOuQOp4AssJbce6vvoPwExtCUUiik=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+NDMFxUSIaV5/4eb1ne87dTC2id31IjqqhfL7ke2uLaErMy/D jUXPadMJy9OOwSJxXQu0ESBFZ73bJ7gZZW9zOojxk2Ndi3CccMB9Mlq9yYNV9zTX X-Gm-Gg: AR+sD11lCKWvLNNoIEKGuEyJgpS0vA0LW6hyIujAcZUIRaNG4JobsT5O854MapDcRPi BzGHvzyEwl9vdeGFh4wQxRbt4JZ+F8MJu5aa0DK59C1QHysyOOJfGIxavAXUePIOvxRgEVy9BOy eaAuN16QAFo6CQEY+eCH5fTIJDZEL6M/ER/xan06ZP3Flv6NbsfvrAoo+vWor3h0hEq5WgdE58h eE+nEOhw54SYNhKRWU8NP/1/QpnZANdRJBUNhXn3QGG1iDCmvzjY/2Lr5EGJJdjCWSrc4Uhtd6F eHQ0tEVvzu18vuq83ve9Hi+H9brNP+Eaf/9BN06BI0udCxhTrle9wTLZSmk6mA90mUhpeluRhXY y5t9P0jbg9DEJmEcpORMW943UMSrve/qPmnqnvZLpcHW3XvkLVTDtbveAVsNeryp8bzPXVoxV0N vbic7xmAgZ0uiK2oSswLhr2tmwyqGW/NJoI+bcl3/PMUWmlbjnHeqACs1anORWjfO7ZESwD8kEV Vcl70WxUPFLH5t2K27v1BJSIl8ZKw== X-Received: by 2002:a05:6122:46a6:b0:5bb:aae2:1754 with SMTP id 71dfb90a1353d-5c591f2f2a4mr3760274e0c.13.1786953921544; Mon, 17 Aug 2026 01:05:21 -0700 (PDT) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com. [209.85.221.179]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-97c2c3c7e85sm612904241.8.2026.08.17.01.05.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 01:05:21 -0700 (PDT) Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-5bf9506704fso905145e0c.2 for ; Mon, 17 Aug 2026 01:05:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RqVyY//IK3FLWvo+NPEXQplmu3x+wjyWjghrNGJLwlH3eqdoz4k/YRny+hT9YDUUdTlSFuVOYHQd36dpKM=@vger.kernel.org X-Received: by 2002:a05:6122:3401:b0:5bf:4522:fca7 with SMTP id 71dfb90a1353d-5c591c966b6mr4776103e0c.4.1786953920834; Mon, 17 Aug 2026 01:05:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260812131144.30802-1-xiang@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 17 Aug 2026 10:05:09 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AcwNN1V6UK-V_sOiwm7iJStyXWPQcRpgb9Tb2YvHjOkj9xjMVA508SR69lribCU Message-ID: Subject: Re: [PATCH] erofs: fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms To: Gao Xiang Cc: Linus Torvalds , linux-erofs@lists.ozlabs.org, LKML , SJ Park , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Hi Gao, On Mon, 17 Aug 2026 at 09:49, Gao Xiang wrote: > On Mon, Aug 17, 2026 at 09:32:51AM +0200, Geert Uytterhoeven wrote: > > Thanks for your patch, which is now commit a64d500b0078e16e ("erofs: fix > > EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms") in v7.2. > > > > > --- a/fs/erofs/Kconfig > > > +++ b/fs/erofs/Kconfig > > > @@ -134,7 +134,8 @@ config EROFS_FS_ZIP_LZMA > > > config EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS > > > int "EROFS LZMA default maximum decompression streams" > > > depends on EROFS_FS_ZIP_LZMA > > > - range 1 NR_CPUS > > > + range 1 NR_CPUS if SMP > > > + range 1 1 if !SMP > > > default 16 > > > > I have just discovered another oddity: when you have less than 16 > > CPUS (including SMP=n), this default value is invalid, and "make > > savedefconfig" will always write a line like > > > > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1 > > > > to the defconfig file, even if that is the default suggested value. > > > > Needlessly polluting the defconfig files could be fixed using: > > > > - default 16 > > + default 16 if SMP && NR_CPUS >= 16 > > + default NR_CPUS if SMP > > I guess `default NR_CPUS if SMP && NR_CPUS < 16` would be better, > I'm not sure since I'm not handy in Kconfig stuffs. Kconfig always picks the first matching default value, so you don't have to exclude the "SMP && NR_CPUS >= 16" case here. > > + default 1 if !SMP If all architectures would always define NR_CPUS, one could replace the last two lines by default NR_CPUS > > > > Thoughts? > > In principle, that would be better, but may I ask if there is some > severe consequences out of one extra line of > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1? > > Since it has been fixed for many times, I hope if it could be improved > later if no severe impacts, sigh.. It causes more churn (defconfig updates), and makes the defconfig files larger than needed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds