From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6212C001DF for ; Mon, 24 Jul 2023 08:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231875AbjGXIuq convert rfc822-to-8bit (ORCPT ); Mon, 24 Jul 2023 04:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbjGXIun (ORCPT ); Mon, 24 Jul 2023 04:50:43 -0400 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6099DAF for ; Mon, 24 Jul 2023 01:50:41 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-cea0021d1f3so7621316276.0 for ; Mon, 24 Jul 2023 01:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690188640; x=1690793440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eru5igGG5ZNMFyi9+7h599RckQE/U9fJOptjtiH/IWA=; b=EkCXiHqj4/VKRKeeEjEgSdMD7crdlGXhlb/YwHHz3kh3FveUMOPJLtE7ARMKjdfv3O GM7kkQxe+cP8i1jcQc2CB2kWEFM77tJKxFWFC4YJ7AQKywUyAGI+m1ARMYxYnthA1Uku Wm7vWtdcMgUJbURRTCmkQXGP40iHVK13PziRKh25oGpSNY+vzhf1PYh41uJ7WbWXKMRp 8Ij3+64D1FbIw9OAmPna/sUU6Hri0QaPMYa72Uz4sWTK357Bsyd9eWyeiy+nyy1q5Z+U rcoSS1oYng7zrar0w5EKnIFuW+WEvlRodSyiatOv2E+1qo/8VM6zkgmINaXsTlIMMtMN 2E1A== X-Gm-Message-State: ABy/qLZFin7kl0JEw6hcGilHSMznASVZ6Niq3sXCETxN/2Ci/DrrEXrC VikmMaQkviQIAaergmUTPIDy6msL3UgI7Q== X-Google-Smtp-Source: APBJJlEREVRu4bG1oZY61fBWxCKpEbkRgO99aB8zn2iuIYvOQCKf4XHqM+w6X+4hBmMGlJwsRd45ZQ== X-Received: by 2002:a0d:d6c2:0:b0:577:2aa4:70aa with SMTP id y185-20020a0dd6c2000000b005772aa470aamr4893389ywd.21.1690188640269; Mon, 24 Jul 2023 01:50:40 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id z4-20020a81c204000000b005772fc5912dsm2647506ywc.91.2023.07.24.01.50.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 01:50:39 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-d13e0bfbbcfso330284276.0 for ; Mon, 24 Jul 2023 01:50:39 -0700 (PDT) X-Received: by 2002:a25:f54:0:b0:cef:9a1b:8380 with SMTP id 81-20020a250f54000000b00cef9a1b8380mr6389620ybp.24.1690188639473; Mon, 24 Jul 2023 01:50:39 -0700 (PDT) MIME-Version: 1.0 References: <20230721075949.5632-1-xujianghui@cdjrlc.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 24 Jul 2023 10:50:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: To: sunran001@208suo.com Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ran, On Fri, Jul 21, 2023 at 10:04 AM wrote: > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun Thanks for your patch! But obviously you forgot to run scripts/checkpatch.pl on your own patch: WARNING: A patch subject line should describe the change not the tool that found it #2: Subject: [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: WARNING: From:/Signed-off-by: email name mismatch: 'From: sunran001@208suo.com' != 'Signed-off-by: Ran Sun ' Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds