From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C2283FE649 for ; Thu, 9 Jul 2026 10:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592673; cv=none; b=ZCtUQAZ5hAif27I3py7sxRxEv8WQbtP05cmc9+HANJ4dsN0voFjQenO57x7s1LfFNv0DclMvexTOPIsMZ5XTd/2U+SFXnA/qBdyChgJ6/ykl8wy+uZ8GxwiOiEbhiPQhF51zyc3ggzidtREgZhy52agPnfg8CVNj6eKVLxuq5jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592673; c=relaxed/simple; bh=FxUfzWpCleIQzfr8y72a6t+Wi81Fv5S94Ccqz6vyAuY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=HENu1phW80AChTYpU87sB0cKjNw6NnBSkrSLgCVFv58ZqacH6briB3YwO+MG9UfVKcaSbr7xFmBxQQGRcDYxegCQF/jtMrA4T9P3Mo7ZXlX7RKVKdvC++haVT3k4QabkEqx1vjjx4GQGlQ5lE9Z+uCEFVlyvKkE6JxqRTRxltTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-9691ba8bc8aso857723241.1 for ; Thu, 09 Jul 2026 03:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783592671; x=1784197471; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=s6cZ9HNvj5euq2IsKqnGtW9n38TCf44UpefkQ/0EfN8=; b=Kc3mRfYrPG3a/YEoxgr5F9EcwnKiH9leJ208y4bg53gni1di9wKV0GCD4Uj89XlJCa 8gClv2b3Y1/60rzCakCxkag/YKr4Iol45Ip8QqnMqCK07nGAiVWyIXWplv+laIvKJV29 V/Jrfn6EAmtTQb+tRo5mJ0KJvBRhn6f9LLtV/LI/sXaiMBQceuol+SMH+nko8BfQsVXT Q6lYLgU4N9ibxbyjaRYUg91iU4dJ+dg8VKsZdX3i218sZhvnml8/MDmeryK08Z97wt3p MN3JSyQ7inlVMSkK8R0neHFD7Coi6LYjvIEqSKjJzlv+TWIGaXd76Tx5+p6oCnvIx6UJ L/pQ== X-Forwarded-Encrypted: i=1; AHgh+RoVwpy3bAcgqqNQZpuROMAhGm3BNy9HiPJGZjWHKiPyABUt5n7R6dZeyWQEXGEPaZjDlufx8LaIs/7gqNA=@vger.kernel.org X-Gm-Message-State: AOJu0YxPsAAxRm3U/eqAWxDO/gvX/nlrBBNVh1nQo+iEqoTEjAAol9BW gXYDnjzFZ5GrJ8i3TZWL6ycz0PjzuGVx5YvJtLuYTLnEWEA4YN9yeMD//YjF/lYTjhQ= X-Gm-Gg: AfdE7ck73xrxlqqSUpeDsfdY7acEAKOpd5kPDkUyiQWJEE8HxvCNEaUQnEW1umiQsSl 2CnnFJwixgzAW4ppiJgKPCLjCFutwg1fgAdiu7inid+S7PDbFrQo4hijxbYvEDcihQ1uQsEKuGG aiDqovyZ86crmaijKC8CeLPrx6yfH6XUZho7QNYuFwswXbfAqPZuiJvFpaExKP6kQcwsa9BaozI hh+MLE0y8wsXZKCSU2LgEOwOLowdJAjJ5HfBcL69c4+SCovW4aeHKF6/gQdpz2jxE2MP0DvZ9PY //XKgSktxGPFVh5pGPPxKaD6vU8gt5IFp3nApCzcJLH3hSR6NEzkHAHugxy4sjlbQhCILNocKvE cll4ZfZ256rfuvTGtnVbBtElrLVfnkLUOhLgp6G/aF1goh7HHlJudvYNVrBwJWec/xoblOxOW3g hLVVMJOSQ5gMKX7nsQuP+ya8YHg579WxLrkefXz8qZK3BUt9xJ+A== X-Received: by 2002:a05:6102:4428:b0:740:2717:a1b2 with SMTP id ada2fe7eead31-744e000f855mr4258189137.1.1783592671203; Thu, 09 Jul 2026 03:24:31 -0700 (PDT) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com. [209.85.217.54]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-744d6a3e6a1sm3218516137.1.2026.07.09.03.24.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 03:24:30 -0700 (PDT) Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-7396940aebcso1225728137.0 for ; Thu, 09 Jul 2026 03:24:30 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RpdOKIuULqPnTtqdnmX1nUxA0vOnqmy2XTKw/87fvZXs8Bcsuahr8oy+jcHuvXHl2JJTrFbauYveBrGtPA=@vger.kernel.org X-Received: by 2002:a05:6102:94f:b0:738:531e:a43e with SMTP id ada2fe7eead31-744e00634cbmr4111626137.7.1783592670751; Thu, 09 Jul 2026 03:24:30 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <59725f93-5269-4b0e-8633-48821219877f@mailbox.org> In-Reply-To: <59725f93-5269-4b0e-8633-48821219877f@mailbox.org> From: Geert Uytterhoeven Date: Thu, 9 Jul 2026 12:24:18 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mzHlNNTYZ42llQz3ksPLOjU-3fWPe_bQZCByAo9mLJpSl17fS0OhOffgPc Message-ID: Subject: Re: [PATCH v2 6/6] arm64: dts: renesas: r8a78000: Add MDLC nodes To: Marek Vasut Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Brian Masney , Ulf Hansson , Philipp Zabel , Wolfram Sang , Marek Vasut , Kuninori Morimoto , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Marek, On Wed, 8 Jul 2026 at 23:56, Marek Vasut wrote: > On 7/8/26 12:15 PM, Geert Uytterhoeven wrote: > > Add device nodes for the Module Control (MDLC) blocks on the R-Car X5H > > (R8A78000) SoC. > > > > Complete hardware desciption of all (H)SCIF serial ports, by linking > > them to an MDLC for power domains and resets. > > > > Signed-off-by: Geert Uytterhoeven > > [...] > > > + mdlc_ddr7: system-controller@e8380000 { > > + compatible = "renesas,r8a78000-mdlc"; > > + reg = <0 0xe8380000 0 0x1000>; > > + #power-domain-cells = <2>; > > + #reset-cells = <1>; > > + bootph-all; > > + }; > > + > > + mdlc_hscn: system-controller@c9c90000 { > > + compatible = "renesas,r8a78000-mdlc"; > > + reg = <0 0xc9c90000 0 0x1000>; > > + #power-domain-cells = <2>; > > + #reset-cells = <1>; > > + bootph-all; > > + }; > > + > > + mdlc_rt: system-controller@19440000 { > > Please keep the list sorted (0x19440000 should be before 0xc9c90000). These are sorted by instance (Module Number), as per Table 18.1 ("Target Module hierarchy of Module Power Gating and Module Standby") in the documentation. This order is indeed a bit odd, as it differs from both alphabetical label order (unlike e.g. hscifN), and numerical unit address order... Any guidance? > > + compatible = "renesas,r8a78000-mdlc"; > > + reg = <0 0x19440000 0 0x1000>; > > + #power-domain-cells = <2>; > > + #reset-cells = <1>; > > + bootph-all; > > + }; > With that fixed: > > Reviewed-by: Marek Vasut Thanks! ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds