From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ACEC433FE for ; Tue, 25 Jan 2022 20:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231146AbiAYUNS (ORCPT ); Tue, 25 Jan 2022 15:13:18 -0500 Received: from mail-vk1-f169.google.com ([209.85.221.169]:37451 "EHLO mail-vk1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231854AbiAYUMn (ORCPT ); Tue, 25 Jan 2022 15:12:43 -0500 Received: by mail-vk1-f169.google.com with SMTP id v192so13108075vkv.4; Tue, 25 Jan 2022 12:12:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1cqbsPNZ64vIJQYyE3XbIMBM01AmRJigHSuPYUkGB7E=; b=2cTOSUtH0nuvQ35Lea6dJqBpOCAQJlyDCB3FnF5O3fSv765Lj7/eO6B+AQHZFGhDYU ATZd3z+YqHRMp4cr9s4MfL/SK8UtkjjGUuq2XY3FQvDpVgp2QMOQn7/AOFHPMJcaCA+F lt/ntFeHtb+Byd5CCtFeGCVgAMP77SlTby95tC5hfjb35keDuo2xyJW4ColYQuLnPeI2 2K0IkyPEzCEe/cjeoLQiQZtGZ1D2piKPn5QyIYiJjSwFemc9R5VFly/afzFa4wplazB0 67H8nePS5w9UnfRUIMMfeld40qa6tZicH7xxQa1sW31KD70sHiLS8PIN1cbK7KNgWhaS S7bQ== X-Gm-Message-State: AOAM532Vu41EQQtb2nmmXvXMHXdlU2o2rHZtejbe0Sw4SAd0XY5qpN2p 2jausvD85xu7BuRFotCuF3NzvsjR97KQaHm0 X-Google-Smtp-Source: ABdhPJyGI8hnAKqtNw2OqJoN4MwPWLXeZD5TNXRUsGPzwsTHt6NROtt+tkC0XVbJIKIAoLNX6c5K8w== X-Received: by 2002:a05:6122:588:: with SMTP id i8mr2124559vko.41.1643141562489; Tue, 25 Jan 2022 12:12:42 -0800 (PST) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id d202sm1125006vkd.38.2022.01.25.12.12.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 12:12:42 -0800 (PST) Received: by mail-ua1-f43.google.com with SMTP id r15so39566043uao.3; Tue, 25 Jan 2022 12:12:41 -0800 (PST) X-Received: by 2002:a67:a401:: with SMTP id n1mr4458394vse.38.1643141561680; Tue, 25 Jan 2022 12:12:41 -0800 (PST) MIME-Version: 1.0 References: <20220120090918.2646626-1-atishp@rivosinc.com> <20220120090918.2646626-7-atishp@rivosinc.com> In-Reply-To: <20220120090918.2646626-7-atishp@rivosinc.com> From: Geert Uytterhoeven Date: Tue, 25 Jan 2022 21:12:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 6/6] RISC-V: Do not use cpumask data structure for hartid bitmap To: Atish Patra Cc: Linux Kernel Mailing List , Anup Patel , Albert Ou , Atish Patra , Damien Le Moal , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jisheng Zhang , Krzysztof Kozlowski , linux-riscv , Palmer Dabbelt , Paul Walmsley , Rob Herring , Emil Renner Berthing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Atish, On Thu, Jan 20, 2022 at 10:12 AM Atish Patra wrote: > Currently, SBI APIs accept a hartmask that is generated from struct > cpumask. Cpumask data structure can hold upto NR_CPUs value. Thus, it > is not the correct data structure for hartids as it can be higher > than NR_CPUs for platforms with sparse or discontguous hartids. > > Remove all association between hartid mask and struct cpumask. > > Reviewed-by: Anup Patel (For Linux RISC-V changes) > Acked-by: Anup Patel (For KVM RISC-V changes) > Signed-off-by: Atish Patra Thanks for your patch, which is now commit 26fb751ca37846c9 ("RISC-V: Do not use cpumask data structure for hartid bitmap") in v5.17-rc1. I am having an issue with random userspace SEGVs on Starlight Beta (which needs out-of-tree patches). It doesn't always manifest itself immediately, so it took a while to bisect, but I suspect the above commit to be the culprit. So far the Icicle looks unaffected. Do you have a clue? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds