From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932679AbaJVTuK (ORCPT ); Wed, 22 Oct 2014 15:50:10 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:47026 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbaJVTuI convert rfc822-to-8bit (ORCPT ); Wed, 22 Oct 2014 15:50:08 -0400 MIME-Version: 1.0 In-Reply-To: <20141022.153436.93475594748933547.davem@davemloft.net> References: <1413963581-24019-1-git-send-email-geert@linux-m68k.org> <20141022.153436.93475594748933547.davem@davemloft.net> Date: Wed, 22 Oct 2014 21:50:06 +0200 X-Google-Sender-Auth: 81h3uU-vKYOsxo2QubPAak3IXnc Message-ID: Subject: Re: [PATCH v2] drivers: net: xgene: Rewrite loop in xgene_enet_ecc_init() From: Geert Uytterhoeven To: David Miller Cc: isubramanian@apm.com, kchudgar@apm.com, "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 22, 2014 at 9:34 PM, David Miller wrote: > From: Geert Uytterhoeven > Date: Wed, 22 Oct 2014 09:39:41 +0200 > >> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ‘xgene_enet_ecc_init’: >> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ‘data’ may be used uninitialized in this function >> >> Depending on the arbitrary value on the stack, the loop may terminate >> too early, and cause a bogus -ENODEV failure. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> v2: Rewrite the loop instead of pre-initializing data. > > I hate to be a pest, but like the other patch of your's I think > a do { } while() works best here because the intent is clearly > to run the loop at least once, right? I wanted to avoid checking for "data != ~0U" twice: once to abort the loop, and once to check if a timeout happened. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds