From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416E626FA6F for ; Mon, 25 May 2026 03:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.210.43 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779679570; cv=pass; b=HuwHs8KVBOPTV2Dy1JIFpnzKduR+r+sVM5k4evbiVJVwYVLM44z4i5lHu6ObMS/FJyISS8GQRwHoANY+5Dave80Wg/trSRTjYrslszZIqHAe81YdFkQLElGOZt+lZhH9pIxklIs/nxGWF8I8BGeTGVo5JlYS09ZtGOmb557Pjsw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779679570; c=relaxed/simple; bh=Tcjwar0ujMRUYwQNWOI9owhqHhcwp71+Xytox09KV28=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bR8Ospak95/GuD9LM/TOtDxAFqAFM6G6RWIHSo5BuIKx3PhcNzHFSZPJ690mLWZiWMYVyhmDOERMW8BcXxB5PzTmxRp7kFKpfsR3g3KiSZtVUr0cv100S82FkXBOnb48k/GcxFuUrUKMKOQMk0ykp3IqprzbZKhrYCDfxg5rOYo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kbeA1sXy; arc=pass smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kbeA1sXy" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7de4a9cb8eeso8593486a34.0 for ; Sun, 24 May 2026 20:26:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779679568; cv=none; d=google.com; s=arc-20240605; b=Edw3lUg5Er0DKarEZlps+XbjgpErzcYxTQjLM7P+tzQvr98yJpf8j6f3DuTvkNlKpq eN2SyR1jav8fdL/ZMWbmADvrJ9JtySkoGC7ALbUMRCgbgQlBENWCaCwC5hY6Xu0T2AZr Y8z2iW/wdRMnEZdi6DMBeVYg5byhnz0kQJgSLFcIHqLmCo9kO3+jMGF0hUR8YPaqP8gl KnVpU7+jZqI7gly8dNdd8FTQiMlg46tCDigHy1Z1RXBV4S1YxR8C8pb7YxfpCceQiNTk Tt4pUm4lcxduiSEzbiPFtv5eJa4sbboxCtSgXphQT6m0AFzy00UgIflyAVbcfPb9bYDf xOHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zvwfuFavRTickP2JgkskpCqaYMIYAPH+/fczcSyou0Q=; fh=RWPtvGiumC9vfdUajpr2tcxIPMptG59sn1IZ+on5xo0=; b=EphTyQx7uTOGcYeBBuoqsSL0MXswxnQHMp5PQZiynmQGVYIDBFTWhjA5J5PgzVHtce usDz0J+MVvwMfbMcQGimwtUh3/kBuaYRKzRvcy8ir7/PS29TCNEQDvpXqYUCDdANdEDZ SH4JvDb+mZLmIN+ETqATNzF16bgFdjux5OgmJelLnnxkDI24wst5FOEH+cyVma3N9TL4 Jt13aCYFmf1xOrJ0a2Z3fA2aqpfzjDqZr2DJmQrAffdf8rfN2fRhki+VZPmjUJRbWlTX nakorNidJtMin9FAKHhqKBuev8G2ZwYya5hVStF0Ht9NMPD8gV9a3h0t9oiY7rvc3KIZ 6eIw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779679568; x=1780284368; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zvwfuFavRTickP2JgkskpCqaYMIYAPH+/fczcSyou0Q=; b=kbeA1sXyQ5dkCWIfThfUgDAV+VXEMzIwiJhITeu3Q5BKcl1WaLV3DiJle6Zy9Xths+ 9HV7WalsRq3dV+roFjjMnTfGR01XVIQKOcaCLTxLPVfalBj7KJleOnFQphUzP1+tUcvH Wpa8Om0fbN4/pGNrhqV+DrvBk7yed8I2yj6JxH93WDR85XhfJ8OpuL216En5Zeb7OZ1E PjCBEQqvifDsoYaeugkXGoFGZN/BGOF4wPK7uuZfpYtOIWmsYBtrzPOM0uEp+Gp16FgF zj8pVi5yjxr7YOLBNBQpFM/lb9/4q+S6V381KXbTYAras0cWpVAQ9NBhrDso5C/qijU2 4QaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779679568; x=1780284368; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zvwfuFavRTickP2JgkskpCqaYMIYAPH+/fczcSyou0Q=; b=QiKYwRqE+Gikg7szptyLN7ZKbvCc1Vpjk8g5xB/5FyTXRmn/XA72KvHRSawqyd4Tce 9LPR8HwNyClbslgFCTCmeXYNuqH5FX0TeaOsH3yNq1ceSl94pLpNBxxV9Koko99sI3pf UQYhKmXmxnQb0hw4VXI9Qfwt2m8Me8hbaTEuPM3elj12LWMvXtf+Auj5XR92qCl3BOG1 OFANS9R1A0xrWOi6N2SNkLugmHkpaZlvqlGKJAbBaK4DGw+/Rpk2wEYvcbBPsX49bu18 mj4XbohsyaMgD0am1gxysVs8YypgEKoap7yfzBJrXQIYtlEUR/jE/lMEhUM7Z4B6NqZe CaIg== X-Forwarded-Encrypted: i=1; AFNElJ8dtf3ljuDb4XIQ5RhjuEEq+aZj2UTIUnQ405CamroKBS2IQD5TtOUVrYUskmXYVcqLlhL+qCiZq1D1tXY=@vger.kernel.org X-Gm-Message-State: AOJu0YyVOEqaMTX0JWcSoTvJxe23H0l+dQI/BgMkaDWdnbYQGLCyDEHj i0TYKbuUOaFUUVDI8H7nHcziwCYT+iE+3v/MzsQe7gjrmHXQX7OQyAQpkrGyBd+9EqjXutZ2oyp 6DAwy7hEPifRs+YspsZH3sZNTjcCZ9Ow= X-Gm-Gg: Acq92OHwSFcRc4QGojI7RkpXrji5hmnZzsdnRtDHKtuSOHtHZwaj31FpVAO5VBAiWom H6fAwCw9BKI/mQi7Vcs94js+t09RKMAsUKxxjYGocJ/YRTEmi5D2Ck1MMaazB5NgLvAPk2r9WDq NR50AUKZdAOmmSzk5sWtO70GVVRhZbE0kqUIMcR/CqrAaKbpYhE7/z0gEZAXoF6CxGdVBLQFv2h i0an/VmtTcb/Y14dpa96pugTdJvSTI+1Wuv7bzqGWjjfowelxd08jJDab+iK3b4wl5L8UmctaPw hm0N9FT4mMcia8nfULiNdIWxV7yccoUADz9eNcQM6Zwf76BDvwMhj83wmy9kIY9Y3yOg X-Received: by 2002:a05:6820:4b09:b0:67e:2ff7:2a6e with SMTP id 006d021491bc7-69d7eb501dbmr7243815eaf.18.1779679568125; Sun, 24 May 2026 20:26:08 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260518102451.417971-1-paulk@sys-base.io> <20260518102451.417971-14-paulk@sys-base.io> In-Reply-To: <20260518102451.417971-14-paulk@sys-base.io> From: arash golgol Date: Mon, 25 May 2026 06:55:48 +0330 X-Gm-Features: AVHnY4KUuBcGh4fPuvaF9wKJBQKBE4TDK2MAAseg_T5QDDf0jB-H1zPi4i_Lwlk Message-ID: Subject: Re: [PATCH 13/16] media: sun6i-isp: Add dummy params link_validate implementation To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Laurent Pinchart , Nicolas Dufresne Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Paul, On Mon, May 18, 2026 at 2:01=E2=80=AFPM Paul Kocialkowski wrote: > > There isn't anything configurable about the params video device link, > but the v4l2 core complains that no op is provided so implement a dummy > one to make it happy. > > Signed-off-by: Paul Kocialkowski > --- > .../media/sunxi/sun6i-isp/sun6i_isp_params.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c b/d= rivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c > index 77c2d06c0436..b7ef33fa2b13 100644 > --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c > +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c > @@ -450,6 +450,18 @@ static const struct v4l2_file_operations sun6i_isp_p= arams_fops =3D { > .poll =3D vb2_fop_poll, > }; > > +/* Media Entity */ > + > +static int sun6i_isp_params_link_validate(struct media_link *link) > +{ > + /* Nothing to validate here. */ > + return 0; > +} > + > +static const struct media_entity_operations sun6i_isp_params_entity_ops = =3D { > + .link_validate =3D sun6i_isp_params_link_validate, > +}; > + > /* Params */ > > int sun6i_isp_params_setup(struct sun6i_isp_device *isp_dev) > @@ -470,6 +482,10 @@ int sun6i_isp_params_setup(struct sun6i_isp_device *= isp_dev) > INIT_LIST_HEAD(&state->queue); > spin_lock_init(&state->lock); > > + /* Media Entity */ > + > + video_dev->entity.ops =3D &sun6i_isp_params_entity_ops; > + > /* Media Pads */ > > pad->flags =3D MEDIA_PAD_FL_SOURCE | MEDIA_PAD_FL_MUST_CONNECT; > -- > 2.54.0 > Tested on a LicheePi Zero Dock (V3s) with the following pipeline: ov5647 -> sun6i-mipi-csi2 -> sun6i-csi-bridge -> sun6i-isp-proc -> sun6i-isp-capture I verified that streaming through the ISP pipeline works correctly after this change and that the previous .link_validate() warning for 'sun6i-isp-params' device is no longer triggered. Tested-by: Arash Golgol --=20 Regards, Arash Golgol