From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB39E2459E1 for ; Sat, 11 Jul 2026 02:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.222.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783737822; cv=pass; b=hj+pQY35MSJytW1E11VuNVAzmEDoWUcmHUO1L7gv5p2r1DUyPMGs3uMhzxdhmWcEszCzLIBL7mZ4wfN33DenufqH6XBrBJ77YpvIWVpYXQxR9L73fR4Ge1mdLXMamk2mQwgBou0t3AzBVKHQ/uNmMvcXZtX6JDxODjcI03uGk34= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783737822; c=relaxed/simple; bh=cm0y3nfEv5KYZMQ9lE3vuSEaIaX/bYl6zqZ1nzt+X/o=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=OezsMIzwufoYIiDE9fLQ5RaaWlwsQeolxZ+hMJT0rw1Mj1vUcE4VrGM4aeV6Ko82AGKQGKJSNmoTnberzyKR+hW8CUPM8CWJkid/cLo5GxrKnL8aVzysMcHLTv5nwtE4ZULB2SoA3KGHyvWrrwKgYn+7iWOCwjd5U5LTiDSHxto= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p4uL/GEA; arc=pass smtp.client-ip=209.85.222.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p4uL/GEA" Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-9725084c547so637384241.1 for ; Fri, 10 Jul 2026 19:43:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783737818; cv=none; d=google.com; s=arc-20260327; b=EImJONI16SDKl8UUKmvwvZBwtV2k5xBIYkVh6fUIDo0JcRH76Z3Xl5rP2KVZpeyOlR z7KMfw7DH0vWsH8BIFVdO8pdq+b9Tng/bjImEGyLeZ2YFtv4sx19OjjlE9reHixCu8Us WZi+HiAjsxyWyOVAXTw5xqKLVfRGxkSg2feIImSkFHgJu8s6zeCLPhTTegYyexDeWDhb nGlcrC1LMF6cywe4JlyZICJQE/yiKdacS3mTtMP+TSn6SvDzqZTsZ8dDRG334iwNOEKN Iy2lFnkrI+OwyYnUzX2JR/PB6NwnjOfaKRJgGz07mBRfb5132YWrIumKm3xn3oy4S4LH 2tJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=WZiBVoIHxmqoz1H+3Q12ZE9AXVZ5TYhLyqj1A3OwnYM=; fh=CpUuo3rP1y4t3fAg9AXn0aUGY0ri9RoaTVJAYMSofzQ=; b=hV9kzuAfDe4Jk0LhaQKhZak08Aed6OvxqaU+2iJxJWWIiOVI+hTb7P7k+J5MTp3sKZ RVTGq+O/juMQBWSPYCM9EsQdOhcylkwGLo6OeQWwZ35kjk8iVpruGBWyyMS94cFGR3/6 1yk9/144a0Lod/9P31ARGVJzTVRdLfyJSaysW5osIZTUzYYqbVAp3Lutw8lza9tPCCGo nvOZA1GpbdlQztgYl+fpONffoAVd7aanL2ahx5FpEKxtqignrEFKSdO4s9sti0+0AvV2 6GbpYEVRU5LW96HpIoNHrtNMPWwpdw5SMFGmb994GR35qjr2huYH7Zb0gLOsXNyUM1Yi hJpQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783737818; x=1784342618; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:mime-version:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WZiBVoIHxmqoz1H+3Q12ZE9AXVZ5TYhLyqj1A3OwnYM=; b=p4uL/GEAJis80JMop3JN7/BtxocA27vCqhFhxXkAUoWPyZD45boNZlVLOo3mHEFCZG 3Q7rVUvy6s9mc3Xkib9/x9AgAQlOGgfug0NSLdo2duD+/902pVbSjlh/oq6wPCp5IAcH ffzrSM8LI9PP3cRo4z4cq9uK1M0UyNmvDQ8YnvqJoIzo3+bXS4JRapP4OlcAuI98VOVs UW7DlQxJxCKuhBj5482riobsRkXsVs23/iDgfIWir9FH3L+pPFi5pX6PLcgXVzaAJcNx 1gA9cwXtsw7To9Q6WvBOfl1nioNg7tghR7eH2GtI2GWzdZ7ap9oV8Lwim91Z2ynSzM3B SEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783737818; x=1784342618; h=content-type:cc:to:subject:message-id:date:from:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WZiBVoIHxmqoz1H+3Q12ZE9AXVZ5TYhLyqj1A3OwnYM=; b=b41+Ir0EOxljd3a4hi8fKuEXoeSbKlO9sb7vjOtOU/fUksMV6nZSkT5wULbERcRcrD PCU5tx3g4J5QlnF9H8FC9bHiOtEZMS39SNMDzyvGLPMz1CPd1WlVAYAcTqz+sIrPVRDq hAquFxJryiHQhU0dYhGZRPRKkgeEHJIcPAkyQS5UWF87PrPjYwZid9ftGbxEJh8t1mQj yhsm5aYg2J4VK8lAGZ9CjZ9o5o6ahktS1Dn1A56rfLLYZMIpc0Nk5sB2O8CBfOSRW5Uo 8eXqKx0/aaj2z2MC2Yd8AJoPcXu5ND/FGwa7avTRYEsAaJwnmWJFQAzZghoQrASVyMFq N8kw== X-Forwarded-Encrypted: i=1; AHgh+RrSyxcKsMwqt/AT6IhmnrrDNxBUkqm4lW58XUqw+1xiwecAtALP/tc6MwC/jUX8CFUw2Na3EyKY6Yz2F84=@vger.kernel.org X-Gm-Message-State: AOJu0YzAv/7GP3KI9lOECmA+j0S81hhpzB/tM4rZy2+IMibzCOLYJIiG CgLpde/Bj+dbOay508etmUQXCOX2oTppR0gllgeIQKV59L4ssndzJLFXdjqdJk3XwLtuNFQx30K ka+kTFc/t1k80CLoOdRicV5nbKg2P+Ew= X-Gm-Gg: AfdE7cmdsoLTvEnGQ0L3zOQN/l+fEy4eqVyLXi/4NTt8yQm1R+tUxUJAwDKnaXXigkZ uaAM3/R/cA6J4CnnXreiZ0A4QD49w+ruJL0EuNJEemld6s/2UrxvvHz2y9d+HHTdYu6Qae1rApR kbhePeVXQvEwWR1a5DM/kxMW6jFiOBwEq3D2Wi2BvO8VmBNHn0RpNe4qZvdeJjg/thA/AQl0dVO jtG8eYH0l/WY93dQECaosnwrn5eKH1StW+Xm3ihIEB/CbrtnKEFqVAtvCg22VRRV4/7vaLTb8Et 3f2IVwip6zAnXQU9yumHTpzAaFNZMAmSfDEKio4MBCm3UMz1svPdIdBiusbLcmjCMVLWnMUJxrw oveMvoGv1o0e+ X-Received: by 2002:a67:f7d1:0:b0:744:d1a6:b11d with SMTP id ada2fe7eead31-74533b84339mr908051137.3.1783737818123; Fri, 10 Jul 2026 19:43:38 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Laxman Acharya Padhya Date: Sat, 11 Jul 2026 08:28:27 +0545 X-Gm-Features: AUfX_mxDeHe86_YdwArqEXxpUTiTOxiWdaz-UlADypKSrt-vRHpBc2kW_hLs9sY Message-ID: Subject: [PATCH v2] iio: proximity: hx9023s: validate firmware size To: Jonathan Cameron Cc: David Lechner , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Joshua Crofts Content-Type: text/plain; charset="UTF-8" hx9023s_send_cfg() copies the firmware into a counted flexible array and then reads fixed offsets from the copied data before walking register/value pairs starting at FW_DATA_OFFSET. A truncated firmware image can therefore make the driver read past the copied buffer during probe-time configuration loading. Reject firmware images that cannot contain the fixed header, reject images too large for the u16 fw_size field, and validate that the advertised register count fits in the remaining payload. Fixes: e9ed97be4fcc ("iio: proximity: hx9023s: Added firmware file parsing functionality") Cc: stable@vger.kernel.org Reviewed-by: Joshua Crofts Signed-off-by: Laxman Acharya Padhya --- v2: - Explain the U16_MAX limit in a code comment. - Keep the existing kzalloc() expression unchanged. --- drivers/iio/proximity/hx9023s.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c index a6ff7cbe9e65..685053b84b34 100644 --- a/drivers/iio/proximity/hx9023s.c +++ b/drivers/iio/proximity/hx9023s.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -1031,6 +1032,10 @@ static int hx9023s_bin_load(struct hx9023s_data *data, struct hx9023s_bin *bin) static int hx9023s_send_cfg(const struct firmware *fw, struct hx9023s_data *data) { + /* fw_size is u16 in struct hx9023s_bin, so reject truncation. */ + if (fw->size < FW_DATA_OFFSET || fw->size > U16_MAX) + return -EINVAL; + struct hx9023s_bin *bin __free(kfree) = kzalloc(fw->size + sizeof(*bin), GFP_KERNEL); if (!bin) @@ -1041,7 +1046,8 @@ static int hx9023s_send_cfg(const struct firmware *fw, struct hx9023s_data *data bin->fw_ver = bin->data[FW_VER_OFFSET]; bin->reg_count = get_unaligned_le16(bin->data + FW_REG_CNT_OFFSET); - release_firmware(fw); + if (bin->reg_count > (bin->fw_size - FW_DATA_OFFSET) / 2) + return -EINVAL; return hx9023s_bin_load(data, bin); } @@ -1058,6 +1064,7 @@ static void hx9023s_cfg_update(const struct firmware *fw, void *context) } ret = hx9023s_send_cfg(fw, data); + release_firmware(fw); if (ret) { dev_warn(dev, "Firmware update failed: %d\n", ret); goto no_fw;