From: Baolin Wang <baolin.wang@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "John Stultz" <john.stultz@linaro.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Tony Lindgren" <tony@atomide.com>,
aaro.koskinen@iki.fi, linux@armlinux.org.uk,
"Mark Rutland" <mark.rutland@arm.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Mark Brown" <broonie@kernel.org>,
"Paul McKenney" <paulmck@linux.vnet.ibm.com>,
mlichvar@redhat.com, "Randy Dunlap" <rdunlap@infradead.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Ingo Molnar" <mingo@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
peterz@infradead.org, douly.fnst@cn.fujitsu.com,
len.brown@intel.com, rajvi.jingar@intel.com,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
x86@kernel.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-tegra@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/8] time: Add persistent clock support
Date: Tue, 26 Jun 2018 10:08:10 +0800 [thread overview]
Message-ID: <CAMz4kuLht0BAHdFp8+WPTanWSJCbioG+uwdoaKJCLDbcRkKXfg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1806232224510.8650@nanos.tec.linutronix.de>
Hi Thomas,
On 24 June 2018 at 08:14, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 13 Jun 2018, Baolin Wang wrote:
>> Moreover we can register the clocksource with CLOCK_SOURCE_SUSPEND_NONSTOP
>> to be one persistent clock, then we can simplify the suspend/resume
>> accounting by removing CLOCK_SOURCE_SUSPEND_NONSTOP timing. After that
>> we can only compensate the OS time by persistent clock or RTC.
>
> That makes sense because it adds a gazillion lines of code and removes 5?
> Not really,
>
>> +/**
>> + * persistent_clock_read_data - data required to read persistent clock
>> + * @read: Returns a cycle value from persistent clock.
>> + * @last_cycles: Clock cycle value at last update.
>> + * @last_ns: Time value (nanoseconds) at last update.
>> + * @mask: Bitmask for two's complement subtraction of non 64bit clocks.
>> + * @mult: Cycle to nanosecond multiplier.
>> + * @shift: Cycle to nanosecond divisor.
>> + */
>> +struct persistent_clock_read_data {
>> + u64 (*read)(void);
>> + u64 last_cycles;
>> + u64 last_ns;
>> + u64 mask;
>> + u32 mult;
>> + u32 shift;
>> +};
>> +/**
>> + * persistent_clock - represent the persistent clock
>> + * @read_data: Data required to read from persistent clock.
>> + * @seq: Sequence counter for protecting updates.
>> + * @freq: The frequency of the persistent clock.
>> + * @wrap: Duration for persistent clock can run before wrapping.
>> + * @alarm: Update timeout for persistent clock wrap.
>> + * @alarm_inited: Indicate if the alarm has been initialized.
>> + */
>> +struct persistent_clock {
>> + struct persistent_clock_read_data read_data;
>> + seqcount_t seq;
>> + u32 freq;
>> + ktime_t wrap;
>> + struct alarm alarm;
>> + bool alarm_inited;
>> +};
>
> NAK!
>
> There is no reason to invent yet another set of data structures and yet
> more read functions with a sequence counter. which are just a bad and
> broken copy of the existing timekeeping/clocksource code. And of course the
> stuff is not serialized against multiple registrations, etc. etc.
>
> Plus the utter nonsense that any call site has to do the same thing over
> and over:
>
> register():
> start_alarm_timer();
>
> Why is this required in the first place? It's not at all. The only place
> where such an alarm timer will be required is when the system actually goes
> to suspend. Starting it at registration time is pointless and even counter
> productive. Assume the clocksource wraps every 2 hours. So you start it at
> boot time and after 119 minutes uptime the system suspends. So it will
> wakeup one minute later to update the clocksource. Heck no. If the timer is
> started when the machine actually suspends it will wake up earliest in 120
> minutes.
>
> And you even add that to the TSC which does not need it at all. It will
> wrap in about 400 years on a 2GHZ machine. So you degrade the functionality
> instead of improving it.
>
> So no, this is not going anywhere.
>
> Let's look at the problem itself:
>
> You want to use one clocksource for timekeeping during runtime which is
> fast and accurate and another one for suspend time injection which is
> slower and/or less accurate because the fast one stops in suspend.
>
> Plus you need an alarmtimer which makes sure that the clocksource does
> not wrap around during suspend.
>
> Now lets look what we have already:
>
> Both clocksources already exist and are registered as clocksources with
> all required data in the clocksource core.
>
> Ergo the only sane and logical conclusion is to expand the existing
> infrastructure to handle that.
>
> When a clocksource is registered, then the registration function already
> makes decisions about using it as timekeeping clocksource. So add a few
> lines of code to check whether the newly registered clocksource is suitable
> and preferred for suspend.
>
> if (!stops_in_suspend(newcs)) {
> if (!suspend_cs || is_preferred_suspend_cs(newcs))
> suspend_cs = newcs;
> }
>
> The is_preferred_suspend_cs() can be based on rating, the maximum suspend
> length which can be achieved or whatever is sensible. It should start of as
> a very simple decision function based on rating and not an prematurely
> overengineered monstrosity.
>
> The suspend/resume() code needs a few very simple changes:
>
> xxx_suspend():
> clocksource_prepare_suspend();
>
> Note, this is _NOT_ timekeeping_suspend() because that is invoked _AFTER_
> alarmtimer_suspend(). So if an alarm timer is required it needs to be
> armed before that. A trivial solution might be to just call it from
> alarmtimer_suspend(), but that a minor detail to worry about.
>
> timekeeping_suspend()
> {
> clocksource_enter_suspend();
> ...
>
> timekeeping_resume()
> {
> ...
> if (clocksource_leave_suspend(&nsec)) {
> ts_delta = ns_to_timespec64(nsec);
> sleeptime_injected = true;
> } else if (......
>
>
> Now lets look at the new functions:
>
> void clocksource_prepare_suspend(void)
> {
> if (!suspend_cs)
> return;
>
> if (needs_alarmtimer(suspend_cs))
> start_suspend_alarm(suspend_cs);
> }
>
> void clocksource_enter_suspend(void)
> {
> if (!suspend_cs)
> return;
> suspend_start = suspend_cs->read();
> }
>
> bool clocksource_leave_suspend(u64 *nsec)
> {
> u64 now, delta;
>
> if (!suspend_cs)
> return false;
>
> now = suspend_cs->read();
> delta = clocksource_delta(now, suspend_start, suspend_cs->mask);
> *nsec = mul_u64_u32_shr(delta, suspend_cs->mult, suspend_cs->shift);
> return true;
> }
>
> See? It does not need any of this totally nonsensical stuff in your
> registration function and not any new read functions and whatever, because
> it simply can use the bog standard mult/shift values. Why? Because the
> conversion above can cope with a full 64 bit * 32 bit multiply without
> falling apart. It's already there in timekeeping_resume() otherwise
> resuming with a NONSTOP TSC would result in bogus sleep times after a few
> minutes. It's slower than the normal clocksource conversion which is
> optimized for performance, but thats completely irrelevant on resume. This
> whole blurb about requiring separate mult/shift values is just plain
> drivel.
>
> Plus any reasonably broad clocksource will not need an alarmtimer at
> all. Because the only reason it is needed is when the clocksource itself
> wraps around. And that has absolutely nothing to do with mult/shift
> values. That just depends on the frequency and the bitwidth of the counter,
>
> So it does not need an update function either because in case of broad
> enough clocksources there is absolutely no need for update and in case of
> wrapping ones the alarmtimer brings it out of suspend on time. And because
> the only interesting thing is the delta between suspend and resume this is
> all a complete non issue.
>
> The clocksource core already has all the registration/unregistration
> functionality plus an interface to reconfigure the frequency, so
> clocksources can come and go and be reconfigured and all of this just
> works.
>
> Once the extra few lines of code are in place, then you can go and cleanup
> the existing mess of homebrewn interfaces and claim that this is
> consolidation and simplification.
I am very grateful for your suggestion, and I am sorry I made a stupid
mistake that I missed the mul_u64_u32_shr() function which can avoid
introducing extra mult/shift for suspend clocksource. I will use that
and follow your other suggestions too. Thanks again.
>
> <rant>
>
> What's wrong with you people? Didn't they teach you in school that the
> first thing to do is proper problem and code analysis? If they did not, go
> back to them and ask your money back,
>
> I'm really tired of these overengineered trainwrecks which are then
> advertised with bullshit marketing like the best invention since sliced
> bread. This might work in random corporates, but not here.
>
> </rant>
>
> Thanks,
>
> tglx
---
Baolin Wang
Best Regards
next prev parent reply other threads:[~2018-06-26 2:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 11:32 [PATCH 0/8] " Baolin Wang
2018-06-13 11:32 ` [PATCH 1/8] time: " Baolin Wang
2018-06-24 0:14 ` Thomas Gleixner
2018-06-25 16:18 ` Thomas Gleixner
2018-06-25 17:23 ` John Stultz
2018-06-25 20:06 ` Thomas Gleixner
2018-06-26 2:12 ` Baolin Wang
2018-06-26 2:08 ` Baolin Wang [this message]
2018-06-13 11:32 ` [PATCH 2/8] clocksource: sprd: Add one persistent timer for Spreadtrum platform Baolin Wang
2018-06-13 11:32 ` [PATCH 3/8] arm: time: Remove the persistent clock support for ARM architecture Baolin Wang
2018-06-24 0:21 ` Thomas Gleixner
2018-06-13 11:32 ` [PATCH 4/8] clocksource: arm_arch_timer: Register the persistent clock Baolin Wang
2018-06-13 11:32 ` [PATCH 5/8] clocksource: timer-ti-32k: " Baolin Wang
2018-06-13 11:32 ` [PATCH 6/8] clocksource: time-pistachio: " Baolin Wang
2018-06-13 11:32 ` [PATCH 7/8] x86: tsc: " Baolin Wang
2018-06-13 11:32 ` [PATCH 8/8] time: timekeeping: Remove time compensating from nonstop clocksources Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuLht0BAHdFp8+WPTanWSJCbioG+uwdoaKJCLDbcRkKXfg@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=douly.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=kstewart@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mlichvar@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rajvi.jingar@intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®