From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFC131ED96 for ; Wed, 19 Nov 2025 07:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763535614; cv=none; b=JHwd5zyiFwpOMpJmAw6NZBeuavpYb+9OwOGDLy87/4ZF5hXi2QzEjKXKT5VxRtD1VePaIjbZr+xDBjiZApdMSO43Mf7CndlBe25ePBcf1l2LgRXqUszXOzdMTA0t4lLtjfs7+x3Jpni7c4uDiIL/sLHBdr6lSlpmXu3cM5QHmPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763535614; c=relaxed/simple; bh=C//nuYD3sxHkRsF0MUS3JcPxXHu6tsvLTGpo1KWoX8A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=RjBDuFZQFf7+OL1S0Y7FBZumy0lhWX5HArUbnBVOw4XbJP4cI1zY0fbGJckZu22ALbMwqzrPgpD9rtyiTX4zneZDKG5s0hnQSqgvz0Pc2S9TMbTXxQBti1qj01bTAEKTgvxV2cYNz2iRUc1c5IuYMjlC2A1WhSDisftDHEf7XEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XXVFxZ8n; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XXVFxZ8n" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-63f96d5038dso5362484d50.1 for ; Tue, 18 Nov 2025 23:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763535612; x=1764140412; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CKXeN3lXoFJirsuBqwPBgziYWBaDW/ia3ZuQKR5DhYI=; b=XXVFxZ8n/0Mxoes6NTrD6J6HE2ApckRM59j+uJJoVdlNsNilMn7tcpDgGyRBPyYEZc c7xI66Z+FHdPtfqFDIAzDCmVbU7JgGnthd27Ha5VDrCQiSymiwJkyI62TuWy0Xcrza7c zQwx3sm/OSPbE0BaIKwUhNONibMHIjRErZW98w4gw5/JFeLfr1rIv4oaFaMar5bP5mlT J9gxnI7UHd8sRN4AjyBzIU+QSrJTxBFP6x+qAlm0PL7V6GPLwYsGR1N6yNA28sU/KATi cvoVnB+bqWHxKPtE2K6caCR/LY45053YZFAA1etY1EEaIdQ37+ZiesrrZkAoaHp3UaYv t42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763535612; x=1764140412; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CKXeN3lXoFJirsuBqwPBgziYWBaDW/ia3ZuQKR5DhYI=; b=kXCAJguNh0YHIzTaBcix4Baq2SxfZ/T8Fg3R4zLwHa3Z9IinYg5hYttyy4NKvS0691 uM3LF6haFppkm6PL4jFA/cO46YdEmLPH0ankKvJdO1q3zlGCvf9YKrS3+pyfKVJgJcYo /3JKoJxrncCf3RHh8YmxD9Q+AoXHTUCwbrUPF7nWqcOKUtsXROts/f2+RbFijvLU6pt+ Xti0J0vL81zbz/OERhoLzySH0sy54QWLODMb85w87rCIAI3TYzzXMNgiffoKJW7Q8dER 4Q/0D0cnMjG87j3ZYUu1zfWK+4lPFX1+PnAIevwTjR+H5gigLUClWUnTd9eYDCTbhFwb FrGA== X-Forwarded-Encrypted: i=1; AJvYcCVsHdXXOtHk8/NnlYXVUicxbHKtqE9m5zcXGQ5em1fv5Lby5ADmYFq4VzNBmbJd2RvrlXVLOi8JqujTy94=@vger.kernel.org X-Gm-Message-State: AOJu0YwiMKO27lRdXm36+mSloLv1jkuGZK9AeYKMY49fatxWBao8a3XA hQybCL2qWxKPJuaJyfIVQCyIW+xnHzzJLJ+eT3Eg4AV9pa8IKKbCny/6UUVZQGOCxkBCKm/Becy sIPQFXoACk0XkWRUWh+ITBqvZ42WU3nA= X-Gm-Gg: ASbGncsSMCqJiEY5HxynF3DISos3n2ltSwIGk5AK7tvkSWXouwqnW+67P3dW+Y/nC+0 uTeKiVwhWmTQxm/0yEJ/aHrgp30WVlw7bn1BiGeT41j6ZXSMXRmTCcq7vMBmyS9ApPmcrnAh9wU kVDkSm3Oac01fAkB8z0UozRDn0eiaC+WbjyUIWfK0BWQJf/xvRqNYL+IOArx63AjACkqljFsQxd u+YPx9q5C5KQpurjtd+jfkY8Z2XMIH85SVUxGvJqEI9e/P8i3bCvZFclW2vy/eC99sO2fxLA6NR r+abOw+g5052puw7Sf6QwZRipMQ= X-Google-Smtp-Source: AGHT+IEKoWpPlSpd7U4NDw/b6BWiTAb0dv3Nfymh2sNbb71XM40guLSJjJed5KV8LAKmRs+9ZZwvdWafkh9Z5A2lWi4= X-Received: by 2002:a05:690e:424b:b0:63f:b446:7019 with SMTP id 956f58d0204a3-642ed19f069mr885869d50.64.1763535611915; Tue, 18 Nov 2025 23:00:11 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251117191657.4106-1-fabio.baltieri@gmail.com> <89298d49-d85f-4dfd-954c-f8ca9b47f386@lunn.ch> In-Reply-To: From: Michael Zimmermann Date: Wed, 19 Nov 2025 08:00:01 +0100 X-Gm-Features: AWmQ_bmfL2RVzkRfFQkrMvx2GF_t6pB3lLmshM-uCOdJh4qG2uKH8Dz_mCBhx6w Message-ID: Subject: Re: [PATCH] r8169: add support for RTL8127ATF To: Fabio Baltieri Cc: Heiner Kallweit , Andrew Lunn , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 18, 2025 at 11:01=E2=80=AFPM Fabio Baltieri wrote: > > On Tue, Nov 18, 2025 at 10:31:54PM +0100, Michael Zimmermann wrote: > > One thing the out-of-tree driver does, which your patch doesn't do, is > > disabling eee when in fiber mode. I'd suggest something like this: > > @@ -845,7 +860,8 @@ static bool rtl_supports_eee(struct rtl8169_private= *tp) > > { > > return tp->mac_version >=3D RTL_GIGA_MAC_VER_34 && > > tp->mac_version !=3D RTL_GIGA_MAC_VER_37 && > > - tp->mac_version !=3D RTL_GIGA_MAC_VER_39; > > + tp->mac_version !=3D RTL_GIGA_MAC_VER_39 && > > + !tp->fiber_enabled; > > } > > Heya, don't I have exactly that diff in the patch? The second chunk > > @@ -842,7 +843,8 @@ static bool rtl_supports_eee(struct rtl8169_private *= tp) > { > return tp->mac_version >=3D RTL_GIGA_MAC_VER_34 && > tp->mac_version !=3D RTL_GIGA_MAC_VER_37 && > - tp->mac_version !=3D RTL_GIGA_MAC_VER_39; > + tp->mac_version !=3D RTL_GIGA_MAC_VER_39 && > + !tp->fiber_mode; > } You're right, no idea how I missed that, sorry. I've also done some testing with the out-of-tree driver: - (my normal setup) a DAC between the rt8127 and a 10G switch works just fi= ne. - RJ45 10G modules on both sides works fine, but HwFiberModeVer stays at 1 even after reloading the driver. - RJ45 1G modules on both sides works after "ethtool -s enp1s0 speed 1000 duplex full autoneg on", but you have to do that while connected via 10G because that driver is buggy and returns EINVAL otherwise. HwFiberModeVer was 1 as well after reloading the driver. What this means is that the fiber mode is always enabled on these cards, which makes sense given that the out-of-tree driver only reads it once when loading the driver. I guess it's either a hardware variant, configured in the factory or detected using a pin of the chip. It also means that it doesn't matter to the linux driver what's actually connected beyond the speed you want to use since - as others have said before - this seems to be fully handled on the NIC. Michael