From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC26B331EAB for ; Fri, 12 Jun 2026 14:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.180 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781276034; cv=pass; b=gUixpP6yhxAVuEYVU72/emIXsv/BZJs3xtAuiSwIjbYKwkcL6dcgPW85Pic0HDbUrdFhSR/i3mav9iTzhaGTO25X2HsL6YZQGKsP+22UMu7U5gdurguprWR9qpXAMwA6C5p09nwYQl12eQwABo1qsOagEU/l4Vd4OFqXVpHGJdA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781276034; c=relaxed/simple; bh=jg/jG1GQgNRKAE3i2ndG5Nw/kqSFIlVSs+wnbwQYTuk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SgnM4r1/gXuwOZ0grETjP97ROgHEGmqdElIbuILiGGH4hW9Ghjg8EYm81lOpxLX/Yxv3Dzl0mTaqcO2f8cclZGaZKugrqi/6RY+rDBW/8rO93lUv4TbjHAynl50bQrKb29AnC9BmAV3I3An5M8IKS4mhc/J1fq44YZMWF1x7NKE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dpy9aJaw; arc=pass smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dpy9aJaw" Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-5a1490272bfso674708e0c.0 for ; Fri, 12 Jun 2026 07:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781276032; cv=none; d=google.com; s=arc-20240605; b=MXx6XFyhUP2PbGraWbTTEJbekmzcdqVuVQiZqi5CN3joG6lGTqQzU4tk3lvIjg0FxM ItzVJgbNaPu1C3WD3Eb4JIPOoBTEP6X5fcDnMMihl3ZHQ54gnGOSYDoSWJgD5EVrC3f9 H+e0FPBMcAQsvLrNCkTtZr93N4hC7ywNeFMcalpEPLoq07Jqg2AVS+dOli0/lX4Lq7S0 go56VPy8oDnf7EaijKLwlbJc/JLNeVoS7cXLoKN0B34Y2YpPZ3P709Es0SukIqL4M9aw echzoH20EYySGZ2KXXfRfvWz/yeX6gZEV3JtJTUfVs6Fh3QIY52u8vuFK63LeDNcu86+ BnYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=jg/jG1GQgNRKAE3i2ndG5Nw/kqSFIlVSs+wnbwQYTuk=; fh=zdzaEoLB7SvifVmVccP9Lgo9FJgc+f+9snOYa1QdRPo=; b=HgSTlGpKVOwNR0eUqhFaQWBBoViEdLAMrQ/j3SWSelf1P6bNtO09QxFE6q1kNI54xs f+Fjfcy69fqoGC6E/dyWgseM6KwZFDwBdvXPMRx+JuqtOgMEJCVNPhvRFVPZti4a1iyZ d2Z40LPWnHvR6Ku0dcGF0yzlq1HdQ6+XrdejjPMbOugakjIKTHO6O/ooo98yHVpYX26Z p0dNwa53hQnO9j3Mbwg4Z6Dyw7Rt+ewJN7rPFuOairLl7Vjb6So6wRn//KDg064Cbt/w M0UJrjFDxcGdZ4qO5ua8Y9UTHsO0lc0tlgvrpaws+PRJN4lsJQm+TVdyTa5gTcoa+xK+ nZ/Q==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781276032; x=1781880832; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jg/jG1GQgNRKAE3i2ndG5Nw/kqSFIlVSs+wnbwQYTuk=; b=Dpy9aJaw17H89mngpjBiilJJdzGEKZJc06o+vSRmN7KQatn9qW5S45m/62fdp9QZFT taTlGhjS9a+k6fAO5MtMHuM7FECFVg706rH69yDny8mh33KxVUyY7eTxXlt2UnmIYT35 ++BRBP7+KKh5dO58LeSM9Ruh5prP6h0mexBdH3VGystusHZhTw0S4r0rb7rGs/JS+ear W/rFaKNzmWxBcCKyrE24NajqGvBoeUyLnr4Cjkah1sNeaWdrjcAs88MzImt+NFWh5zLX wQU1xk3TOeL7W0CFoJ/xtcF3590R1GuNQ0jWikMrWRFqFJSKCjTNxYB6zALFyHLI1m7F bMUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781276032; x=1781880832; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jg/jG1GQgNRKAE3i2ndG5Nw/kqSFIlVSs+wnbwQYTuk=; b=reg92Bi3Vi9C2s49eK7dbnS3YUlzpcIeZxPlB4wrXlTNYgvRsGkb8k65EgOYrRgMnA 3OMSzie1HLARLDoNuZIiotU1DRIravxRktaaVI8SuLUHBSl9ZZF3TQ2Ne46jHFrvH6tU kAP8faCIQCggUIHfqF8PYnmR4emuYd93yMu/DgdE7BgfiFF16kpV6EuEmVNPnD/hXBhN 89kYrRex6c5YUP1oXSJpCpzmJ5f1SYo09YX99ExgwnfP4ycvaG9lT+HMxQpWbBWYyjWf 4ynxxpw4ZoYEbDF8h4L5fsxxbX8phbBVXg1MJGJBImHjuMuTZEa5qRTUHVkMq9+kUbts cjDg== X-Forwarded-Encrypted: i=1; AFNElJ9+EqgFnED7QkX2NHxz612qwqVICC6kbIgaAz5ReMxhLzBlAkqCYYkAWPLPn1W6Xm87VIeQBdMgJa7fhok=@vger.kernel.org X-Gm-Message-State: AOJu0YyCMUlhbkcA57/4uZUvRCCLJV5KKQPhq2fYHKhv/3WVyXLRGZrc ZnKEIJreSN9gOgRbpWYmFnRPwkuHZvjNb5LI75JSWk+RprHTN0mCeh1ApaczcaoLg10vLHafSL0 Gr5M/E9kwCJFOVZPYirK7zCJwwouRo2U= X-Gm-Gg: Acq92OHiA4hbd8CJ/0IFbCtXyY7IWc9U37u2PADLlCMqBqUXpVvJiWFUK1D//Si/Fmo McFASLPVQYhisZteVDP9wiFYf/mCvux0B5hxqB19OFxriEiL2wCNb/xifWcVphdXOdVjGNAxB/y mrTsBYmWP6q0AN/lOnQi56E9sQS091ZpkzbaYmmSW3icKPyyV/NzqgzRtM9QINVhlEhQwmVN86b S6x9MVbzxa9j8HE9VrfWgpGuwYFJ0bwqU1XYc0h72js8cLePrmH8CctsklVd0mL0hh2R5lBUHLQ 8EvR+IFevXlPWJZl9KAuupjEfM6YAoDrJbN/RgKBdao0ZaXs5A== X-Received: by 2002:a05:6122:6503:b0:59b:f9b4:8748 with SMTP id 71dfb90a1353d-5bb69fa3ff1mr1022262e0c.4.1781276032418; Fri, 12 Jun 2026 07:53:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <0f97352506d8d813f70f441de4d63fcd5b7d1c3e.1779123847.git.shuvampandey1@gmail.com> <20260611221000.GA524832@bhelgaas> In-Reply-To: <20260611221000.GA524832@bhelgaas> From: Shuvam Pandey Date: Fri, 12 Jun 2026 20:38:41 +0545 X-Gm-Features: AVVi8CeSnuFKBXw07pnZfggT3zcPEONqkcJp-rRWL-FHYqitFjSsHZlw-QFmmE4 Message-ID: Subject: Re: [PATCH 1/2] PCI: dwc: Guard RAS DES debugfs deinit To: Bjorn Helgaas Cc: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Yue Wang , Neil Armstrong , Rob Herring , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Fan Ni , Shradha Todi , Hanjie Lin , linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Bjorn, > I guess this prevents a NULL pointer dereference, right? Yes. This is in the CONFIG_PCIE_DW_DEBUGFS teardown path when the controller does not advertise the RAS DES capability. In that case dwc_pcie_rasdes_debugfs_init() returns 0 before allocating pci->debugfs->rasdes_info or initializing reg_event_lock. Later, dwc_pcie_debugfs_deinit() still calls dwc_pcie_rasdes_debugfs_deinit() unconditionally. With CONFIG_DEBUG_MUTEXES, mutex_destroy() dereferences the mutex, so calling it via &rinfo->reg_event_lock when rinfo is NULL would dereference NULL. Without CONFIG_DEBUG_MUTEXES, mutex_destroy() is a no-op, but there is still no RAS DES state to tear down. So the patch makes the deinit path match the init path: if no rasdes_info was allocated, skip the RAS DES mutex teardown. Thanks, Shuvam