From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758596AbbCESML (ORCPT ); Thu, 5 Mar 2015 13:12:11 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:37208 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754438AbbCESMJ (ORCPT ); Thu, 5 Mar 2015 13:12:09 -0500 MIME-Version: 1.0 In-Reply-To: <20150305172253.GA2051@pd.tnic> References: <1425562251-10218-1-git-send-email-kuleshovmail@gmail.com> <20150305172253.GA2051@pd.tnic> Date: Fri, 6 Mar 2015 00:12:09 +0600 Message-ID: Subject: Re: [PATCH v1][CLEANUP] x86: use already defined macros instead of hard-coded values From: Alexander Kuleshov To: Borislav Petkov Cc: LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Borislav, > > This patch introduces two new bugs. For educational purposes I'm not > going to tell you where they are but let you find them. > Ok, i looked on it with gdb, and X86_FEATURE_NX is not correct here. It's a bug number one. And L3_START_KERNEL*8 + 1, must be L3_START_KERNEL*8 + 8, as we works with page entries or i'm wrong here? Anyway, thanks for education:)