From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbbCAVRS (ORCPT ); Sun, 1 Mar 2015 16:17:18 -0500 Received: from mail-qc0-f176.google.com ([209.85.216.176]:44495 "EHLO mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbbCAVRQ (ORCPT ); Sun, 1 Mar 2015 16:17:16 -0500 MIME-Version: 1.0 In-Reply-To: <20150228213110.248177252@infradead.org> References: <20150228212447.381543289@infradead.org> <20150228213110.248177252@infradead.org> Date: Sun, 1 Mar 2015 13:17:15 -0800 Message-ID: Subject: Re: [RFC][PATCH 7/9] rbtree: Implement generic latch_tree From: Michel Lespinasse To: Peter Zijlstra Cc: mingo@kernel.org, rusty@rustcorp.com.au, mathieu.desnoyers@efficios.com, oleg@redhat.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org, tglx@linutronix.de, Andrea Arcangeli , David Woodhouse , Rik van Riel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 28, 2015 at 1:24 PM, Peter Zijlstra wrote: > Implement a latched RB-tree in order to get RCU style lookups. Looks fine to me. I wanted to ask, you are writing this as a generic layer even though there is a single use at the moment; do you anticipate this will get more usage soon ? I may have more comments if I knew what those may be (it's probably all fine if the rate of changes is very low such as with module load/unload, but I'm not sure what else you have in mind). -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.