From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755896AbdJRAvz (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 20:51:55 -0400
Received: from mail-oi0-f43.google.com ([209.85.218.43]:44650 "EHLO
        mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752566AbdJRAvx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 20:51:53 -0400
X-Google-Smtp-Source: ABhQp+SlGZ8tnS/tbEosuvO5BhhA389SO96BPmu6sGc+e6lDGo40bNPKPCSKKwm+rF7gWYBtN70aI1GOsM5hlqOxrHw=
MIME-Version: 1.0
In-Reply-To: <52b28aa7-d69a-53d9-4eb6-3c18ceddccc1@redhat.com>
References: <1508213038-5593-1-git-send-email-wanpeng.li@hotmail.com>
 <1508213038-5593-2-git-send-email-wanpeng.li@hotmail.com> <CALMp9eTBs+aif_PF+W38rjGw-aTqNz5TXOEyXrMLmywXbwDPRg@mail.gmail.com>
 <52b28aa7-d69a-53d9-4eb6-3c18ceddccc1@redhat.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Wed, 18 Oct 2017 08:51:51 +0800
Message-ID: <CANRm+CwTYhbEXeHbjbN2Bi483JHTc7bBbWsN8BXw++mF6rZhtg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] KVM: VMX: Fix VPID capability detection
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jim Mattson <jmattson@google.com>, LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-10-18 1:48 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
> On 17/10/2017 19:43, Jim Mattson wrote:
>>> +               &vmx_capability.ept, &vmx_capability.vpid);
>>> +
>>>         if (_cpu_based_2nd_exec_control & SECONDARY_EXEC_ENABLE_EPT) {
>>>                 /* CR3 accesses and invlpg don't need to cause VM Exits when EPT
>>>                    enabled */
>>>                 _cpu_based_exec_control &= ~(CPU_BASED_CR3_LOAD_EXITING |
>>>                                              CPU_BASED_CR3_STORE_EXITING |
>>>                                              CPU_BASED_INVLPG_EXITING);
>>> -               rdmsr(MSR_IA32_VMX_EPT_VPID_CAP,
>>> -                     vmx_capability.ept, vmx_capability.vpid);
>>> -       }
>>> +       } else
>>> +               vmx_capability.ept = 0;
>> I would expect vmx_capability.ept to already be 0 here. Otherwise, L0
>> is reporting inconsistent VMX capabilities.
>>
>>> +       if (!(_cpu_based_2nd_exec_control & SECONDARY_EXEC_ENABLE_VPID))
>>> +               vmx_capability.vpid = 0;
>> I would expect vmx_capability.vpid to already be 0 here. Otherwise, L0
>> is reporting inconsistent VMX capabilities.
>>
>
> That's true, but I think it's better to be safe.  Maybe add a pr_warn if
> it is not zero?

Will do in v3.

Regards,
Wanpeng Li