From: Guangshuo Li <lgs201920130244@gmail.com>
To: krzk@kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
stable@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: rawnand: intel: fix OF node reference leak
Date: Tue, 22 Sep 2026 10:51:32 +0800 [thread overview]
Message-ID: <CANUHTR-pX7NrnehBT_p41oAd05jdbcnuLvmLfFE2nfQ1zqbWTQ@mail.gmail.com> (raw)
In-Reply-To: <arFJDKtpHSmxkhVG@quoll>
Hi Krzysztof,
Thank you for your feedback.
On Mon, 21 Sept 2026 at 23:11, <krzk@kernel.org> wrote:
>
>
> On Wed, 16 Sep 2026 00:34:07 +0800, Guangshuo Li wrote:
> > ebu_nand_probe() gets a reference to the NAND chip node with
> > of_get_next_child(). The probe failure paths release the reference with
> > of_node_put(), but the successful probe path keeps it for the lifetime
> > of the device and ebu_nand_remove() never drops it.
> >
> > As a result, each bind/unbind cycle leaks a reference to the NAND chip
> > device node.
> >
> > Drop the reference in ebu_nand_remove() after the NAND teardown using
> > the flash node stored in the NAND chip.
> >
> > This issue was found by manual code inspection.
> >
> > Fixes: bfc618fcc3f1 ("mtd: rawnand: intel: Read the chip-select line from the correct OF node")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> > ---
> > drivers/mtd/nand/raw/intel-nand-controller.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
>
> You sent multiple independent patches, to multiple independent
> subsystems. The amount of these patches clearly suggest this was
> AI generated and most likely not tested.
>
> More importantly, you sent all this work without properly organizing
> relevant patches into patchsets. This makes reviewing difficult
> and might cause multiple reviewers to address the same issue.
> Replying to the entire set is impossible and requires handling each
> patch independently, instead of applying or discarding the set.
> Maintainers also won't see the bigger picture of your work. Quite
> worrying.
>
> This is on the verge of hostile patch: bomb us with so many
> contributions, we won't be able to handle them in efficient manner,
> like responding ONCE to ask you to slow down. Considering all this
> is untested and LLM generated, I have even more doubts whether this
> should be considered for review.
>
> Please read kernel documentation BEFORE posting more work. It will
> explain you how to identify subsystems, how to organize your work per
> subsystem, how to document usage of LLM and how what you should not
> do if this was posted in a good faith.
>
> Best regards,
> Krzysztof
>
>
>
I would like to clarify that these patches were manually reviewed and
audited by us; they were not simply generated and submitted by an LLM.
However, I understand why the recent submission pattern may have given
that impression. We sent too many patches in a short period of time,
and we also failed to respond to some discussions in a timely manner,
which made the situation look worse.
Many of the recent patches, especially the v2 revisions, are
corrections and improvements based on previous review feedback rather
than completely new untested changes. That said, we recognize that the
way we submitted them increased the burden on maintainers and
reviewers.
We apologize for the pressure this caused to the community. We will be
more careful about organizing patches by subsystem, preparing proper
patchsets, and following the kernel contribution guidelines before
sending future work.
Thank you again for pointing this out.
Best regards,
Guangshuo
next prev parent reply other threads:[~2026-09-22 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 16:34 Guangshuo Li
2026-09-20 13:22 ` Miquel Raynal
2026-09-21 15:11 ` krzk
2026-09-22 2:51 ` Guangshuo Li [this message]
2026-09-21 15:13 ` krzk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANUHTR-pX7NrnehBT_p41oAd05jdbcnuLvmLfFE2nfQ1zqbWTQ@mail.gmail.com \
--to=lgs201920130244@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®