From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 501113A7F75 for ; Wed, 26 Aug 2026 08:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787732073; cv=pass; b=pdau/+xzCWjm3qGjQH9lfildM4gONrkmWrD5Kist+nUqr//7Idb9Ku74Ir7XqO6aYMYxNKqvOD0bb+9Vff5AwQvxoLcspBflNz0BC9zVkBBERGCz0qWCplhHNwfpwLd0a6B+rIyGGN8Pa6s703J08zOgN6q+agsPtEnUcatpw6s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787732073; c=relaxed/simple; bh=R9amIzEFA8q5uB6W0hUHTDML7nWF8S2I9fUZICwpgSY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NIgZKbDFhZWXYV2RGizmxpdMHnZlQuGLK8272P4X66Oj5DReErl/jFT4Z2Pp9XpcIl3SLCiL/H7y3qmTjJKSVXSXuw1i59L97/x0fGVBAeanZRkRvc46jjpmSplh3Ylh12ncMSwBxT3EHoo1tJUzh6jYExne3tGRWC6roL0QWrY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CAU8Xm7l; arc=pass smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CAU8Xm7l" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-66c7127a73dso884724d50.2 for ; Wed, 26 Aug 2026 01:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787732071; cv=none; d=google.com; s=arc-20260327; b=HZfmhDcpuc/wbONeRAjCNQYsE2bMjbh/Rmep71wTjNbYxxmqmKjb9FITn70EA7tBrO UG7YAMZynWc+pRbzqJ3qbk20c8MUf1RzNcu60FE+w8vF7xAqhqIHycp/TeSVuLg59SUZ w6Qfv3irzIn2y9b6ouckAn+eMiLa2HaUTLgoVDPHyvjbnDSHciVm7OCS9t+u3MROHNFv gvY5RVANqpgQQ8dJg15jgh+IVVQS4TwyMJIZ/GjCxLQJ7jCIsc5Y4jzYozMMU8iEImi4 plfNpNBQLqmU39I1+XDGHckjEDuWW+mRU30Qsz2bMRV4iQNQxQ+uM9lIduq37wLBKj+c v0gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=R9amIzEFA8q5uB6W0hUHTDML7nWF8S2I9fUZICwpgSY=; fh=4UmHXPqqHC/55v+J/gXMSal7vetW4BMLqAAD6Z0VEsg=; b=Cl5uUKtRU+gk+gKNNOmrluAngS/bCsQS87LhGWbZ/VaCFhAoTBjdQAhx0B9Y9feoVW 8/6vrgYZE2T8MP3+qtZOLabnLFH6fohneR0CDzNmc7iG+2UMbyCN73oaCST/ehVj38OB vqiYZZVzXtyHQ7cAUyiWB5HDb5Yo/kj8Y1d7ThQErAqW79/TLVOPDZMOUeinH9cncQaw 5F02hwN2AUtQ9O+BVk14OlTnM97xQMTmYTLEu16oyj+BeE1UVB5Vk+R1OTobw7t7vgzS +hJFXHmIIkXELCRHoQXs9xhchRPUlMNjZeLSiT/eEKEIHM+Fb4IXB9jkDhuQza3UOgOg E07g==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787732071; x=1788336871; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=R9amIzEFA8q5uB6W0hUHTDML7nWF8S2I9fUZICwpgSY=; b=CAU8Xm7lzdq1b1qO40sGEQasOMuOPt91pJDd62FxN3OIyDJXcmmUbpIqvRrC4QUuGn qpHtR1B2GKXZSckfzUt6vVW62uHCDOiWhJYzqkkZfmE+dyeGYdDSRNqa4LSzULwKgDIW pOMwN0VGK4ZNzUemiU9wI+5Y/6N9niw6Lp/r08lgrm6jiY4/2YdVAmBfkA1bcFUMXPna kiHzsiJjblwHgLoxzVWQSk6oVBrguHCoE2Sv/tnoR3LyaLyyatub1zPUGFcjvpmT1N/B 11ihuug8+FLdBTQOpmv2oUvMTU/HXCohtBzpFEINpxiJOJ3Ym6DdftmfGJqXMY78JOyg XdEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787732071; x=1788336871; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=R9amIzEFA8q5uB6W0hUHTDML7nWF8S2I9fUZICwpgSY=; b=ME6pQo18lnmB49MZkmAWV4N1DiHYhKFwF5665Wpxf335Bka5xjQpB8zl5No7pz81A5 t2oHj4xO0pNSDBii3cX/Ef3EXsXS2K1a1d8VVfhGzoorCYjXFRufJAW6CxZA0T7mQ+Lb RnyENn1ZufG5OOl3Z7LZARWyIizP+aSsW76DtmdtR//4PhdeB5ejQfoJm8Utx0EUYx6S SYT3OaOB6L32AAERIOc14w9nX7j15fsNNNVPtLButtoS5z+Uzv89AEoWpsELMUYFSRYn 3g4pvqtGa8uTrSzByaFlT5tNXr/yS3aoW5cAdtFQEMD/n/0DGyK9wraXVqLJKZLY9OAa 4/LQ== X-Forwarded-Encrypted: i=1; AHgh+RoEtYspsLMLPiDlxIHa6ftxgRPn9hecHEOk1p9479VH2NAyTp46VFEy5jPcV4Fvy874maCZqJ7v3Bg8qv0=@vger.kernel.org X-Gm-Message-State: AFuF++lSwBBiSUdq24Kh/uNkPAfJ9VmuSQcOBK+7u8TZaqd6gkRhwZvH 7+PjqB8OZ+QWgLXK3wbm9NLdtOiNVUkTAdNFmmWciNI2Acp9nXbvHqkVTpJjJiofNp7hxR2Ap8J NoSkCVKLjSa5uqGMfJHOIxmqF1OjUza0= X-Gm-Gg: AR+sD101GA1feICGoNA0vltbYhNJRv9fWg7+rPw1YYsbpKjDmQ2QKWd2mESD4NEs/Sk Go0uvxyymHVvRl5verPPtDErvzQ9bb1PaoUiYW27GNQ8GW3AEtH8Y4PNNAeeB1zYnxR83rIfyfw RutPgk98Au9LzAQFUxltzdQPMu3LrSsn7PIUmTP4osBYxWHsPH9b2AD9Rxr2+015Ye0ecmTGygE ZHeviAjvyBFNOvCamAu08UtELjaYwILTLs7SoVxlXnfs0QDu7Wu+mMGe5lbiW1T4ftmmxdA4Qhs SaDEerD0U1uzwWUzraukKP4vqCBSOZAOnfqqw12q6NwpiwE= X-Received: by 2002:a05:690e:e8a:b0:66c:d6f6:eaef with SMTP id 956f58d0204a3-66d25694eeamr1750611d50.18.1787732071154; Wed, 26 Aug 2026 01:14:31 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260812094425.3515179-1-lgs201920130244@gmail.com> <327de6a8-6c67-4328-83a2-bfea332aba7c@kernel.org> In-Reply-To: <327de6a8-6c67-4328-83a2-bfea332aba7c@kernel.org> From: Guangshuo Li Date: Wed, 26 Aug 2026 16:14:19 +0800 X-Gm-Features: AcwNN1WbmUut-7AuuFCqwoZdX5jzcjMrvGCq4xDXrennGXYAL0ALsEP7Epy-Qzg Message-ID: Subject: Re: [PATCH] i2c: qcom-cci: fix autosuspend cleanup To: Krzysztof Kozlowski Cc: Loic Poulain , Robert Foss , Andi Shyti , Todor Tomov , Wolfram Sang , Vinod Koul , Bjorn Andersson , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, On Thu, 20 Aug 2026 at 22:01, Krzysztof Kozlowski wrote: > > On 12/08/2026 11:44, Guangshuo Li wrote: > > cci_probe() calls pm_runtime_use_autosuspend(), but the remove path > > does not call the matching pm_runtime_dont_use_autosuspend() before > > disabling runtime PM. > > > > If the autosuspend delay is set to a negative value while autosuspend > > is enabled, the runtime PM core increments usage_count to prevent > > runtime suspend. Without undoing the autosuspend setting during > > teardown, this reference is not dropped and usage_count remains > > unbalanced. > > > > Use devm_pm_runtime_set_active_enabled() to manage the runtime PM > > state. Its managed cleanup disables autosuspend and runtime PM and > > restores the suspended state on probe failure and driver removal. > > Remove the now redundant manual runtime PM cleanup. > > > > This issue was found by manual code inspection. > > > > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Guangshuo Li > > You sent vast amount of patches, all separate, making it very difficult > to track and respond in efficient way. Do not do that. > > Group your work per subsystem. > > You were asked to clarify and respond to incorrect fixes statement. I do > not see how you clarified and responded at all. > > Best regards, > Krzysztof Sorry about that. I should have replied to the earlier review comments explicitly, and I also should not have sent so many separate patches. I will group future patches by subsystem and make sure to respond clearly to review feedback before resending. Thanks for pointing this out. Best regards, Guangshuo