mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Ijano <andrew.ijano@gmail.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: jic23@kernel.org, andrew.lopes@alumni.usp.br,
	gustavobastos@usp.br,  dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org,  jstephan@baylibre.com,
	linux-iio@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] iio: accel: sca3000: replace error_ret labels by simple returns
Date: Sat, 14 Jun 2025 16:12:44 -0300	[thread overview]
Message-ID: <CANZih_TOQXvHSLg5GQ2NPE+Zp0P3Fm1MBff_2wKEfOOEOQMjVw@mail.gmail.com> (raw)
In-Reply-To: <304d3bcef438a78564650edd52f7570f0bd30c95.camel@gmail.com>

On Thu, Jun 12, 2025 at 4:41 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
...
> >
> > Code looks good. But since you're doing this you could cleanup some of the switch()
> > cases. Some return in every case statement while other don't (even think I saw one
> > one place where 'return' in the end was not needed). IIRC, there's preference for
> > returning in place.
> >
>
> I see the above could be a bit cumbersome in cases there's locking (which get's
> cleaned up in patch 3). So, nevermind the above. If there's any leftover, you can
> send a follow up patch or introduce a new patch if you need to re-spin.
>
Great! That's the idea, I addressed these cases in patch #3, but I'll
double check if there is any leftover!

Thanks,
Andrew

  reply	other threads:[~2025-06-14 19:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 19:39 [PATCH v5 0/3] iio: accel: sca3000: simplify by using newer infrastructure Andrew Ijano
2025-06-11 19:39 ` [PATCH v5 1/3] iio: accel: sca3000: replace error_ret labels by simple returns Andrew Ijano
2025-06-12  6:20   ` Nuno Sá
2025-06-12  6:41     ` Nuno Sá
2025-06-14 19:12       ` Andrew Ijano [this message]
2025-06-12 12:56   ` Andy Shevchenko
2025-06-14 11:48     ` Jonathan Cameron
2025-06-14 19:16       ` Andrew Ijano
2025-06-11 19:39 ` [PATCH v5 2/3] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers Andrew Ijano
2025-06-12  6:29   ` Nuno Sá
2025-06-14 19:33     ` Andrew Ijano
2025-06-18  2:36       ` Andrew Ijano
2025-06-12 13:22   ` Andy Shevchenko
2025-06-14 21:06     ` Andrew Ijano
2025-06-14 21:50       ` Andy Shevchenko
2025-06-15  3:21         ` Andrew Ijano
2025-06-11 19:39 ` [PATCH v5 3/3] iio: accel: sca3000: use guard(mutex)() for handling mutex lock Andrew Ijano
2025-06-12  6:38   ` Nuno Sá
2025-06-14 11:54     ` Jonathan Cameron
2025-06-14 21:17     ` Andrew Ijano
2025-06-12 14:48   ` kernel test robot
2025-06-12 15:52   ` kernel test robot
2025-06-12 16:06     ` David Lechner
2025-06-14 21:21       ` Andrew Ijano
2025-06-14 12:01   ` Jonathan Cameron
2025-06-14 21:40     ` Andrew Ijano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANZih_TOQXvHSLg5GQ2NPE+Zp0P3Fm1MBff_2wKEfOOEOQMjVw@mail.gmail.com \
    --to=andrew.ijano@gmail.com \
    --cc=andrew.lopes@alumni.usp.br \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gustavobastos@usp.br \
    --cc=jic23@kernel.org \
    --cc=jstephan@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®