From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8A6285C8B for ; Fri, 20 Feb 2026 07:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.172 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771571050; cv=pass; b=LpdTygo7xKW5ExP4kkfJMEyNLYn9qGDwx8MzlRJjZYJT/kVC9BE0Z+cHi1Yf7CQP1C5fD4Qp/X89cypLZFNt5P0tIXP3a3IzG9wSerwRTceoGf2aI0Wwhaul7hG32NPbfH+Q+lpqYDCW885s8o3jn0VShld7n0Echqw3zbZ718E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771571050; c=relaxed/simple; bh=QMR+CL5aFfq+xybOxaTpFTc5JmpJYvn3yqtfhXHwfDo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jPVRYFdJr1WHS3ft0w6ObPAgK1KQVHXZZCZP8s0wRJ6ee3T8+XqUzW9hnfBPWe36yylip+gudknN/7oeOjLgQ0QWVCMRN7wH+ziVDiydylAfRZhL05w4sTNq8Pttmj0joBTCUbHIaPxocgrdv1rgIQIYBjdBaWzsKyX/XnnNVag= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JsWBtpVT; arc=pass smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JsWBtpVT" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7964fb9ae3dso16133547b3.0 for ; Thu, 19 Feb 2026 23:04:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771571048; cv=none; d=google.com; s=arc-20240605; b=UTMKfYU6ZWycp1hLEm3hO2EHaW+iHVQBM1FI4c9s7FWFiNYUIiItE7K9Y6NX02ohfc khQfrg+HnUh8jk3Ojw5is3G7LBl7jxU7CYlweUghFNMGJMllBggOXNn9sJXR0sOcuLR9 cd/MDglfHQuFlG0w/Icsu01VTapEgqMon5sKyszMZvVKoOKX9HzEnj4uMuVeSI2y+SSU cgJjz0cAijQQWexuZJPAPAcIwuJy104+oD6S4yPFf3tXmPFygL5Li04dly+tTR++yQyd w4hIkBKfMfh/yx5ydJk1PqVMleCRwAA6fHqWePfqD4aqZexM3cMktL3JBGviDe/h/0Im zh2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RWlFRvAAv3Ez0sCmmg14nrvJGE/f1SXTlqum7nZ6ROI=; fh=WeT40o60XF9XHHlmyrO0rem1k4GhST9kcCeE8ZzVlCc=; b=SXk2PGb79HLkQungTvlF0xOONQLkh3gnvPL59SNORaYuZfeBkaU7eoT1pxHJ+4YNUM 3CXFOVmB5L6GbDfZQ3dLGM50gm9An9MM/EF3NDKo31cXKOe8DySLRqA24bO1oiJKcVXQ IXLwhEgiIjiaZ2ni64xZvGc5q/Qek3tiaLiIhFV0kTAhVS61xAAQahD7cb+bjOdzu6zW SlXTnqizGzkcunOQHfxLd1IwoyPwYoN2DmoPQK66UL2S8cmRrHsibgTb0cGFzxq+2Zmc KhpoLuHQ+P3CxLs3/bkTfmwNHG8zMn9ANHHt/bQhsxmGyqsS6CXJprwo2AdWyPD/ZzdT 7u4Q==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771571048; x=1772175848; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RWlFRvAAv3Ez0sCmmg14nrvJGE/f1SXTlqum7nZ6ROI=; b=JsWBtpVTmAK0K5/XRSsNK8keD/hnpEBUsopp4rsDuWNvj8sIcJcfMKxwhIhTAYSxJf oXXZZ+UntUlhDB2RlFtjY8e4u8u9V7Qu0nXM9DB0TuMG/WkGoYuogQJREW4k5PLPP4H+ 1bB2j9hTmNpEkBBMK2bKZKAblHAyIZYUQV6blruauiXg9KXGYt0Outjw3TE/gxyqUND4 H2qDuyR4J51+RLgzUO3AKQpyw/kpErsBmjdlWf+GPLVVdwqtkPvdknLCU4Ew/2vrr8ZQ JTjUTC9JG2svnEylEfmFQ5LPsZbqog/gir+ih2U4YCCp9oqQsgGs2kilBilQNytbVul2 jU+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771571048; x=1772175848; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RWlFRvAAv3Ez0sCmmg14nrvJGE/f1SXTlqum7nZ6ROI=; b=d5+YERcX6qLQpYNVG/JDnLhyer6KGqOt7NZE5fKtTgbQokrsKC0347roBHhx9CULNN FW3ao7036/2JZqQCJUNwJ4iiIWeL/NtOEJC+AUTfKAeYithN8KKz589QQxG4DWsietrh FWrlbJsQc8OntFrXUVpxm100o1E3KVKc+NDLHBrJZfmEzRXqeuHJzt/oo0JldLikTPRC NXmlbQhGV+5iYwJAgbRdYsEooaR4GaNsTKQugRDdSDP9QWyCwbtC2J2vG2QhMQDs8WXl gS7FbIGE0yaYnTssTLiC3neDl5eHOZlTQ3imgX3pFD0Wcp/Sc+T51LnftEZh0plgFseZ +bew== X-Forwarded-Encrypted: i=1; AJvYcCW9ccJ2SomhnHR/m7Q//F/+3Rqd77UmKA5kwptzMSt5zWY9wDGkDeVAVXrm2J8/aC46MoN+mIKCw/JE/aQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxmPBflJntw7DLPmMrGHVoIatkFQEkjEZdc5Hpmn5Y426WOBqpg U35MZbDPufqiwoHxO5DsC/UclTunL5bCpQGGuGSC6XQbd4zrAca1tki+kFJM0pmfW4NsJnL4BOx f3RncpcOtvBVNxuaM0Ws7rssGCVVh2QQ= X-Gm-Gg: AZuq6aICF89u+URoXG0XjWO9A9kCwLqfYvOyhlrbb57JDyjCLsEoET4R57q3rQpqCkH LHzRfyGKISiJcxdLv869nA91OflcMbjyCux6sEzv9QpI9cx3/xpVePPTH2X364bCcDBwMB3pBSX PbWGs0Ri/wZlmA8Dol73aS+l4FiFEj6R17o6e/cbIpgx0N/zSDL2k6JLalxfUxUo71mdPdAV+22 ceBFBaDSINNWS4HuTH0MCfB0JUBGKX1ms3CRULUfUjBVCj4C2cLXbvAw1hejLACXnp9Wt5QfLVB O5Srvz6x3Lc= X-Received: by 2002:a05:690c:6013:b0:796:3079:ac1 with SMTP id 00721157ae682-79803af716cmr42124667b3.4.1771571048108; Thu, 19 Feb 2026 23:04:08 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260216161733.7704-1-mariyam.shahid135@gmail.com> In-Reply-To: From: Mariyam Shahid Date: Fri, 20 Feb 2026 12:03:56 +0500 X-Gm-Features: AaiRm524BF0NSUDj1zC0L-3RFD5Ry6nHb-Me0hSIybkyCa8N_Q7tFD1TR1XiUTk Message-ID: Subject: Re: [PATCH] staging: rtl8723bs: use kzalloc_obj() instead of kzalloc() To: Dan Carpenter Cc: Greg Kroah-Hartman , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 19, 2026 at 1:15=E2=80=AFPM Dan Carpenter wrote: > > On Mon, Feb 16, 2026 at 09:17:33PM +0500, Mariyam Shahid wrote: > > Replace kzalloc() using sizeof(*ptr) with kzalloc_obj() to improve > > type safety. kzalloc_obj() ensures that the size allocated matches > > the type of the pointer automatically, which prevents potential > > mismatches if the pointer type is ever refactored. > > > > This change cleans up a checkpatch.pl warning: > > "Prefer kzalloc_obj over kzalloc with sizeof" > > > > Signed-off-by: Mariyam Shahid > > --- > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme.c > > index 22dc36e8e38a..8cb9a760f763 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > > @@ -1954,7 +1954,7 @@ signed int rtw_set_key(struct adapter *adapter, s= truct security_priv *psecurityp > > } > > > > if (enqueue) { > > - pcmd =3D kzalloc(sizeof(*pcmd), GFP_KERNEL); > > + pcmd =3D kzalloc_obj(pcmd, GFP_KERNEL); > > This introduces a bug. It should be kzalloc_obj(*pcmd with an asterisk. > Also there are several other conversions which are possible in this > file... > > regards, > dan carpenter > Thank you for catching that! You're absolutely right. I=E2=80=99ll also go through the rest of the file to address the other possible conversions you mentioned and will send an updated patch (v3). Thanks for your patience as I'm still getting the hang of the process! regards, Mariyam