From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECAFC46467 for ; Mon, 16 Jan 2023 00:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231775AbjAPADU (ORCPT ); Sun, 15 Jan 2023 19:03:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231759AbjAPADS (ORCPT ); Sun, 15 Jan 2023 19:03:18 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9CAD3C04; Sun, 15 Jan 2023 16:03:16 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id t15so28550879ybq.4; Sun, 15 Jan 2023 16:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=utF0T11NIO5fzdSYdTniamVGFsvJmq4s7ZlcItgmdGo=; b=pTclYOItmik5tHCwf8CHR9HEI+jxxHl9DpN6G3hseWDVWz0WKC+e5ZjXrboN34vRfX 33Bav9oBN2rl4ifdPBg9mopNU8+OME5/3vb0EGLRy4hpEnZou3TawUjewrn7VrpwfV2J 8zmskMMVx/wGqDW8xuV8ZN2/DlU3nNlkcoEtd028kFWatiSJr2nUoPcnzr3dUmbAy7Im LsduvSOzVQJoC0UW413NdmK5a5Y6OVmA6G3B8hX79z0EYEtXIJyhHvuZD2ucjwAPqYH2 4mpDd4N8mFQpWipR19rLRubB60j6njQiMVSDDZ4z7WG5TWm1hOYFmKNloonwJK7x8IUY 8dIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=utF0T11NIO5fzdSYdTniamVGFsvJmq4s7ZlcItgmdGo=; b=1ul/SUxbE8GBTR8qXjyKuCwvD1i1V+3gvaF9M4WWhD6jkr70NNk13Bw/k7VvSX0g8f ELW7Z8JhDGcHGy24rq8/slwfZaL4+mmUe9E08qKQfy+3xt8q7gShMbeTD8TlB1pHKbXM u43J7XD2ztDXTP8YdwdxhmHYAktDqEdld4OoamEHpahezBNSg2ADzAE3ejFRFHaRwO0g GHJ02S6Dni72rFkQfeGs2o+GfD7T1m5Q/NzAa7OaJc1meitu1mVavVnJMWhE5rJmH9tc uGXHM4VUgsM4ThvAQTIYda4MiTg19QCfI+Vn+aqrYv+cP/YPe7jZQ6ObhvT+16qIFpvc FwIA== X-Gm-Message-State: AFqh2krkQWLW/zNSP9BFaNPfKqo6E71IWrNHxCbKrQ6xuPBeePlWeCQK mZ9HS84HLsizn0ARcZeG22aXwOIBG2Y5fxsKRbI= X-Google-Smtp-Source: AMrXdXsGXvJ6fgLaVz+5qZXQBdJFCTv3K8NVETV+4FyUgyVMQCuNqGCqmRkc0+hweH28ipKE+hbdONR7DsrMxDekZ6E= X-Received: by 2002:a25:7702:0:b0:7b4:bdd7:e631 with SMTP id s2-20020a257702000000b007b4bdd7e631mr4296168ybc.507.1673827395991; Sun, 15 Jan 2023 16:03:15 -0800 (PST) MIME-Version: 1.0 References: <20230109204912.539790-1-ojeda@kernel.org> In-Reply-To: <20230109204912.539790-1-ojeda@kernel.org> From: Miguel Ojeda Date: Mon, 16 Jan 2023 01:03:05 +0100 Message-ID: Subject: Re: [PATCH] rust: print: avoid evaluating arguments in `pr_*` macros in `unsafe` blocks To: Miguel Ojeda Cc: Wedson Almeida Filho , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Domen Puncer Kugler Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 9, 2023 at 9:49 PM Miguel Ojeda wrote: > > At the moment it is possible to perform unsafe operations in > the arguments of `pr_*` macros since they are evaluated inside > an `unsafe` block: > > let x = &10u32 as *const u32; > pr_info!("{}", *x); > > In other words, this is a soundness issue. > > Fix it so that it requires an explicit `unsafe` block. > > Reported-by: Wedson Almeida Filho > Reported-by: Domen Puncer Kugler > Link: https://github.com/Rust-for-Linux/linux/issues/479 > Signed-off-by: Miguel Ojeda Applied to rust-fixes, thanks all! Cheers, Miguel