From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Onur <work@onurozkan.dev>, viresh.kumar@linaro.org
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, airlied@gmail.com, simona@ffwll.ch,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rafael@kernel.org, gregkh@linuxfoundation.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, davidgow@google.com, nm@ti.com
Subject: Re: [PATCH v3 3/3] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]`
Date: Sat, 28 Jun 2025 14:18:53 +0200 [thread overview]
Message-ID: <CANiq72kY9DA_JD_XkF01ZSmXbD8iaFthVZ66X+9N5aa_WObt+A@mail.gmail.com> (raw)
In-Reply-To: <20250628133013.703461c8@nimda.home>
On Sat, Jun 28, 2025 at 12:30 PM Onur <work@onurozkan.dev> wrote:
>
> It doesn't seem to be the same reason. I rebased over
> c6af9a1191d042839e56abff69e8b0302d117988 (the exact commit where that
> lint was added) but still Clippy did not complain about it on the
> MSRV. So it was either a leftover, or there is a version between
> 1.78 and the current stable where Clippy did complain. I can dig into it
> more during the week if you would like.
Are you sure? The lint is actually disabled, as I mention in 5e7c9b84ad08.
From a quick test, I enabled it in that file, and I get the warning.
Thus it seems to me Clippy would still complain about it just fine.
It doesn't mean we shouldn't remove it, though.
> IMO, we should require people to add a comment explaining the reason
> for adding these lint rules to the codebase. It would make both reading
> and modifying the code much simpler and clearer.
Do you mean using the lint reasons feature? IIRC we discussed at some
point doing that when the feature was added (we enabled it for the
`expect` side of things).
For non-obvious cases or uncommon lints, it would be definitely nice
(a comment is also OK). I am not sure if it is worth enforcing it for
every single case, though.
It would be nice if `clippy::allow_attributes_without_reason` could be
enabled just for `allow`, or ignore it for certain lints.
Cheers,
Miguel
next prev parent reply other threads:[~2025-06-28 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 4:09 [PATCH v3 0/3] replace `allow(...)` lints with `expect(...)` Onur Özkan
2025-06-28 4:09 ` [PATCH v3 1/3] replace `#[allow(...)]` with `#[expect(...)]` Onur Özkan
2025-06-29 7:43 ` kernel test robot
2025-06-28 4:09 ` [PATCH v3 2/3] rust: remove `#[allow(clippy::unnecessary_cast)]` Onur Özkan
2025-06-28 4:09 ` [PATCH v3 3/3] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]` Onur Özkan
2025-06-28 7:13 ` Miguel Ojeda
2025-06-28 10:30 ` Onur
2025-06-28 12:18 ` Miguel Ojeda [this message]
2025-06-28 12:42 ` Onur
2025-06-28 12:51 ` Miguel Ojeda
2025-06-28 13:11 ` Onur
2025-06-28 13:28 ` Miguel Ojeda
2025-06-28 13:42 ` Onur
2025-06-28 14:14 ` Miguel Ojeda
2025-06-28 12:48 ` Onur
2025-06-28 13:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kY9DA_JD_XkF01ZSmXbD8iaFthVZ66X+9N5aa_WObt+A@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=viresh.kumar@linaro.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®