From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FCA23C3BF7 for ; Fri, 17 Jul 2026 11:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.216.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289148; cv=pass; b=SKcFrI7kwxM8Kj+EruIO7tVk9hwScdfiU6o3MglxePNpa7lhbityulx8OioCePwl8kcluJ08t8y7zlYMuWk6MOu1AMtpXrkgVzA2ko0ruJYiPHDmOu8d+5gXgo38JaHPCuH3TX3Ey+93kqvR2VgvgIFXK0/lvDCIX6x579kHmCs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289148; c=relaxed/simple; bh=JXmR/1i3kSXbLKDwpiYQDilxM5OQbH5tXgOwHXzOIyQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=t2+xJGC/QvlDWJG1PYt8Cs7Q2XfrSWKYA0g1uvSVV6XUWLd/oskJF2pWQoE3nFj+lSprgrMCrXnt7B6/J0fIQfNN1YyAXYK8tU6N5aSJ7FEVja1ThGfiFXNZYbG8EF1Uofgr/EPkcrvpuEhNRotOFIutGgg1J9H379aNQEo2mss= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YenaCJAj; arc=pass smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YenaCJAj" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-381f03d7be0so1041740a91.1 for ; Fri, 17 Jul 2026 04:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784289144; cv=none; d=google.com; s=arc-20260327; b=iiRyFa1wvydWWqXaSk98G24WWPzbibjOsuWoev4LwJmtIoSmDnVEJFdRsoYNN88PcB AktzUuoBwKLB9v2MXzXLlXTd9cmuGwpNetUKhgfFaXgETAH1Qv0UDFp1QrtX1y0iEBZX Ja932VdMh8suDcVKnBHh19e1F28Isa2izQ/5kLmGhGkW9r509e62smQH5wS3YaJaTALE gNJl/BmtjBNbZVycW7OAd8HGLZVQww6w7pHgSX/9HfkvqXUk3mynFWL1dk8SC5RGbaYr pzwZvz01uIKcTsZfh1BZcTb6+wUWEi5W5wzvKgtwxosDgzqnZz2La7QOi/5fhXPNL7zp jVxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JXmR/1i3kSXbLKDwpiYQDilxM5OQbH5tXgOwHXzOIyQ=; fh=aUcvqi/RGtGvBkXDXXt6A5l1tGlpDY3VquIQSETBt2k=; b=Gwhb8/OLgu7C9lE6OONExu0TN9VzDrjzxGxMc2LIm4BP6VIQhKvMCl1f2xUfX8l0RW DR7QG7V4Wgfem9ZbK/bkFuoBZV9TRCZH1kzTlCMBPiznbuDP62sJ+w+LDzyorLTGCS8s vTYnfAVBzZfG1v2I1jW8jGdqlQswbq/DQM13S/KMbKuKavZA91dA+/5naVJ4HANKE/D9 vrH77MB5QcG50JDsWAaNaq41jnABh5MyGC5QUraVxZUdTeWuzlXav/EdXJgz6VIhjQPr hz5opQaHWeiz9BW13x2mypsUrz2TtXmqQFveM2fyVcF2gJw3XwkD5SQeAUdpt3VOeOOK ajnQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784289144; x=1784893944; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JXmR/1i3kSXbLKDwpiYQDilxM5OQbH5tXgOwHXzOIyQ=; b=YenaCJAjnnlPZcTGwfOq9oVrjjm13muWS5n3zHEyqI6wK7d5zrhi8SLc+7B4pe9GpT sRMXUA/5faX9cIA83Z4EB7TWq4GBVpcIwTHRk+PoG/0a/lTC28eB8ACgQf/L0r4GvqSZ CteG5qvWsc3WifBZWCxFqjDhbMwVpmUted2gQFEU8+I4T3UoxkEbzGV05aGkEVn3ePuD xS62oLszdkPAzjBpgwRvv3sAYYnjA1FIR0qMLCLLxlegSWDmeXUmoq/DqHdvGizeo4kP auz10m3dBhJShprSvzNGMtd9DEIrlMDbohdi4zVkLKlGu+86Y10y/3a6vxdug+/60mbd 5+ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784289144; x=1784893944; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JXmR/1i3kSXbLKDwpiYQDilxM5OQbH5tXgOwHXzOIyQ=; b=Ec/ygliRXpsZMNuxRIpx6tU05bt/uQ0grhgrGmBIwgNVejyEizbAIuq/GJMs2iM8uo 9DQT6ygQEy4byqkpS/GLW36SRjVARYqCqEI1NvTsradwVrBf3OAzQNqgKeu1LK48rPLa YL7qpTRXkYK900+6i2tH4gUv1SxiJZU3xl4cWtr5UsCuKkejR+VlUT+t9ZpAfEUvVKfC LHk+xgHmcLRy0s71J9LWyiPVi0M8KaVLIvUX/LTWZ1ZNsdr+bnmg5AUIwQ7eOv0YUToF EE32pM6SMpVEJ9dtEFlnCA+elJN3eHvtCt16TViukCpIKxszthLyA/BAq/vsc/KEiUhN w//A== X-Forwarded-Encrypted: i=1; AHgh+RowHQJqMdGP4ny+oDtKlBh/WjI7DPin99RM5qUJN22zeMJdr55miqbFxmL0hMKrEItsxKxeiwWn7iwiZKc=@vger.kernel.org X-Gm-Message-State: AOJu0YzR9SWQjrb8xzky+DM0LJiV2yQoJ3Ig9x7sRT3m+oDyQBMJHo1r G/pzrHFBcTCM00Eb2+5rUR6O1FJZ3cBsDFDqEqsMfevaDpJ6/Pgh11yIpA/ShaQfdv9WVqz8zyo H9cGe+nE5F2gqNO7I3XLBbigUoGUC6/k= X-Gm-Gg: AfdE7cmKzz8tMYChzYclxEPLLlt3Fy/9Q44ypcpSjNVmtJ3Af+6wee7iprnSmCUhKDy mPpYGyzYUKbEujVbCeeVBwLluyJyhW95uhENoY9kRLk3o+R19TlPhjagaipFoS77Hoo9ZWOidOA 3ppziqF4tEEIhvZu6HBvtAQhp9fZm44BMaGuzxArR7pNy1fkseJBwlXN/K0K3+Fqj55Rsm/RWFV PPiP+tgiStLQFygTqWgSZ0q/BpZhGNKHY7pgKlCD+/InMe0gxAH1gq1QRa5IjTbydrq5V9a86th UX94CaeWhGLaOc9H3MMNGImG4A+2ums+9ccIYE8kl3fhrKv+NIo7qENsVSkyysWuHFvRZxUp+dD PuHCZyscEz0Js X-Received: by 2002:a17:90b:134d:b0:37f:e7e7:ad1 with SMTP id 98e67ed59e1d1-38e4b697024mr1934548a91.5.1784289144013; Fri, 17 Jul 2026 04:52:24 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260717-docs-printk-rustdoc-link-v1-1-892074948f75@younes.io> In-Reply-To: <20260717-docs-printk-rustdoc-link-v1-1-892074948f75@younes.io> From: Miguel Ojeda Date: Fri, 17 Jul 2026 13:52:10 +0200 X-Gm-Features: AUfX_mzLJVaiRBHZIOgftXl-H_dUUA_uHSHWfhmPBqD8U08fGAaLcUtm3GZ6mD0 Message-ID: Subject: Re: [PATCH] rust: print: fix broken `_printk` Rustdoc link To: git@younes.io Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 17, 2026 at 1:44=E2=80=AFPM Younes Akhouayri via B4 Relay wrote: > > From: Younes Akhouayri > > The Rustdoc link for `_printk` points to `include/linux/_printk.h`, > which does not exist. Point it to `include/linux/printk.h`, where > `_printk` is declared. > > Fixes: 247b365dc8dc ("rust: add `kernel` crate") > Signed-off-by: Younes Akhouayri Looks good to me, thanks for reporting it and fixing it! Link: https://github.com/Rust-for-Linux/linux/issues/1246 (Normally it would be Closes:, but there are two issues in the same one, so we use Link: for that instead.) Finally, given it is `doc(hidden)`, I will skip Cc: stable@ -- if the stable team auto-selects it, it is fine. Cheers, Miguel