mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Sagar Taunk <sagartaunk2@gmail.com>
Cc: ojeda@kernel.org, aliceryhl@google.com, bjorn3_gh@protonmail.com,
	 boqun@kernel.org, gary@garyguo.net, lossin@kernel.org,
	a.hindborg@kernel.org,  tmgross@umich.edu, dakr@kernel.org,
	contact@onurozkan.dev,  rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org,  stable@vger.kernel.org
Subject: Re: [PATCH v2] rust: workqueue: fix SAFETY comment Arc refs in Pin<KBox<T>>
Date: Sun, 26 Apr 2026 19:56:50 +0200	[thread overview]
Message-ID: <CANiq72n2eoHnU++GyXRb0bbXXXU_3W=yjkJ0Yi54O2Q1oprNOg@mail.gmail.com> (raw)
In-Reply-To: <20260426175317.10171-1-sagartaunk2@gmail.com>

On Sun, Apr 26, 2026 at 7:53 PM Sagar Taunk <sagartaunk2@gmail.com> wrote:
>
> The `WorkItemPointer` implementation for `Pin<KBox<T>>` contained SAFETY
> comments that incorrectly referenced `Arc::into_raw` instead of
> `KBox::into_raw`. This implementation uses `KBox`, not `Arc`, so update
> the comments to accurately reflect the actual ownership transfer.
>
> Fixes: 8373147ce496 ("rust: treewide: switch to our kernel `Box` type")
> Cc: stable@vger.kernel.org
> Suggested-by: Onur Özkan <contact@onurozkan.dev>
> Link: https://github.com/Rust-for-Linux/linux/issues/1233
> Signed-off-by: Sagar Taunk <sagartaunk2@gmail.com>

I should have mentioned that, in the case of making it a fix, one
usually uses Reported-by: and Closes: instead of Suggested-by: and
Link:

No need for v3 for that I would say -- the maintainers may fix this on apply :)

Thanks!

Cheers,
Miguel

      reply	other threads:[~2026-04-26 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 17:53 Sagar Taunk
2026-04-26 17:56 ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72n2eoHnU++GyXRb0bbXXXU_3W=yjkJ0Yi54O2Q1oprNOg@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=contact@onurozkan.dev \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sagartaunk2@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®