From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: Peter Xu <peterx@redhat.com>, Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
David Alan Gilbert <dgilbert@redhat.com>,
Greg Thelen <gthelen@google.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable
Date: Thu, 3 Dec 2020 01:09:11 +0100 [thread overview]
Message-ID: <CANiq72no05JF9Ah__BAcL+Csn5K3_MWYo7Y4TfDmgL+8fvc74Q@mail.gmail.com> (raw)
In-Reply-To: <CAJHvVch2LJa57-Si2prKa-S3VUPpu3jYxW+3-+tcLMgSXkB69w@mail.gmail.com>
On Thu, Dec 3, 2020 at 12:55 AM Axel Rasmussen <axelrasmussen@google.com> wrote:
>
> This is what clang-format yields. Are you thinking it would be better
> to line everything up with the ( in uffd_error( ?
Yeah, sometimes clang-format cannot do a good job with the 80 column
limit + 8 tabs.
You are definitely not forced to follow clang-format output by any
means. Subsystem maintainers decide what style they prefer anyway,
which could range from a manual approach to following clang-format
strictly. Clang-format implements the general kernel style as closely
as we could get it so far (it will improve more in the future when we
raise the minimum clang-format version required). See
Doc/process/clang-format.rst.
> Or, perhaps this case is a good reason to make uffd_error() a variadic
> macro so we can insert "-EEXIST" || "error" with a "%s".
...and indeed, sometimes it is a hint that simplifying things could help :-)
Cheers,
Miguel
next prev parent reply other threads:[~2020-12-03 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 21:15 Axel Rasmussen
2020-12-02 23:09 ` Peter Xu
2020-12-02 23:52 ` Axel Rasmussen
2020-12-03 0:09 ` Miguel Ojeda [this message]
2020-12-03 1:32 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72no05JF9Ah__BAcL+Csn5K3_MWYo7Y4TfDmgL+8fvc74Q@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=dgilbert@redhat.com \
--cc=gthelen@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®