From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbdLDPpf (ORCPT ); Mon, 4 Dec 2017 10:45:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:34812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbdLDPpc (ORCPT ); Mon, 4 Dec 2017 10:45:32 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0099E218C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org X-Google-Smtp-Source: AGs4zMbEepa5oA6LJVn4czl3Oxm9+cGDVLcC+bZNIjFqceNN4bU9rEFN8+hTY1BBNPMic8r39x099LC0KxctnQcmCms= MIME-Version: 1.0 In-Reply-To: <20171202012108.x5js74t73f3wkpem@derp-derp.lan> References: <1512159984-23948-1-git-send-email-khoroshilov@ispras.ru> <20171202012108.x5js74t73f3wkpem@derp-derp.lan> From: Alan Tull Date: Mon, 4 Dec 2017 09:44:50 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe() To: Moritz Fischer Cc: Alexey Khoroshilov , linux-fpga@vger.kernel.org, linux-kernel , ldv-project@linuxtesting.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 1, 2017 at 7:21 PM, Moritz Fischer wrote: Hi Alexey, Thanks for the fix! Alan > Hi Alexey, > > On Fri, Dec 01, 2017 at 11:26:24PM +0300, Alexey Khoroshilov wrote: >> If fpga_mgr_register() fails, a clock is left undisabled. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov > Reviewed-by: Moritz Fischer Acked-by: Alan Tull >> --- >> drivers/fpga/socfpga-a10.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/fpga/socfpga-a10.c b/drivers/fpga/socfpga-a10.c >> index f8770af0f6b5..a46e343a5b72 100644 >> --- a/drivers/fpga/socfpga-a10.c >> +++ b/drivers/fpga/socfpga-a10.c >> @@ -519,8 +519,14 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev) >> return -EBUSY; >> } >> >> - return fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager", >> + ret = fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager", >> &socfpga_a10_fpga_mgr_ops, priv); >> + if (ret) { >> + clk_disable_unprepare(priv->clk); >> + return ret; >> + } >> + >> + return 0; >> } >> >> static int socfpga_a10_fpga_remove(struct platform_device *pdev) >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks for your patch, > > Moritz