mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "luwei (O)" <luwei32@huawei.com>
Cc: Pavel Emelyanov <ovzxemul@gmail.com>,
	"Denis V. Lunev" <den@virtuozzo.com>,
	davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, avagin@gmail.com,
	Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Subject: Re: [PATCH net] tcp: reset tp->sacked_out when sack is enabled
Date: Thu, 27 Oct 2022 05:04:54 -0700	[thread overview]
Message-ID: <CANn89iJ1JVG_H-FAQRg3JdPtNkq2T++K9Xc-mLo_VaUdcp38KA@mail.gmail.com> (raw)
In-Reply-To: <8083c822-1493-3596-d292-520fb16b113f@huawei.com>

On Thu, Oct 27, 2022 at 5:00 AM luwei (O) <luwei32@huawei.com> wrote:
>

>
> thanks, I will send next version

Yeah, what about first agreeing on what the plans are ?

In order to avoid confusion and lkml/netdev bloat, I think you should
describe why existing checks are not enough.

Since this was probably caught by a fuzzer like syzbot, do you have a repro ?

      parent reply	other threads:[~2022-10-27 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:15 Lu Wei
2022-10-26 14:30 ` Eric Dumazet
2022-10-26 14:33   ` Eric Dumazet
2022-10-26 18:59     ` Denis V. Lunev
2022-10-26 19:59       ` Eric Dumazet
     [not found]       ` <CA+XRDbMma1e26HHoYm2pExANACH8n83bE7vB_Gwh3-RZUsOe2g@mail.gmail.com>
     [not found]         ` <8083c822-1493-3596-d292-520fb16b113f@huawei.com>
2022-10-27 12:04           ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANn89iJ1JVG_H-FAQRg3JdPtNkq2T++K9Xc-mLo_VaUdcp38KA@mail.gmail.com \
    --to=edumazet@google.com \
    --cc=avagin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=den@virtuozzo.com \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luwei32@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=ovzxemul@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=ptikhomirov@virtuozzo.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®