From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A744D3C1991 for ; Tue, 20 Jan 2026 09:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.160.178 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900585; cv=pass; b=hIxkTDY8vLGAQlzzFvV1MCJx7o/W1rq4RRLO17XvC5Lc22IZA3lGvcp238bFL+A4vX911Cntvr8GisC4BB3sncFuY9uvvbGTm3XT/kh8COfV7Dl7UUASMQ1pAUVp0qAY4E6oj7On4yanu2imQW/MIhYFZNgSQxQYvc0DS//j88Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900585; c=relaxed/simple; bh=1e0bMPi/PzQXuk4VAcA2Nyb3zMszpJ/QFxMkSUZhgFw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=C4mhBCB8gkelc0Y/YDZtlSoGkcCPcqwk7yRSQQlJnDJ4axA4qHTUjr4QlbJ9Xs1z4r6xQUkCUJQoCB+l1E5uD6Gyt2N5eL4mh+/X4750lefgXfIOz3PNeX7Il9HpXWjfb8moenp8L+I2ew4kfjO1j1pFfGaJU1nLxUy0xtc/ZFg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ncChF4ZD; arc=pass smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ncChF4ZD" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-502b698e510so25423551cf.0 for ; Tue, 20 Jan 2026 01:16:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768900582; cv=none; d=google.com; s=arc-20240605; b=iqWPH3Z9UklFyM4YpELxFoYOj/8K8b3xnWHf4R9vHr6OHo4U3b27pbbpF9dM9/1GWJ voRVmWomeggHGuebCWQvKF+NxMYb5LxAMnXA0tAX4cbD4CNH4ioYyipA6OipJkMpzwn0 oPN3/elEbMNLrAxRb6XgqaisHOQp0SOnxgHRO+cyHuKkS544fGkVsMosZHYvEpg7+6JF RWtYu6Vk61PVd9zfTTFOkBYEZgyYJ2M2B6FLGzP2cgKbSogoLCTK6JS7pBbOgDbvlH1m kimB6CTK0hqL+neOrZL6iLf+Hv/acVnrZZWy0fh/ASrTQwXUgCpA4v4vuKR5UwkemDHA OTLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MbiblkWaTr/bMxXaQMWUkJ4gf+BwLKoS3ILjCMJIJGM=; fh=OaseNo1v4W1wtc2UpV+denLwbVErtaaAhb3iXcdZ/uM=; b=DUgbU0zxUAJlkK2sgWMMm/1ot3uqp+dc+kQpRT+4y8hHL2VxvTSdlw9w0y/jckPboV zl8cfHG3vz8sHpXpgVWZUl/XEw8u58ri8yJbNsf7Wo5rX/URytTfOHu/QBBYVL0mHzYp MK9E7D9oxjHXmax9PqJZkd0dSF7zXaWpd10K/3BHuz/qiHSmQCn6+ASP2FkXw/oEkwcL pdqSojIb2NqTq15/htTrYHXOwA8rcxGWhhi2tYOIRmoitJ98ljD2Sbh+gocJMxdM+xzP Zqgf1nQOtRsp9t14Gfqa++PDNZVHdQ0PLkn7vO2OgvgMFsYShE6wUt3iIrlmgveMcgU6 uasQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768900582; x=1769505382; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MbiblkWaTr/bMxXaQMWUkJ4gf+BwLKoS3ILjCMJIJGM=; b=ncChF4ZDjQVBS5E8jf4RhGavZlFzVIRJEdAewIscmfmg/yA/JQplXhvYPkUCttsNtt SC8LhkFGiFLQPOdfHT42wUG34l5UacJ6pj7ruSLaMZjL2SbWdOe3sZ9oKmOwqFzEr7hD zjP3h1ekccctXh+bnb9KgHbcg4KEk/hfH/g2LZHy4qiriNNZUx2Y6d8BwVrnNiKU5VJ9 hcx5bq8v+9er2dwy1r8Eyos4UwRNGe6q8jcwC7cl/MzGgnE4xpEP6Jf3f7v06yxbpjrT cMbKQ3ROyVx5gXclFhVBwRJCHuZ8mgmcDp/VejvtlrlW90bNzPVb4G0UuhAKhkxJWAbb qKRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900582; x=1769505382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MbiblkWaTr/bMxXaQMWUkJ4gf+BwLKoS3ILjCMJIJGM=; b=Hu9c38Rs0niGPN79Qx/3Jve3J2PHqMzLU0cVEIcSKIc9t+3rW3CML8nuZFHaRVejBH jCEQ6XzwltIYg4IyexTdFEzEqc28vPVz3T9AfLXBO7BJG65v4OFCu1wR6FgiEteE8+xj 6WLtdgOOYvblIKCl3CGKGqLRXttlc5/zHEUkULI74umo5ESECyv4BhOVslPZzpFlRK2e tVaeKIGWK1QXn5bdznecHi2l9cUBTywzT2bphdVr7eWv1oV4fd/5gzhPeJx5LHC4YK44 FwYnhahMbo/k9upEjKXXP4FUzEgkio2A4s/n4D7sr7qq6r4AxxZ3haGGuZgQ6YUWZDRN WxgA== X-Gm-Message-State: AOJu0YyeZBMsLIYAHiziH0+oqwRdz/ft/jqHhAahmC48ZBzsrlZnMm9i R0glruW7pgNAecWE4yMw/qV4xm3Wye8ZDlJBhmT74Hy8vdBMto5gGN7bSYQfMiYNvGu1RaH5rPH NP526tPkxcmP+OatA0GS7nNTrb9Vh6TI0BxZGM9aiA9SnGay9HytfKvap X-Gm-Gg: AY/fxX5LTYLquW7twQB/kar88PKFtuow/rk9zpvCq4lH7Dh8meQ98vUtQlTXLfZ6rEL ucbVpojzVj11e69yDF8TZpCu/mgYsOxQsVpww/0juPtZKSluQUjljQI+bzXKQmCc5JdQqBkZdzt HEoZHO4IhQDJj/ThPVeIAoE9wbPVZtJ6MLqctzKneXvcg/yF4b7vVVZiFDhA24ttEu5YW3KL+Id HtAonf8+JMRZ/sSCSMjw3rzJnliwEUu5lubotyWKVNtvIh/gfNR0tOUrd4/7MU4VTWGG8A= X-Received: by 2002:ac8:5e11:0:b0:502:9fe5:a36f with SMTP id d75a77b69052e-502a1e1b78cmr195466261cf.11.1768900582052; Tue, 20 Jan 2026 01:16:22 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251223052026.4141498-1-edumazet@google.com> In-Reply-To: <20251223052026.4141498-1-edumazet@google.com> From: Eric Dumazet Date: Tue, 20 Jan 2026 10:16:11 +0100 X-Gm-Features: AZwV_QgG4QDYh-x0bzE0c7ZA7wT0-X3Eb8u46cIk-5c0sLeXDo5_FL7r9zbdjJQ Message-ID: Subject: Re: [PATCH v2] x86/apic: Inline __x2apic_send_IPI_dest() To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" Cc: linux-kernel , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2025 at 6:20=E2=80=AFAM Eric Dumazet = wrote: > > Avoid one call/ret in networking RPS/RFS fast path, with no space cost. > > scripts/bloat-o-meter -t vmlinux.before vmlinux.after > add/remove: 0/2 grow/shrink: 2/0 up/down: 96/-97 (-1) > Function old new delta > x2apic_send_IPI 146 198 +52 > __x2apic_send_IPI_mask 326 370 +44 > __pfx___x2apic_send_IPI_dest 16 - -16 > __x2apic_send_IPI_dest 81 - -81 > Total: Before=3D20861234, After=3D20861233, chg -0.00% > > Signed-off-by: Eric Dumazet > --- > v2: added CONFIG_X86_X2APIC dependency (kernel test robot), updated bloat= -o-meter > v1: https://lore.kernel.org/lkml/CANn89iJ4r5hrqE=3DLj16XVNFM7iZ+XB+JsXU8g= E5ryeuG6kf1Sg@mail.gmail.com/T/#mc7288459ec504831a9888cb0e5c4dbdae253f263 > > arch/x86/kernel/apic/local.h | 10 +++++++++- > arch/x86/kernel/apic/x2apic_phys.c | 6 ------ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kernel/apic/local.h b/arch/x86/kernel/apic/local.h > index bdcf609eb283..0e5dd6772d6a 100644 > --- a/arch/x86/kernel/apic/local.h > +++ b/arch/x86/kernel/apic/local.h > @@ -14,7 +14,6 @@ > #include > > /* X2APIC */ > -void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned in= t dest); > u32 x2apic_get_apic_id(u32 id); > > void x2apic_send_IPI_all(int vector); > @@ -42,6 +41,15 @@ static inline unsigned int __prepare_ICR(unsigned int = shortcut, int vector, > return icr; > } > > +#ifdef CONFIG_X86_X2APIC > +static inline void __x2apic_send_IPI_dest(unsigned int apicid, int vecto= r, > + unsigned int dest) > +{ > + unsigned long cfg =3D __prepare_ICR(0, vector, dest); > + native_x2apic_icr_write(cfg, apicid); > +} > +#endif > + > void default_init_apic_ldr(void); > > void apic_mem_wait_icr_idle(void); > diff --git a/arch/x86/kernel/apic/x2apic_phys.c b/arch/x86/kernel/apic/x2= apic_phys.c > index 12d4c35547a6..10f79026e8e3 100644 > --- a/arch/x86/kernel/apic/x2apic_phys.c > +++ b/arch/x86/kernel/apic/x2apic_phys.c > @@ -107,12 +107,6 @@ void x2apic_send_IPI_self(int vector) > apic_write(APIC_SELF_IPI, vector); > } > > -void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned in= t dest) > -{ > - unsigned long cfg =3D __prepare_ICR(0, vector, dest); > - native_x2apic_icr_write(cfg, apicid); > -} > - > static int x2apic_phys_probe(void) > { > if (!x2apic_mode) > -- > 2.52.0.351.gbe84eed79e-goog > I do not think I received any feedback for this patch, should I resend it ? Thanks.