From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDE21B392B for ; Fri, 7 Mar 2025 10:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741343330; cv=none; b=uqinuOVtPMPMDutTyY5TrL77cdqpQlRaLUlwfNm41DbK8fYiUwMbZM0dMWx36Lm82xq4vK40/ypawzdA7YiZ2/QpPrdSsGScZkUs1WW6+BdpJMG5IUkIyE7xGgREUg2ov9lg+z5iV5Jg6omm6f5j0NGPjx+fvUDZ0O9U8op2DKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741343330; c=relaxed/simple; bh=lpz8W+/JwmlAFUO/QFcs0PO4HoUi4STm2Upsn1W5Eas=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uwPH9trk1m+iSGeeAVYiTERwXRFCSjJs7RcIPhq8PdAjimTY4m988Eoixz/qFfCYo0ti9BYHRYSkDMI5by25mRouwjhSoXTB9Wl0omrLLvX8YpgKW8DL5jOoN6QnufGy3wE+SlGC39zWZFYCKavjpfJ9mOUk3QdqCf3+SLuywGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ANWlpoQe; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ANWlpoQe" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-475162ce281so14620051cf.1 for ; Fri, 07 Mar 2025 02:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741343327; x=1741948127; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T1cIrBe7Ura9LTOFC9H3HdVhePICrfHd60ZZ0KZtTWU=; b=ANWlpoQeYcLYjAANB+qzRZSqOd+Pbch5Ex/EIukKQPpkdIYw2POxrInaazQin4h75c fwVi716z/mKZa56D9+N1hz/MKY73MziJxDO+WdfNrFHLnjfFoOAplTaXLvu28xz/kHuQ lnT/HN7BLOKGVae607ttdDUVDjUCwvghtCLd5QKA8JOmC0uv6fDNuWcCwDEyRYMc/8EE jo9eXRldLR4TVaT/oH2W6BfKkeQWyQPCm+NG1YhOvsufJYePeFD+X4uiPzwjRJ90Xo5v CiSGSsqdg73aRgrwFWijieuyAlvuSqxZGQMTvJS+JZIBKbI0Zb+SP76ZqtE2dfE59hTU cdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741343327; x=1741948127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T1cIrBe7Ura9LTOFC9H3HdVhePICrfHd60ZZ0KZtTWU=; b=Q0NXCBkePY42rTnvXfJv1tFvPdwSidqkd8h9/NVvpYXvREam9YpssYU62DReOI52Fm r/Fw8bw6MNSWH1fuDYVS4D+YNzdkHoycklF5KJ2uCDFOQTcyBZxuKldxvbWSW3HSOv/P DsI4kF+QVCYEz8qzBYCCeKnbX9gmoKIbPg91J2yt6Ch34SAvmtagnvlEG+gE9nh4wsw0 DIlqSon30ugkaF1HGUkqn9qS8IR5L1Qalcrr8wuLGd7SxJbKGWQGg2n2HvLgDNTYIbwr 7MO5ycSY2R6KPZiRZAjeVhi4TFuvkeAH2q5Elzol9sXJlt+CFV8RuD3uCIfxaeQL85YQ KsgQ== X-Forwarded-Encrypted: i=1; AJvYcCUhRZDQN7kpl/P2lZZvoYg/dBnEtMxWFuW1g2JM8u2KcWlUFFF9/7IKiBK1ZieXGccyYKq87aeCnyVi+yE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4xw+RYPgsxMusrSXSHrVEVD5pfRz2pJix0uMq+F8rhm8Tc2uR qC5LTmlp+e5uDVD3Nw2yWc6YL25jldqeKuKlCJYwU5ATxtFqEJP9lDAgHs8A14S86kCSgAEd6ga oJOQ7GljpZA8LXsfqt0Xw6rwgi4ndhgFzHnAO X-Gm-Gg: ASbGncsOlJo8ot0m4JINQk9Jag6PkLfPmfSMXOlmQtH/vY7UcOQpksyHbYU7aiNGQkS 0m0vwBYSHEl0AIpVg1+RlMgECM0M83x2XvfkbxW2q7/bSv2W4gFwyBG5ZUT1bqU/Th1Y7OMkfQP X/+Ph0faaKUqoIqk9Dbu4+LIXeLkk= X-Google-Smtp-Source: AGHT+IE8nkI+68Qgy6NjKoLj8c3bNZ3NiejGqaGqUFj0R2IzQEXjAp1CYnixCzSBxrmxoIGwPlxGnmpYBlgSoMnz/mk= X-Received: by 2002:ac8:5f96:0:b0:474:f1a6:c917 with SMTP id d75a77b69052e-47610976675mr39528601cf.4.1741343327418; Fri, 07 Mar 2025 02:28:47 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250305162132.1106080-1-aleksander.lobakin@intel.com> <20250305162132.1106080-8-aleksander.lobakin@intel.com> In-Reply-To: <20250305162132.1106080-8-aleksander.lobakin@intel.com> From: Eric Dumazet Date: Fri, 7 Mar 2025 11:28:36 +0100 X-Gm-Features: AQ5f1Joxdy5jdJHG0g5b6zsYWVs36X3IvHqKfWtxWUE390Z99JJhbzv1OtAO1TI Message-ID: Subject: Re: [PATCH net-next 07/16] idpf: link NAPIs to queues To: Alexander Lobakin Cc: intel-wired-lan@lists.osuosl.org, Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Simon Horman , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 5, 2025 at 5:22=E2=80=AFPM Alexander Lobakin wrote: > > Add the missing linking of NAPIs to netdev queues when enabling > interrupt vectors in order to support NAPI configuration and > interfaces requiring get_rx_queue()->napi to be set (like XSk > busy polling). > > Signed-off-by: Alexander Lobakin > --- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 30 +++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/et= hernet/intel/idpf/idpf_txrx.c > index 2f221c0abad8..a3f6e8cff7a0 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > @@ -3560,8 +3560,11 @@ void idpf_vport_intr_rel(struct idpf_vport *vport) > static void idpf_vport_intr_rel_irq(struct idpf_vport *vport) > { > struct idpf_adapter *adapter =3D vport->adapter; > + bool unlock; > int vector; > > + unlock =3D rtnl_trylock(); This is probably not what you want here ? If another thread is holding RTNL, then rtnl_ttrylock() will not add any protection.