From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB1AC77B7D for ; Fri, 21 Apr 2023 14:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232026AbjDUOZB (ORCPT ); Fri, 21 Apr 2023 10:25:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232555AbjDUOY7 (ORCPT ); Fri, 21 Apr 2023 10:24:59 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D7671705 for ; Fri, 21 Apr 2023 07:24:58 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-329577952c5so693945ab.1 for ; Fri, 21 Apr 2023 07:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682087098; x=1684679098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fev/HjWH2B8yyfQiDGZ9D/O2oZYyJ9gGuApag0ZRVwc=; b=TVGpX8Rsft5hzMr9h6Hwyheu0HJYGuHxxs7ojc6Kil4QcUiO/DlWT0in/uLxRo6Cjj k1VQcRlDqVO4SIIb5IVwDa4JdfL4zYLvXGhLV/kB+NM5PH/u+XjBKfnkjEQ9QVQmK60w Vc8FzK6DfY5mi2TbK4uHxCC49bYsU4nxKZJdASBm+oks7LbQ+RxB90HBUI6mYlegxr7U 1XR6A+LHNGRyTDAhBVssIxGbpCl6otjWPglcnEPEXNFs1XXpb+XtVA4I/tlXGMqxR+pq 8D4T4nbhmC3rl/qw+IT0JwOuDIGlL0G4YOWFtTiFq80UoDYKM6UOS6EJnHjngA/3Jjn6 mLOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682087098; x=1684679098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fev/HjWH2B8yyfQiDGZ9D/O2oZYyJ9gGuApag0ZRVwc=; b=XpP08QL+bEjaYoG42dyaog7OfGLsqCRt/gf8Fff58+AfeRgweuq/Tb6VGGsvzqfZxt 6dt7qkrYPoI66bn+5ysQ/G8jKMjIJc+fcW7UppwNCyaxBhtnGDVLldbOqzg6P01CS6ZB Ii1BFcWXPceXzHTCVBwh0wjHvDDiep2eWQlSsnzjHrJfLBp4LRN4bqw+Aad4+818oRQb Jta4NqjTlZBLYHoyEuw0w2E+65/vxip4LpH17IVNFhcS73RL/fwNFl0FPj/VPNpm54ix F/uZAy/gO2VHCo251jJo+ceslUvhgAUTPUQGldZtpNRp/pK6l3wbI+TA9qApmEApZZC1 HLzw== X-Gm-Message-State: AAQBX9dXLE42kNFRxhKh5emGZdU07SUdTXBCGy2f5b/vz4csSLdokP+j wTmeiS6p/DNhAEmtzIYgoZ7knfTP7lPX/+JDFtEAiA== X-Google-Smtp-Source: AKy350Z0juoPECKlzKlGMdUfKVumXOK21XHMESzNTTUc7EvrFvimwX3M8kvTGyloRw/nYChUw0o5sGJI99iK2oqYk/g= X-Received: by 2002:a05:6e02:1a22:b0:32a:b8fd:19be with SMTP id g2-20020a056e021a2200b0032ab8fd19bemr279553ile.18.1682087097600; Fri, 21 Apr 2023 07:24:57 -0700 (PDT) MIME-Version: 1.0 References: <20230224-track_gt-v7-0-11f08358c1ec@intel.com> <20230224-track_gt-v7-1-11f08358c1ec@intel.com> In-Reply-To: <20230224-track_gt-v7-1-11f08358c1ec@intel.com> From: Eric Dumazet Date: Fri, 21 Apr 2023 16:24:43 +0200 Message-ID: Subject: Re: [PATCH v7 1/7] lib/ref_tracker: add unlocked leak print helper To: Andrzej Hajda Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Chris Wilson , netdev@vger.kernel.org, Jakub Kicinski , Dmitry Vyukov , "David S. Miller" , Andi Shyti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 1:35=E2=80=AFPM Andrzej Hajda wrote: > > To have reliable detection of leaks, caller must be able to check under t= he same > lock both: tracked counter and the leaks. dir.lock is natural candidate f= or such > lock and unlocked print helper can be called with this lock taken. > As a bonus we can reuse this helper in ref_tracker_dir_exit. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Andi Shyti > --- SGTM, thanks. Reviewed-by: Eric Dumazet