From: Eric Dumazet <edumazet@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Mel Gorman <mgorman@techsingularity.net>,
Willem de Bruijn <willemb@google.com>,
Florian Westphal <fw@strlen.de>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4] net/skbuff: don't waste memory reserves
Date: Fri, 19 Apr 2019 09:27:52 -0700 [thread overview]
Message-ID: <CANn89iLSnEtCiqQbPkQXLwkvebd_PPCLJsH2tbwp7Py99FS2UA@mail.gmail.com> (raw)
In-Reply-To: <6651d0b9-4ddf-ef6d-6f53-e1290b7aeeee@virtuozzo.com>
On Fri, Apr 19, 2019 at 9:24 AM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>
> But why that failed allocation is such a problem?
>
> 1. sk_memalloc_socks() false
> 2. NIC driver tries to allocate pages and fails
The NIC then is unable to receive any frames.
We need to be able to populate the RX ring buffer, before NIC can
actually be started.
Basically you are saying : We need to allocate memory only _after_
frame has been received by the NIC.
I am saying : We need to allocate memory so that the NIC can put a
future frame in it.
prev parent reply other threads:[~2019-04-19 18:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 18:05 Andrey Ryabinin
2019-04-18 18:05 ` [PATCH 2/4] net/skbuff: warn if kmalloc_reserve() fails to allocate memory Andrey Ryabinin
2019-04-18 18:05 ` [PATCH 3/4] net/skbuff: remove unused skb_propagate_pfmemalloc() Andrey Ryabinin
2019-04-18 18:05 ` [PATCH 4/4] net/skbuff: kmalloc_reserve(): remove unused argument Andrey Ryabinin
2019-04-18 18:55 ` [PATCH 1/4] net/skbuff: don't waste memory reserves Eric Dumazet
2019-04-18 18:56 ` David Miller
2019-04-19 13:17 ` Andrey Ryabinin
2019-04-19 13:36 ` Eric Dumazet
2019-04-19 13:41 ` Eric Dumazet
2019-04-19 16:25 ` Andrey Ryabinin
2019-04-19 16:27 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLSnEtCiqQbPkQXLwkvebd_PPCLJsH2tbwp7Py99FS2UA@mail.gmail.com \
--to=edumazet@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®