From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12710C433ED for ; Wed, 5 May 2021 17:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEB0561166 for ; Wed, 5 May 2021 17:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235076AbhEER6i (ORCPT ); Wed, 5 May 2021 13:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234274AbhEER6O (ORCPT ); Wed, 5 May 2021 13:58:14 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C4E0C00F602 for ; Wed, 5 May 2021 10:28:57 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id c36-20020a05683034a4b02902a5b84b1d12so2399032otu.8 for ; Wed, 05 May 2021 10:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g4X2E1XRo1phsTQg3EtaDOCHvhUj1Tt6jnzKJ2/36r4=; b=Ci17lKNM6SGVNOqaBWBsKIWTYwwHJkNl1mRsigIQBzQUV+Fe7R1iEbp4p0Gi7GvMLt vpPFAF3pJjstdTj6jq3muVEeH8qUqVxVmGHZr24Pb3bnvcBdv12/sd389ZxY9jRAjLyh A5ziYDkfBaYnFip5b0Ud/+WFd/dJgrQJUN3KTfYLrHwlQZulsdUg0gPk3ej58DmJG9na 6hzzjTzYsHRPDwgh/yQZUFTqLpQJJ7OtdlA6gz0OP37sYrKUJc7epGDksRCP9QDukzY1 OKOgnsm2Bu0EUuSj/f0d3dCe6+8/dv21IaF7lQa6r8eIHy6VgML1pohdp9Zq326OyzGi 4lgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g4X2E1XRo1phsTQg3EtaDOCHvhUj1Tt6jnzKJ2/36r4=; b=FMpLm2dWddeEf052Tne4pCH4YXe6vd9uB/A6hXq+kKuBq1KV3btwnHY3lUob4cmlD4 mcIOB7ABe5Fvl2SThS3zY88rWTSRiw5KxX5ABamvIdIZANjLbLcE9RQwZajxXauzhWov 7Lp+NfPanlEbKT9wnDG0NL7HQhvXl+esqsHJVo2/0oKnn22xM3H0Hro96dC0erHk7JB1 EeWMgNXgCxxcSGnwOTXG7EBpnJPygPlDcEzfg+g1nPwmob3i3eFJyOY5RzhidYuHEH+k oS0Ge+sMBP1/pK4+1jo9yDld1FItl6D0s/FTyhJILVZdE1ZVQYkDu9B2Px6CbYUPuhg3 Emng== X-Gm-Message-State: AOAM533inX65ciYk5/O7YPNa2QSsx/jxYBN5093aQlX5nXn5EsRF2yRz Z+7FJQuyZakYECt+ZdyfHnqvvOpiIlHb2HnjhOlS6w== X-Google-Smtp-Source: ABdhPJzCrgcsmVZ17vp3OnrajNVg5oiT8XHdZ69sPTTuAVz+vJkCkBYQQwz+3urgaEY63+KWW5G2D2SF2vbGhXDm6yU= X-Received: by 2002:a9d:60c8:: with SMTP id b8mr24974375otk.17.1620235736198; Wed, 05 May 2021 10:28:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Wed, 5 May 2021 19:28:00 +0200 Message-ID: Subject: Re: [PATCH v3 00/12] signal: sort out si_trapno and si_perf To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 May 2021 at 23:13, Eric W. Biederman wrote: > This set of changes sorts out the ABI issues with SIGTRAP TRAP_PERF, and > hopefully will can get merged before any userspace code starts using the > new ABI. > > The big ideas are: > - Placing the asserts first to prevent unexpected ABI changes > - si_trapno becomming ordinary fault subfield. > - struct signalfd_siginfo is almost full > > This set of changes starts out with Marco's static_assert changes and > additional one of my own that enforces the fact that the alignment of > siginfo_t is also part of the ABI. Together these build time > checks verify there are no unexpected ABI changes in the changes > that follow. > > The field si_trapno is changed to become an ordinary extension of the > _sigfault member of siginfo. > > The code is refactored a bit and then si_perf_type is added along side > si_perf_data in the _perf subfield of _sigfault of siginfo_t. > > Finally the signalfd_siginfo fields are removed as they appear to be > filling up the structure without userspace actually being able to use > them. > > v2: https://lkml.kernel.org/r/m14kfjh8et.fsf_-_@fess.ebiederm.org > v1: https://lkml.kernel.org/r/m1zgxfs7zq.fsf_-_@fess.ebiederm.org > > Eric W. Biederman (9): > signal: Verify the alignment and size of siginfo_t > siginfo: Move si_trapno inside the union inside _si_fault > signal: Implement SIL_FAULT_TRAPNO > signal: Use dedicated helpers to send signals with si_trapno set > signal: Remove __ARCH_SI_TRAPNO > signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency > signal: Factor force_sig_perf out of perf_sigtrap > signal: Deliver all of the siginfo perf data in _perf > signalfd: Remove SIL_FAULT_PERF_EVENT fields from signalfd_siginfo > > Marco Elver (3): > sparc64: Add compile-time asserts for siginfo_t offsets > arm: Add compile-time asserts for siginfo_t offsets > arm64: Add compile-time asserts for siginfo_t offsets > > arch/alpha/include/uapi/asm/siginfo.h | 2 - > arch/alpha/kernel/osf_sys.c | 2 +- > arch/alpha/kernel/signal.c | 4 +- > arch/alpha/kernel/traps.c | 24 ++--- > arch/alpha/mm/fault.c | 4 +- > arch/arm/kernel/signal.c | 39 +++++++ > arch/arm64/kernel/signal.c | 39 +++++++ > arch/arm64/kernel/signal32.c | 39 +++++++ > arch/mips/include/uapi/asm/siginfo.h | 2 - > arch/sparc/include/uapi/asm/siginfo.h | 3 - > arch/sparc/kernel/process_64.c | 2 +- > arch/sparc/kernel/signal32.c | 37 +++++++ > arch/sparc/kernel/signal_64.c | 36 +++++++ > arch/sparc/kernel/sys_sparc_32.c | 2 +- > arch/sparc/kernel/sys_sparc_64.c | 2 +- > arch/sparc/kernel/traps_32.c | 22 ++-- > arch/sparc/kernel/traps_64.c | 44 ++++---- > arch/sparc/kernel/unaligned_32.c | 2 +- > arch/sparc/mm/fault_32.c | 2 +- > arch/sparc/mm/fault_64.c | 2 +- > arch/x86/kernel/signal_compat.c | 15 ++- > fs/signalfd.c | 23 ++--- > include/linux/compat.h | 10 +- > include/linux/sched/signal.h | 13 +-- > include/linux/signal.h | 3 +- > include/uapi/asm-generic/siginfo.h | 20 ++-- > include/uapi/linux/signalfd.h | 4 +- > kernel/events/core.c | 11 +- > kernel/signal.c | 113 +++++++++++++-------- > .../selftests/perf_events/sigtrap_threads.c | 12 +-- > 30 files changed, 373 insertions(+), 160 deletions(-) Looks good, thanks a lot! I ran selftests/perf_events on x86-64, and build-tested x86-32, arm, arm64, sparc, alpha. I added my Reviewed/Acked-by to the various patches. Thanks, -- Marco