From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72D0C56202 for ; Mon, 23 Nov 2020 13:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CF0820575 for ; Mon, 23 Nov 2020 13:09:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TjKKxvzD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388730AbgKWNIn (ORCPT ); Mon, 23 Nov 2020 08:08:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388713AbgKWNIV (ORCPT ); Mon, 23 Nov 2020 08:08:21 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4472CC061A4E for ; Mon, 23 Nov 2020 05:08:21 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id o3so15798258ota.8 for ; Mon, 23 Nov 2020 05:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XOXAAY/4nvkcRrNExNVW2w/236SkW1Wa7iXXWBvmVzk=; b=TjKKxvzDW2xRKxIFZmHVFhGbVxv0QEA4azsjh4Se746LrbtvwDBbIpopLLJPcdhJuI o1UN/Sgy+csMwaKTMGZjpYSYYvmIyiPIPJb0BBaL970Yx0co3l6w5RlEUi5zoeO3a41o ixa59nJIh/qvyqIxi1Oh0NLbZPaCS9YL7gDr3qR0euTD9h1m8ImjYcjwxjtWd+Hb9JxT oySzIQ0UlURtEcJqYo1XjJlylqzaWFr1Zysp2vrEeH7IiLXI1zCnOHsBDlOqNUItHNct 4XZv1QveWS5lUpstKQIx2lAfZBxr0/GA6fXyIxSheWczhQdhMpmv184qnScvo2+vRaoE m1JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XOXAAY/4nvkcRrNExNVW2w/236SkW1Wa7iXXWBvmVzk=; b=sclxw2+u+JSl7Zx0HaE+88JkmOP0TTE8g6MQNTznaROK1P9c4Z3TsRehDbg6FOIsi6 rz6BXTmLqOlmjSZSztkuiwRZ0pDSpdISbzkGFj7nZxEkg51khCj+NQaCsEdC8kxdDAt8 9sdQ7Efb5pVr9Qvsbpe3LU998bQoJEJAqDcv6T1VvLTxH9c1Iu706OCb5yjkS3+iBsWZ gp/7tns3ZKVbYBjJ7h0UbsyVhKj+7vtqz3SrdlKu7fDQ8ZTmEAiVKG7xD1fIVds9bh5x 9zcaYroekyyIGKOer979CpdpJ70gvhsqsZhST78VLqbpT04Kr1tytDO+bC2bXQoA7M6n ejTA== X-Gm-Message-State: AOAM5306TtHE1R1+KVFovX1/erB+Ph6QlJt3rNq7BNQPGXuByOdI3Em3 E7H7B5fcnmXCHs8IR1PRF0xUthECpKgVNaFQiHT3xw== X-Google-Smtp-Source: ABdhPJzr6yHUX5v7BGEcMhUDV1cUCOAKiltj24nnnPzP6TuGA0Pq1ldfeUd2BvVxt3jSHtlqeTvapEQeBsyIkpdrGqc= X-Received: by 2002:a05:6830:1c76:: with SMTP id s22mr12465867otg.233.1606136900157; Mon, 23 Nov 2020 05:08:20 -0800 (PST) MIME-Version: 1.0 References: <20201116054035.211498-1-98.arpi@gmail.com> In-Reply-To: From: Marco Elver Date: Mon, 23 Nov 2020 14:08:08 +0100 Message-ID: Subject: Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing To: David Gow Cc: Arpitha Raghunandan <98.arpi@gmail.com>, Brendan Higgins , Shuah Khan , Iurii Zaikin , "Theodore Ts'o" , Andreas Dilger , "Bird, Tim" , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020 at 08:21, David Gow wrote: > On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.arpi@gmail.com> wrote: > > > > Implementation of support for parameterized testing in KUnit. This > > approach requires the creation of a test case using the > > KUNIT_CASE_PARAM() macro that accepts a generator function as input. > > > > This generator function should return the next parameter given the > > previous parameter in parameterized tests. It also provides a macro to > > generate common-case generators based on arrays. Generators may also > > optionally provide a human-readable description of parameters, which is > > displayed where available. > > > > Note, currently the result of each parameter run is displayed in > > diagnostic lines, and only the overall test case output summarizes > > TAP-compliant success or failure of all parameter runs. In future, when > > supported by kunit-tool, these can be turned into subsubtest outputs. > > > > Signed-off-by: Arpitha Raghunandan <98.arpi@gmail.com> > > Co-developed-by: Marco Elver > > Signed-off-by: Marco Elver > > --- > [Resending this because my email client re-defaulted to HTML! Aarrgh!] > > This looks good to me! I tested it in UML and x86-64 w/ KASAN, and > both worked fine. > > Reviewed-by: David Gow > Tested-by: David Gow Thank you! > Thanks for sticking with this! Will these patches be landing in 5.11 or 5.12? > -- David Thanks, -- Marco