From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7660EC433F5 for ; Wed, 18 May 2022 15:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239468AbiERPgf (ORCPT ); Wed, 18 May 2022 11:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239603AbiERPgS (ORCPT ); Wed, 18 May 2022 11:36:18 -0400 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D02110C for ; Wed, 18 May 2022 08:36:17 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id a3so4335307ybg.5 for ; Wed, 18 May 2022 08:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kF21wFqfnoIq6E9PfI/et5u3jsgWYenFv/GCYPgvGFo=; b=Dl7ZXvqHdkFHHfpvPRKwaSX9HtbIFsnA21kFfVReO/FlBq0NbxcIE7HBg0ZK/1twUl N0b86zqrVuzFvLSsrs9zmnEs85rt8x2jgnyJ6R8mbOIgXj16mnv5EL4B345okCAbSjd8 JPlreGY/K69hPfE85mXC597DnPJ982ZbK7cCx6WDzIBzHaa2BOM/GMdk/bNYbNWUiNTX Vg6xaMEso5yqYJ2yLz04zbRL9ovtAMbij0fbgo/shCrWZrqR9+cP0OvCRNCpon9cVimc G4vBZHgmIc7xt/fEuY1J4idjTmWhAXDvR6hr2PZE1j2w1iChgxpcG1aPZOKRhbQ9wOFc ikIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kF21wFqfnoIq6E9PfI/et5u3jsgWYenFv/GCYPgvGFo=; b=q5blxuHDqpqBiwaQwxHPtWoDWp3gKbqmwfUlBpC43cft80MSjS5PGlf4QKAIaG3SpK fb4okH2KT/6cMQMECiHpNs2vgra9/wRvK7oibfNDAcmi3d09+vcNNM8yTb0uTNsu71Hl DOdif+LtpNwt8WIRbJwifJngP6Tr+XdCcM52MLgfDlfLEPHpXIkpPlytXLuiVszF3CkG XHRLgy0j+SyRD8Oy5uRYcF37LnK1Na0mWvjbkekrrJ2soOJ3OPw/DX8G4diusnrWIHpc ZCY/li+Pjj8DbzAE3XYf8NnNj7J8416/8ku0Z3C6UaAiWiJalmgv0ramQLcRVa0/fA06 EHcQ== X-Gm-Message-State: AOAM531NtHTHX3PatTR5mr4Q8rNIdSTy68oiw16BkMs8gPfnrfqmWahZ NiSS6sxkVTefUcpdi/CAXLHHVBk5a3UkX4VmauQemg== X-Google-Smtp-Source: ABdhPJwG02uHnQK4LGyyxI05x6DXQeuqD7zYnQ4JVQKs+mGZyUa2XmGgof24y4NzNhTTv5jQFZHm/J/CT4HJkQgJCPM= X-Received: by 2002:a25:2d4b:0:b0:64d:a722:b4ae with SMTP id s11-20020a252d4b000000b0064da722b4aemr180011ybe.87.1652888176675; Wed, 18 May 2022 08:36:16 -0700 (PDT) MIME-Version: 1.0 References: <20220518073232.526443-1-davidgow@google.com> In-Reply-To: From: Marco Elver Date: Wed, 18 May 2022 17:35:40 +0200 Message-ID: Subject: Re: [PATCH 1/2] kunit: tool: Add x86_64-smp architecture for SMP testing To: Daniel Latypov Cc: David Gow , Brendan Higgins , Shuah Khan , Dmitry Vyukov , kunit-dev@googlegroups.com, kasan-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2022 at 17:31, Daniel Latypov wrote: > > On Wed, May 18, 2022 at 12:32 AM 'David Gow' via KUnit Development > wrote: > > > > Add a new QEMU config for kunit_tool, x86_64-smp, which provides an > > 8-cpu SMP setup. No other kunit_tool configurations provide an SMP > > setup, so this is the best bet for testing things like KCSAN, which > > require a multicore/multi-cpu system. > > > > The choice of 8 CPUs is pretty arbitrary: it's enough to get tests like > > KCSAN to run with a nontrivial number of worker threads, while still > > working relatively quickly on older machines. > > > > Since it's arbitrary, I somewhat prefer the idea of leaving up > entirely to the caller > i.e. > $ kunit.py run --kconfig_add=CONFIG_SMP=y --qemu_args '-smp 8' > > We could add CONFIG_SMP=y to the default qemu_configs/*.py and do > $ kunit.py run --qemu_args '-smp 8' > but I'd prefer the first, even if it is more verbose. > > Marco, does this seem reasonable from your perspective? Either way works. But I wouldn't mind a sane default though, where that default can be overridden with custom number of CPUs. > I think that a new --qemu_args would be generically useful for adhoc > use and light enough that people won't need to add qemu_configs much. > E.g. I can see people wanting multiple NUMA nodes, a specific -cpu, and so on.