From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A135CA9EA0 for ; Tue, 22 Oct 2019 13:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA99A2184C for ; Tue, 22 Oct 2019 13:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OA8cRa7t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731780AbfJVNCv (ORCPT ); Tue, 22 Oct 2019 09:02:51 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:34738 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731583AbfJVNCu (ORCPT ); Tue, 22 Oct 2019 09:02:50 -0400 Received: by mail-oi1-f193.google.com with SMTP id 83so14101712oii.1 for ; Tue, 22 Oct 2019 06:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuKLQUxYTkpNquMkRmE+sotbdgdLrnH62e1xn6PHfbU=; b=OA8cRa7tD6FPhuQ4fOfUw/N5hOeyF7n/lLzNq3Ht4ejf7flFCx3QqXSB5bOT1sLk73 ZsryZ3JVOnRII4PQhu6d29eVoQye7p4mGl8rHMBpQgoiZzib5f6zyc7OVSxrZYXHFDpH gRYOr6/6wRM57aYrxTehevcSTyrRWPDQ2eYFYNJPStg78PuxujyDxr3z66sy68ynlc8V cdWBK4hJXpdo806HSFYYN/pKKpf5xyJ2W+nA8dkv3Ku7Zt/5LIlFI5ETaE6sVUO+GY8A kiPxxwJp8i0cpt9wfhKYSMxbt4zahzUejFDk87y6aY5rE4ozijMMry/LOQ0WiLDqDqr8 pYrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuKLQUxYTkpNquMkRmE+sotbdgdLrnH62e1xn6PHfbU=; b=iXItLkQDDp6lSQrHDcADHPAqwebZcAptUZR5JI0/9DDsHIeELBWSxO/7vSZdY5rE4d IFset3OiVx9Q8FnAjmAyNXFzI8xXeKGsVHIfimF555hQx9XBmWg80WLSxpUi3SXon3EF k6IbiNFC/BE50qANTx2CkzzFWLBn69ZgMdgZGY+C8w5mjPPyOcXxa5oZa+BtU9mzZays Rk1rbkiUpLEcWariUu3CWBivohIiS+pAXGEPiBRu7IpefLqaG4IdtBDcPY+wB89/0W9G jd6G2Ia2KwVydGgTqC73kZdWlrLtP+As+2Jigg4uxZu5drCWKqZ6+xAd0n3NH2mWBgzM ny3A== X-Gm-Message-State: APjAAAXARbM37tBRif9B+11ms8nXfHD++/lBwZC5kpovDPsFiChOz6Lh OmMNjBPltBoN5nwxs2VIy6YGHtebssyYEEEfrSBKJg== X-Google-Smtp-Source: APXvYqyE6JC7ar+RMfPYe2Bc7CF9ZEa9LQOjvcDMXILupXpHwW11aEDB46Lmm6zDvKX0yjzZjdW35NrOtLMI1hgKKkw= X-Received: by 2002:aca:f1a:: with SMTP id 26mr2807399oip.172.1571749369044; Tue, 22 Oct 2019 06:02:49 -0700 (PDT) MIME-Version: 1.0 References: <20191017141305.146193-1-elver@google.com> <20191017141305.146193-9-elver@google.com> <20191022125921.GD11583@lakrids.cambridge.arm.com> In-Reply-To: <20191022125921.GD11583@lakrids.cambridge.arm.com> From: Marco Elver Date: Tue, 22 Oct 2019 15:02:37 +0200 Message-ID: Subject: Re: [PATCH v2 8/8] x86, kcsan: Enable KCSAN for x86 To: Mark Rutland Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Nicholas Piggin , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Oct 2019 at 14:59, Mark Rutland wrote: > > On Thu, Oct 17, 2019 at 04:13:05PM +0200, Marco Elver wrote: > > This patch enables KCSAN for x86, with updates to build rules to not use > > KCSAN for several incompatible compilation units. > > > > Signed-off-by: Marco Elver > > --- > > v2: > > * Document build exceptions where no previous above comment explained > > why we cannot instrument. > > --- > > arch/x86/Kconfig | 1 + > > arch/x86/boot/Makefile | 2 ++ > > arch/x86/boot/compressed/Makefile | 2 ++ > > arch/x86/entry/vdso/Makefile | 3 +++ > > arch/x86/include/asm/bitops.h | 6 +++++- > > arch/x86/kernel/Makefile | 7 +++++++ > > arch/x86/kernel/cpu/Makefile | 3 +++ > > arch/x86/lib/Makefile | 4 ++++ > > arch/x86/mm/Makefile | 3 +++ > > arch/x86/purgatory/Makefile | 2 ++ > > arch/x86/realmode/Makefile | 3 +++ > > arch/x86/realmode/rm/Makefile | 3 +++ > > drivers/firmware/efi/libstub/Makefile | 2 ++ > > 13 files changed, 40 insertions(+), 1 deletion(-) > > > diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile > > index 0460c7581220..693d0a94b118 100644 > > --- a/drivers/firmware/efi/libstub/Makefile > > +++ b/drivers/firmware/efi/libstub/Makefile > > @@ -31,7 +31,9 @@ KBUILD_CFLAGS := $(cflags-y) -DDISABLE_BRANCH_PROFILING \ > > -D__DISABLE_EXPORTS > > > > GCOV_PROFILE := n > > +# Sanitizer runtimes are unavailable and cannot be linked here. > > KASAN_SANITIZE := n > > +KCSAN_SANITIZE := n > > UBSAN_SANITIZE := n > > OBJECT_FILES_NON_STANDARD := y > > Not a big deal, but it might make sense to move the EFI stub exception > to patch 3 since it isn't x86 specific (and will also apply for arm64). Thanks for spotting, moved for v3. -- Marco > Otherwise this looks good to me. > > Thanks, > Mark.