From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7DE37E2E7 for ; Mon, 29 Jun 2026 22:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782773267; cv=pass; b=Le/m7EQNBQBaM1WWzkaVudNFanRxtGJcwP98I4QjVkQYlUC3YSvozCVfcD2qBQJagRZMaAmMNDrHZwDoPdoNjYQvkvBURfxLb+z5ye6IJ6BXVn91vYd+xPbThAMVDtAtFejuIJrMUJSIdVQbwlqwCMQ5ETOLNesi+UFhZmmN/ZQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782773267; c=relaxed/simple; bh=827BhRSimtQiOFT3iepZmiWGF900PAwo+ryRAhSbqUs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Dzk3ND8HySH6iEw5UnMhMlXQWKY6KL+iO03x3HjNLC1zin7lx3h/7W8UQw1d9f86/hBpDjQXH25nCky5utFvP4IH/bw/RI6yj0L3eK2e0WdPSF3+l3cbM1KGp2nS7msGkU4a2DvOqT4TV7zHD0xvGK/qp2JDfwKIHESRaGvkzTA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=f8uPDEku; arc=pass smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f8uPDEku" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-13981833e13so4718704c88.1 for ; Mon, 29 Jun 2026 15:47:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782773265; cv=none; d=google.com; s=arc-20260327; b=riAHbEuQIr60pn+LL1zNEh/hNDcbPTetax+2Tjvt8lxaY4fC6UT5nZ2WOiFzfwukEA RQ8mR64yAhzqaYBN/NyjYW1SLg2LASJ6YQmHhyfjI7W8K9xiSjTwcT5UeWRJC3K4tZ52 uj+G0QTSwCv0F19YmM0n1cFksKB3P/OrqvQmugLvkssLvn7VkVJjrrBF2GzvHcovfYIm ARO6oLi+38zoC0ToCWT9CW4bwLId+GFPfF+EPlKKufDZsDvZpgO0G97g8RBgNMJB4XYm hkI53A41ffR4kUFhvTlGH9N0/aN3DYusoSONUuilgjFQYXcegOg2JhNHh6zYA9HRjl1l o6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=em5zCJrORblXF6ZwaZ+68vuw/ptEQHtpGgIbYM3pA/o=; fh=D/e6D/ynEqki1ojiwrJFUFhtyyfQsb8dcvjzlq7Dd0Y=; b=g9bQBkCJN0HuiXdHEtHMRYlECjn0GGaRQuqW5o0k/QxSJpOFuM5hWt2S7UT7smLWzo xLY4sVeR6zxy3VQdMFCjOgG3nvvtIN5BcAAlk17Pk7M7RIRBbog4JqC79HWzdGD8h42E EPFLxbMOenoQ0zPijcoBVuz3vPlACvSPy+kgSwKKO98p4SRk3fMNH0DydRd8XbT1k2L2 hVOnhQdw5S0Ge0y44/xM/muehKHEh5cGx1cgv0BlEPeDocFzVQldin6he5pOyvlwxkm1 9pLlyrqp9nF/ZwYJq2j8NvIECwfPBTu/gVwZxhu1/IDQ5GnZMP6Uq/h+EYVLSX/Qbckb BoPg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782773265; x=1783378065; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=em5zCJrORblXF6ZwaZ+68vuw/ptEQHtpGgIbYM3pA/o=; b=f8uPDEkuiOlCE7BvWTIrtKAOSPsnBKWpk+dewsUyzEO9sALeMzuUI+/ZyVfFbov40x NCEuojuW5+WNm5d5BYFBF9ilEKoDK6HGEX0AUoxSS7zknEnglqjBT0h/pyozTfJ7RZbS 8bcmeLdws1Yw45l7OD8M0xYlAOsAudkSPVOwtR+Ozv2C3itWyQZBCLXGtww5AhNrAI8A qyBIml3N3y9FEl6uPcuKJKc3D3wqg9USPHnJlPZplwjcYiDJxb+8u3PCTYzlfLdK9rPE tJMSTBwXqwXUnPr7Rqk8zSbL3oaSmefJTwYpwRKGKmWRxc2BkMGJPDikCcrs5t9GRJy2 X7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782773265; x=1783378065; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=em5zCJrORblXF6ZwaZ+68vuw/ptEQHtpGgIbYM3pA/o=; b=nAJ+ucgFRkBr3IXV128LfrX+IUuo/xCB/lpN+fMy7PW1gXAlc+BJRPtss/MAAZSOj8 2xWCfOlpTTl146j3BDOppbzq4evH/j0QecI4hdcka90VZjBztwsrJ0Lg+DiEoVnwKLj5 28CFwKmkG2Bvf13RVLGQ84FvtMywXD8cohB8q1n4y97YFx2ecnuZAFfSQIlh0HL/CYDu tcddIuy9820U6fC0+6J3d/Xs9pdB8JdeYPqByQRzT1ir2XtsrCuNednAoFOAhWj9X3BD 8uCft2ZhoEMqqWj5F8TAAbh4FruSU6na/zczaH63I727EGkQGiR/+kmyC65m2BqzYoZw jmEA== X-Forwarded-Encrypted: i=1; AFNElJ9Ty0vC7gI13DFfRJWrIfwbmr0SRVecFKoDz4cyB2WoqndMbXwYQUcNp1ObI0FLdHeGk9KDsGG4hLnXTXE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyok588cfyLhiREJAHYILn5XiCPgAg8sMINmpCTad8Mpcr6hLN9 vglVwrgfflF/R6fP8fjRQ+XvdrqFJypzJ5TB38CNPDeN/LG/T8je6n7jzbnlNnCirMEgbW+GTnp MF/uMGVBINaux7uvydF7HSFB8YPU4LbSX/drbmuy7 X-Gm-Gg: AfdE7cmqIXrzlOi/g1obNyFCtixqNLt09RPXfQfwgKyqKCzNTHfl7J9dfYhY24Dw1ZM O/2tW/jeJOlfBT/IhlQwq4i/l9N2jXdZTSFnf/bHRaEVsdboHAs3hPjBCAPkFpGbjQ/B8UuUkvz e6lELUXbSgAOmEej/sz1fACnIv6XPt2VzQoTzGWXKIxvmG4NTSSlqbocKJld5UbSTDr3j2hCs1J PqBRrPi+YKSwk6bcUIKRsoaYwGWZGRjgov/6vZpEm3UImQD3oPW9EgfH4PusGerMsO07LdfsAP4 I7wigg== X-Received: by 2002:a05:7022:7a5:b0:139:9e79:43fa with SMTP id a92af1059eb24-13b2a1602a6mr681055c88.9.1782773264731; Mon, 29 Jun 2026 15:47:44 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260614131541.2017845-1-nilay@linux.ibm.com> <20260614131541.2017845-15-nilay@linux.ibm.com> <20260626064916.GC11106@lst.de> <20260629125054.GC23695@lst.de> In-Reply-To: <20260629125054.GC23695@lst.de> From: Marco Elver Date: Tue, 30 Jun 2026 00:47:08 +0200 X-Gm-Features: AVVi8CdCfyw5QUlPYng-1Iw4VBbAyMKxvxPdjnmeMfmbbNF6QexIOCemsewC8QI Message-ID: Subject: Re: [PATCHv2 14/17] nvme: fix Clang context analysis warning in rdma.c To: Christoph Hellwig Cc: Nilay Shroff , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com Content-Type: text/plain; charset="UTF-8" On Mon, 29 Jun 2026 at 14:50, Christoph Hellwig wrote: > > On Fri, Jun 26, 2026 at 09:01:20PM +0530, Nilay Shroff wrote: > >> Does switching to list_empty_careful fix this? If not, does > >> list_empty_careful need annotations to make this work? > >> > > > > I tried using list_empty_careful() but clang still throws the > > same warning. And yes it needs same annotation to suppress > > the warning. > > Sounds like we should have annotations (or just use of data_race) > in list_empty_careful, as it is designed to be used without holding > the relevant lock used for modifications? Given list_empty_careful() is a real inline function (not a macro), you can just add __no_context_analysis to list_empty_careful(), which should also suppress warnings about pointer-to-guarded-variable being passed as an argument into it. data_race() wouldn't work, as the warning is generated in the caller, but when the attribute is added to the callee, it also suppresses warnings about arguments in the caller.