From: Eric Curtin <ericcurtin17@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: ibm-acpi-devel@lists.sourceforge.net,
Darren Hart <dvhart@infradead.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
ibm-acpi@hmh.eng.br,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: [PATCH] Remove logging for "Unsupported brightness interface"
Date: Sat, 16 Jan 2016 23:43:57 +0000 [thread overview]
Message-ID: <CANpvso6S3jH0qYoPRmoNAc7sCsRd4UkosfzXFBAuLLUuZaPKCw@mail.gmail.com> (raw)
Message gets logged on machines that are well supported.
Fixed one checkpatch.pl ERROR also.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
drivers/platform/x86/thinkpad_acpi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 0bed473..b149dec 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
brightness_quirk_table[] __initconst = {
*/
static void __init tpacpi_detect_brightness_capabilities(void)
{
- unsigned int b;
+ const unsigned int b = tpacpi_check_std_acpi_brightness_support();
vdbg_printk(TPACPI_DBG_INIT,
"detecting firmware brightness interface capabilities\n");
@@ -6447,7 +6447,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
* Lenovo Vista BIOS to ACPI brightness mode even if we are not
* going to publish a backlight interface
*/
- b = tpacpi_check_std_acpi_brightness_support();
switch (b) {
case 16:
bright_maxlvl = 15;
@@ -6459,7 +6458,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_info("Unsupported brightness interface\n");
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
@@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = {
#define alsa_card NULL
-static void inline volume_alsa_notify_change(void)
+static inline void volume_alsa_notify_change(void)
{
}
--
2.5.0
next reply other threads:[~2016-01-16 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 23:43 Eric Curtin [this message]
2016-01-21 11:18 ` Eric Curtin
2016-01-21 13:54 ` Henrique de Moraes Holschuh
[not found] ` <CANpvso5EHVvFeOmi312cf4wDrZavZZFegMvNyj7ZzoBNMcpr8g@mail.gmail.com>
2016-01-26 19:39 ` Eric Curtin
-- strict thread matches above, loose matches on Subject: below --
2016-01-16 22:48 Eric Curtin
2016-01-16 23:21 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpvso6S3jH0qYoPRmoNAc7sCsRd4UkosfzXFBAuLLUuZaPKCw@mail.gmail.com \
--to=ericcurtin17@gmail.com \
--cc=dvhart@infradead.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®