From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933380AbbLSWWw (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Dec 2015 17:22:52 -0500
Received: from mail-io0-f171.google.com ([209.85.223.171]:35225 "EHLO
	mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932727AbbLSWWu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Dec 2015 17:22:50 -0500
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1512191603300.28591@nanos>
References: <20151215061250.GA7233@localhost.localdomain>
	<alpine.DEB.2.11.1512191603300.28591@nanos>
Date: Sat, 19 Dec 2015 15:22:50 -0700
Message-ID: <CAO6TR8UQ9VbqrfWdvFtvi9uogggMvbvTY2UFT2VwPgtxqModKQ@mail.gmail.com>
Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints
From: Jeff Merkey <linux.mdb@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, peterz@infradead.org, luto@kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/19/15, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 14 Dec 2015, Jeff Merkey wrote:
>> +		/*
>> +		* check if we got an execute breakpoint
>> +		* from the dr7 register.  if we did, set
>> +		* the resume flag to avoid int1 recursion.
>
> Malformatted comment as any other comment you touched.
>
>> +		*/
>> +		if ((dr7 & (3 << ((i * 4) + 16))) == 0)
>> +			args->regs->flags |= X86_EFLAGS_RF;
>
> This still uses magic numbers instead of the proper defines. I asked
> for that before.
>
> Thanks,
>
> 	tglx
>


Yes Sir,

I'll get that fixed right away.

Jeff