From: Suchit Karunakaran <suchitkarunakaran@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] tsacct: Remove unused macro definition
Date: Tue, 29 Jul 2025 12:07:46 +0530 [thread overview]
Message-ID: <CAO9wTFj8d3Toafof0MBvPybfDMsAAuJ4rxrH0EMcVqZZrg0VCA@mail.gmail.com> (raw)
In-Reply-To: <2025072935-mardi-propeller-0d29@gregkh>
On Tue, 29 Jul 2025 at 11:22, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 29, 2025 at 11:03:59AM +0530, Suchit Karunakaran wrote:
> > The MB macro was defined in tsacct.c but never used, leading to a compiler
> > warning. This patch removes the unused definition to clean up the code and
> > suppress the warning.
>
> What compiler warning shows this? As part of a normal build?
>
It's not part of the normal build. I built the kernel with C=1 and V=1 flags.
> We have loads of defines that are not used, especially in drivers, are
> we now going to start deleting them all?
>
Agreed, sorry for the inconvenience.
prev parent reply other threads:[~2025-07-29 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 5:33 Suchit Karunakaran
2025-07-29 5:52 ` Greg KH
2025-07-29 6:37 ` Suchit Karunakaran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9wTFj8d3Toafof0MBvPybfDMsAAuJ4rxrH0EMcVqZZrg0VCA@mail.gmail.com \
--to=suchitkarunakaran@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®